-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM Edge Talks added #206
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: In the first patch, there are inconsistencies with the author's name and email address in the The second patch seems to be a straightforward update to talk titles and video URLs, with no identified potential problems. The third patch, however, raises concerns. The removal of the "Talks" section and related content might affect the functionality and completeness of the web page. The reasoning behind this change is unclear, as there is no explanation provided in the patch or associated documentation. To improve the quality and clarity of these changes, it is recommended that the issues mentioned in the potential problems section are addressed. Additionally, providing clear explanations and context in the commit messages or documentation will help in understanding the purpose and impact of the changes. DetailsCommit ab2f3bf00677b8d139a4e1a603508478fb8ab40eKey Changes:
Potential Problems:
Commit 5cd2fe56f92d79a97585b31d02579dd19a6bedcfKey Changes:
Potential Problems:
Commit 4a430ca7c59904a4cbe689ed068120849b56bafaKey Changes:
Potential Problems:
|
Thanks for your contribution. The DCO test failed. Please fix it. Thanks. And I think some of the talks are not about WasmEdge. Could you please double check with it? Thanks. |
All the Talks are related to WASMEdge some of are hands-on tutorials. and how can sign-in to merge the commits |
Please check out this article https://www.secondstate.io/articles/dco/ |
Now DCO is verified what to do @alabulei1 ? |
Hi @kelvinparmar I'm sue that the above talks are not about WasmEdge. Please remove them. Thanks. |
Signed-off-by: kelvin <[email protected]>
Signed-off-by: kelvin <[email protected]>
Signed-off-by: kelvin <[email protected]>
@alabulei1 Why this PR is not merging this shows me Merging is blocked |
* Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]>
* Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]>
* Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]>
* Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]>
* Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]> Signed-off-by: Kelvin Parmar <[email protected]>
* WASM Edge Talks added (#206) * Talks added Signed-off-by: kelvin <[email protected]> * Changes Signed-off-by: kelvin <[email protected]> * Talks removed Signed-off-by: kelvin <[email protected]> --------- Signed-off-by: kelvin <[email protected]> Signed-off-by: Kelvin Parmar <[email protected]> * Fix the outdated llm document Signed-off-by: hydai <[email protected]> Signed-off-by: kelvin <[email protected]> Signed-off-by: Kelvin Parmar <[email protected]> * vifeo removed from the talks page Signed-off-by: kelvin <[email protected]> Signed-off-by: Kelvin Parmar <[email protected]> * conflict resolved Signed-off-by: Kelvin Parmar <[email protected]> --------- Signed-off-by: kelvin <[email protected]> Signed-off-by: Kelvin Parmar <[email protected]> Signed-off-by: hydai <[email protected]> Co-authored-by: hydai <[email protected]>
Explanation
This PR is for the WASM Edge 2023 talks into Documentation
Related issue
What type of PR is this
Proposed Changes
In this PR I have added WASM Edge 2023 talks links.
Before
After