Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM Edge Talks added #206

Merged
merged 3 commits into from
Feb 2, 2024
Merged

WASM Edge Talks added #206

merged 3 commits into from
Feb 2, 2024

Conversation

kelvinparmar
Copy link
Contributor

Explanation

This PR is for the WASM Edge 2023 talks into Documentation

Related issue

What type of PR is this

kind documentation

Proposed Changes

In this PR I have added WASM Edge 2023 talks links.

Before
screencapture-wasmedge-org-docs-talks-2024-01-22-08_25_05

After

screencapture-3000-kelvinparmar-docs-yutjdjea8ny-ws-us107-gitpod-io-docs-talks-2024-01-22-08_24_43

Copy link
Collaborator

alabulei1 commented Jan 22, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:
This Pull Request introduces multiple patches related to the addition, rearrangement, and removal of talks in the talks.md file. While some patches are straightforward, there are a few potential problems and findings that need to be addressed.

In the first patch, there are inconsistencies with the author's name and email address in the Signed-off-by field. Additionally, there is a possibility of duplication in the talk titles. The relevance of the added talks to the project or the review process is uncertain. The formatting of the patch also lacks consistency in terms of extra spacing.

The second patch seems to be a straightforward update to talk titles and video URLs, with no identified potential problems.

The third patch, however, raises concerns. The removal of the "Talks" section and related content might affect the functionality and completeness of the web page. The reasoning behind this change is unclear, as there is no explanation provided in the patch or associated documentation.

To improve the quality and clarity of these changes, it is recommended that the issues mentioned in the potential problems section are addressed. Additionally, providing clear explanations and context in the commit messages or documentation will help in understanding the purpose and impact of the changes.

Details

Commit ab2f3bf00677b8d139a4e1a603508478fb8ab40e

Key Changes:

  • Added a list of talks with their titles, speakers, and video URLs.

Potential Problems:

  • The email address in the Signed-off-by field does not match the author's name.
  • There might be duplication as the talk "Hands on with WebAssembly Microservices & Kubernetes" appears twice.
  • It is not clear if the added talks have any relation to the project or if they are relevant for review.
  • The formatting of the patch is not consistent. Some lines have extra spacing, while others do not.

Commit 5cd2fe56f92d79a97585b31d02579dd19a6bedcf

Key Changes:

  • The December 5th and December 6th talks have been rearranged and their titles have been updated.
  • The video URLs for the talks have been updated.

Potential Problems:

  • There are no potential problems identified in this patch. The changes seem to be straightforward updates to the talk titles and video URLs.

Commit 4a430ca7c59904a4cbe689ed068120849b56bafa

Key Changes:

  • The "Talks" section in the talks.md file has been removed.
  • The content related to various talks and their YouTube video URLs has been deleted.

Potential Problems:

  • It seems that all the content related to talks and their video URLs has been completely removed. This might affect the functionality or completeness of the web page, as visitors will no longer be able to view or access the talks. This change should be reviewed to confirm whether it was intentional or accidental. If it was intentional, the reasoning behind the removal should be checked.
  • The patch does not provide any information about why the talks were removed or the motivation behind this change. This lack of context makes it challenging to evaluate the impact or necessity of the change. A clear explanation should be provided in the commit message or associated documentation for better understanding.

@alabulei1
Copy link
Collaborator

Hi @kelvinparmar

Thanks for your contribution. The DCO test failed. Please fix it. Thanks.

And I think some of the talks are not about WasmEdge. Could you please double check with it? Thanks.

@kelvinparmar
Copy link
Contributor Author

Hi @kelvinparmar

Thanks for your contribution. The DCO test failed. Please fix it. Thanks.

And I think some of the talks are not about WasmEdge. Could you please double check with it? Thanks.

All the Talks are related to WASMEdge some of are hands-on tutorials. and how can sign-in to merge the commits

@alabulei1
Copy link
Collaborator

Please check out this article https://www.secondstate.io/articles/dco/

@kelvinparmar
Copy link
Contributor Author

Now DCO is verified what to do @alabulei1 ?

@alabulei1
Copy link
Collaborator

image
image
image
image
image

Hi @kelvinparmar I'm sue that the above talks are not about WasmEdge. Please remove them. Thanks.

Signed-off-by: kelvin <[email protected]>
Signed-off-by: kelvin <[email protected]>
Signed-off-by: kelvin <[email protected]>
@kelvinparmar
Copy link
Contributor Author

image image image image image

Hi @kelvinparmar I'm sue that the above talks are not about WasmEdge. Please remove them. Thanks.

@alabulei1 Why this PR is not merging this shows me Merging is blocked

@alabulei1 alabulei1 merged commit 709c0a5 into WasmEdge:main Feb 2, 2024
6 checks passed
@alabulei1
Copy link
Collaborator

Hi @kelvinparmar

Could you please remove the following one? You forgot to remove this one. Thanks.
image

kelvinparmar added a commit to kelvinparmar/docs that referenced this pull request Feb 2, 2024
* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
kelvinparmar added a commit to kelvinparmar/docs that referenced this pull request Feb 2, 2024
* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
kelvinparmar added a commit to kelvinparmar/docs that referenced this pull request Feb 3, 2024
* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
kelvinparmar added a commit to kelvinparmar/docs that referenced this pull request Feb 4, 2024
* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
kelvinparmar added a commit to kelvinparmar/docs that referenced this pull request Feb 17, 2024
* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
Signed-off-by: Kelvin Parmar <[email protected]>
alabulei1 pushed a commit that referenced this pull request Feb 19, 2024
* WASM Edge Talks added (#206)

* Talks added

Signed-off-by: kelvin <[email protected]>

* Changes

Signed-off-by: kelvin <[email protected]>

* Talks removed

Signed-off-by: kelvin <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
Signed-off-by: Kelvin Parmar <[email protected]>

* Fix the outdated llm document

Signed-off-by: hydai <[email protected]>
Signed-off-by: kelvin <[email protected]>
Signed-off-by: Kelvin Parmar <[email protected]>

* vifeo removed from the talks page

Signed-off-by: kelvin <[email protected]>
Signed-off-by: Kelvin Parmar <[email protected]>

* conflict resolved

Signed-off-by: Kelvin Parmar <[email protected]>

---------

Signed-off-by: kelvin <[email protected]>
Signed-off-by: Kelvin Parmar <[email protected]>
Signed-off-by: hydai <[email protected]>
Co-authored-by: hydai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants