-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed fibonacci.wasm to fibonacci.wat #180
Conversation
Signed-off-by: tushar <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall, the pull request changes the file name from The most important findings are the inclusion of a note about converting the file to wasm using the WABT tool and the potential need for more explicit instructions on this conversion. Additionally, clarification on the reason for the file extension change would be helpful for users familiar with WebAssembly. In summary, no functional or logical issues are expected due to the name change, but further verification is needed. DetailsCommit 06ae3248a2e05dba08a39fd2d31349de22c520daKey changes in the pull request are as follows:
Potential problems:
Commit c3d577149febb4c19ecef5928eec4c8c7f5a5c79Key Changes:
Potential Problems:
Overall, the changes seem straightforward and primarily involve updating references to the file name extension. |
Hi @hydai, Could you please take another look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer ship WASM files. So these lines should change to fibonacci.wat
and ask users to convert it to WASM via the wat2wasm
tool.
Signed-off-by: tushar <[email protected]>
@hydai I have added a note regarding wat2wasm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
In the documentation, the fibonacci.wasm file link leads to 404 page since, Now the directory contains .wat files.