Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wasmedge-ebpf and wasmedge-rusttls #179

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

adithyaakrishna
Copy link
Contributor

Description:

This PR Fixes #164

Copy link
Collaborator

alabulei1 commented Oct 21, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 5ce906b9e80ee9c6ff2bc09df72d5776093cebde

The key changes in this patch are the addition of two new plugins: "WasmEdge-EBPF" and "WasmEdge-RustTLS". These plugins are added to the existing list of plugins in the docs/start/wasmedge/extensions/plugins.md file.

Potential problems:

  1. There is a conflict between the old and new versions of the plugins.md file. The changed lines have inconsistent indentation, making it difficult to determine the exact changes made. This should be fixed for better code readability.

  2. The new plugin "WasmEdge-EBPF" has incomplete information. The description and platform support are missing. The missing details should be added for clarity.

Please note that these are the initial findings based on the provided patch. A more comprehensive review may be required to identify any other potential problems.

@adithyaakrishna adithyaakrishna changed the title feat: add wasmedge-ebpf & wasmedge-rusttls feat: add wasmedge-ebpf and wasmedge-rusttls Oct 21, 2023
@adithyaakrishna
Copy link
Contributor Author

@alabulei1 Could you please lmk if the changes look good or if any other changes are necessary?

Copy link
Contributor

@mhmohona mhmohona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✨

@alabulei1 alabulei1 merged commit 55b4dbe into WasmEdge:main Nov 2, 2023
6 checks passed
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 10, 2023
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 10, 2023
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ebpf and rusttls on the plugin introductions page
3 participants