-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken github link (fibonacci.wasm) #173
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The overall summary for the GitHub Pull Request titled "Fixed broken github link (fibonacci.wasm)" is that it addresses two main issues - a broken GitHub link to the The first set of changes fixes the broken GitHub link by updating it to the correct URL. There are no potential problems identified in this patch. The second set of changes updates the installation description and file paths for the Overall, the patch is focused on fixing the broken GitHub link and updating the installation instructions, but some additional explanations would improve understanding of the changes. DetailsCommit 7b9ddf77ccb4b3639f0d60af77b57f0d9fb51106Key changes:
Potential problems:
Overall, the patch fixes the broken GitHub link for the Commit a37dbb1475722a520f2fe2c5051f7ba13c5b6397Key changes:
Potential problems:
Commit c56d8e004de8a3d0bedb9852d1ebda868326a6cfKey changes:
Potential problems:
Overall, the changes seem straightforward and focused on updating the installation instructions to reflect the current state of the project. However, some additional context or documentation would be valuable to understand the reasoning behind the changes. Commit 5d055b5f618d87f73503c5a303d302067f13e352Key changes:
Potential problems:
|
i18n/zh/docusaurus-plugin-content-docs/current/embed/c/intro.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alabulei1 @hydai Could you please take another look at this PR?
The DCO has failed. Please fix it first. |
Signed-off-by: Tushar Adhatrao <[email protected]> Signed-off-by: tushar <[email protected]>
Co-authored-by: Adithya Krishna <[email protected]> Signed-off-by: tushar <[email protected]>
* Update the installation description for `wasmedge_rustls_plugin` Starting with WasmEdge v0.13.4, the `wasmedge_rustls_plugin` has been bundled within the WasmEdge core (ref: https://github.com/WasmEdge/WasmEdge/releases/tag/0.13.4). Therefore, this patch modifies the installation instructions for rustls_plugin to indicate that it should be retrieved from the `WasmEdge/WasmEdge` repository, rather than from the `second-state/wasmedge_rustls_plugin`. Signed-off-by: moznion <[email protected]> * Fix the wasmedge_rustls_plugin installation description with sudo Signed-off-by: moznion <[email protected]> --------- Signed-off-by: moznion <[email protected]> Signed-off-by: tushar <[email protected]>
Signed-off-by: tushar <[email protected]>
@hydai DCO has been fixed. |
Explanation
In the documentation, the fibonacci.wasm file link leads to 404 page since, Now the directory contains .wat files.