Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken github link (fibonacci.wasm) #173

Closed
wants to merge 4 commits into from
Closed

Fixed broken github link (fibonacci.wasm) #173

wants to merge 4 commits into from

Conversation

tusharad
Copy link
Contributor

Explanation

In the documentation, the fibonacci.wasm file link leads to 404 page since, Now the directory contains .wat files.

Copy link
Collaborator

alabulei1 commented Sep 20, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

The overall summary for the GitHub Pull Request titled "Fixed broken github link (fibonacci.wasm)" is that it addresses two main issues - a broken GitHub link to the fibonacci.wasm file and updates to the installation description and file paths for the wasmedge_rustls_plugin.

The first set of changes fixes the broken GitHub link by updating it to the correct URL. There are no potential problems identified in this patch.

The second set of changes updates the installation description and file paths for the wasmedge_rustls_plugin. There are no potential problems identified in this patch, but some additional context or documentation would be helpful to understand the reasoning behind the changes. Specifically, it would be valuable to know why the download URL for the plugin was changed and why the file names and paths were modified.

Overall, the patch is focused on fixing the broken GitHub link and updating the installation instructions, but some additional explanations would improve understanding of the changes.

Details

Commit 7b9ddf77ccb4b3639f0d60af77b57f0d9fb51106

Key changes:

  • The broken GitHub link https://github.com/WasmEdge/WasmEdge/raw/master/examples/wasm/fibonacci.wasm has been updated to https://github.com/WasmEdge/WasmEdge/tree/master/examples/wasm.
  • The author's name and email address have been included in the patch.

Potential problems:

  • The patch does not include any potential problems.

Overall, the patch fixes the broken GitHub link for the fibonacci.wasm file.

Commit a37dbb1475722a520f2fe2c5051f7ba13c5b6397

Key changes:

  • The GitHub link for the fibonacci.wasm file has been updated.

Potential problems:

  • There doesn't seem to be any issues with the patch.

Commit c56d8e004de8a3d0bedb9852d1ebda868326a6cf

Key changes:

  • Updated the installation description for wasmedge_rustls_plugin.
  • Modified the download URL for wasmedge_rustls_plugin to point to the WasmEdge repository.
  • Updated the file names and paths for copying the plugin to the appropriate locations.

Potential problems:

  • It is unclear why the download URL for wasmedge_rustls_plugin was changed. If the change was made to fix a broken link, it would be helpful to provide context or documentation on why the new URL is preferred.
  • It is also unclear why the file names and paths were modified for copying the plugin. If there were issues with the previous file names or paths, it would be helpful to explain the rationale for the changes.

Overall, the changes seem straightforward and focused on updating the installation instructions to reflect the current state of the project. However, some additional context or documentation would be valuable to understand the reasoning behind the changes.

Commit 5d055b5f618d87f73503c5a303d302067f13e352

Key changes:

  • Fixed a broken link to the fibonacci.wasm file in the intro.md documentation file.

Potential problems:

  • No potential problems were identified in this patch.

Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alabulei1 @hydai Could you please take another look at this PR?

@hydai
Copy link
Member

hydai commented Oct 26, 2023

The DCO has failed. Please fix it first.

tusharad and others added 4 commits October 26, 2023 17:48
Signed-off-by: Tushar Adhatrao <[email protected]>
Signed-off-by: tushar <[email protected]>
* Update the installation description for `wasmedge_rustls_plugin`

Starting with WasmEdge v0.13.4, the `wasmedge_rustls_plugin` has been bundled within
the WasmEdge core (ref: https://github.com/WasmEdge/WasmEdge/releases/tag/0.13.4).
Therefore, this patch modifies the installation instructions for rustls_plugin to
indicate that it should be retrieved from the `WasmEdge/WasmEdge` repository,
rather than from the `second-state/wasmedge_rustls_plugin`.

Signed-off-by: moznion <[email protected]>

* Fix the wasmedge_rustls_plugin installation description with sudo

Signed-off-by: moznion <[email protected]>

---------

Signed-off-by: moznion <[email protected]>
Signed-off-by: tushar <[email protected]>
Signed-off-by: tushar <[email protected]>
@tusharad
Copy link
Contributor Author

@hydai DCO has been fixed.

@hydai
Copy link
Member

hydai commented Oct 26, 2023

CleanShot 2023-10-26 at 20 19 27
Your commits should not contain any others. Re-signing someone else's commits is not allowed. Please make sure this PR only contains your own commits.

@tusharad tusharad closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants