Skip to content

Commit

Permalink
[ada-url] Fix tools build error (microsoft#44048)
Browse files Browse the repository at this point in the history
  • Loading branch information
LilyWangLL authored Feb 28, 2025
1 parent cca2d78 commit efb1e74
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
5 changes: 3 additions & 2 deletions ports/ada-url/no-cpm.patch
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ index 1b55e39..23ce61f 100644
# We use googletest in the tests
if(ADA_TESTING)
diff --git a/tools/cli/CMakeLists.txt b/tools/cli/CMakeLists.txt
index 397b428..5860fd1 100644
index 397b428..4b49928 100644
--- a/tools/cli/CMakeLists.txt
+++ b/tools/cli/CMakeLists.txt
@@ -8,12 +8,7 @@ if(MSVC AND BUILD_SHARED_LIBS)
@@ -8,12 +8,8 @@ if(MSVC AND BUILD_SHARED_LIBS)
"$<TARGET_FILE:ada>" # <--this is in-file
"$<TARGET_FILE_DIR:adaparse>") # <--this is out-file path
endif()
Expand All @@ -24,6 +24,7 @@ index 397b428..5860fd1 100644
- VERSION 3.2.0
- OPTIONS "CXXOPTS_BUILD_EXAMPLES NO" "CXXOPTS_BUILD_TESTS NO" "CXXOPTS_ENABLE_INSTALL YES"
-)
+find_package(cxxopts CONFIG REQUIRED)
+find_package(fmt CONFIG REQUIRED)
target_link_libraries(adaparse PRIVATE cxxopts::cxxopts fmt::fmt)

Expand Down
1 change: 1 addition & 0 deletions ports/ada-url/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "ada-url",
"version": "3.1.1",
"port-version": 1,
"description": "WHATWG-compliant and fast URL parser written in modern C++",
"homepage": "https://ada-url.com/",
"license": "MIT OR Apache-2.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/a-/ada-url.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "f54e28b057c39b440deb728045837eade4429b19",
"version": "3.1.1",
"port-version": 1
},
{
"git-tree": "28c5463040101be137c2484cb58eac89bfe17183",
"version": "3.1.1",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"ada-url": {
"baseline": "3.1.1",
"port-version": 0
"port-version": 1
},
"ade": {
"baseline": "0.1.2e",
Expand Down

0 comments on commit efb1e74

Please sign in to comment.