fix(deps): pin fast-uri to ^3.1.7 to clear seven high-severity advisories - #80
fix(deps): pin fast-uri to ^3.1.7 to clear seven high-severity advisories#80asachs01 wants to merge 1 commit into
Conversation
…ries fast-uri reaches us transitively as @modelcontextprotocol/sdk -> ajv -> fast-uri, and the lockfile resolved 3.1.0. That version is affected by seven high-severity advisories: GHSA-v2hh-gcrm-f6hx, GHSA-7p8r-x3mc-p8w7, GHSA-v39h-62p7-jpjc, GHSA-jqff-g426-hqxp, GHSA-q3j6-qgpj-74h6, GHSA-4c8g-83qw-93j6 and GHSA-f65p-4m7j-42xc. ajv validates tool input schemas on the request path, so the dependency is reachable at runtime. An npm `overrides` entry is the only lever available here: the SDK pins ajv, and ajv pins fast-uri. The pin is `^3.1.7` rather than the `>=3.1.5` used by the downstream fork that reported this, because three of the seven advisories are only patched in 3.1.6. The fork also carried overrides for brace-expansion and postcss. Neither is needed here: our lockfile already resolves brace-expansion 5.0.9 and postcss 8.5.26, both outside the affected ranges. Reported by @Tekscape-finance (Apache-2.0 fork). Claude-Session: https://claude.ai/code/session_017zLZUG2AxhqhSFL4CTiUAb
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe project pins the transitive ChangesSecurity dependency update
Priority: ⬆️ High Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: High Suggested reviewers: Merge Risk: ⚪ Minimal · up to The security dependency update is ready to merge with no remaining actionable risk identified. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adopted from the downstream
Tekscape-finance/connectwise-manage-mcpfork (Apache-2.0), with the version floor corrected.What was already handled
Their fork carried three
overrides. Two are already moot here:mainbrace-expansion^25.0.9— outside every affected rangepostcss^8.5.238.5.26— outside every affected rangefast-uri>=3.1.53.1.0— affected^3.1.7What this PR fixes
fast-urireaches us as@modelcontextprotocol/sdk→ajv→fast-uri.ajvvalidates tool input schemas on the request path, so this is a reachable runtime dependency, not build-only.3.1.0is affected by seven high-severity advisories:Why
^3.1.7and not their>=3.1.5: the last two above, plus GHSA-5jgf-p345-68v8, are only patched in 3.1.6. A>=3.1.5floor would still resolve a vulnerable tree.^3.1.7picks up the current 3.x and stays inside the majorajvexpects.An
overridesentry is the only lever available: the SDK pinsajv, andajvpinsfast-uri. The lockfile diff is 3 lines.Known remaining, deliberately not in this PR
npm audit --omit=devstill reports 7 findings, all transitive through@modelcontextprotocol/sdk's Express/Hono server helpers (hono,@hono/node-server,express-rate-limit,body-parser,path-to-regexp,qs,ip-address). This server does not import those helpers —src/index.tsusesnode:httpcreateServerplusStreamableHTTPServerTransportdirectly, andsrc/worker.tsuses the Web Standard transport. Pinning seven floors inside a vendored SDK's own dependency tree is churn that will conflict with the next SDK bump, so that belongs in an SDK upgrade rather than here. Flagging it so the decision is explicit rather than forgotten.Verification
npm auditno longer reportsfast-uri.Attribution
Vulnerability surfaced by @Tekscape-finance in their Apache-2.0 fork. Their
brace-expansionandpostcssoverrides were checked and found unnecessary against our current lockfile; theirfast-urifloor was raised from>=3.1.5to^3.1.7.https://claude.ai/code/session_017zLZUG2AxhqhSFL4CTiUAb
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
Security
New Features
Documentation