Skip to content

Add row count/numbers to forms search table; fix Khmer 'not yet approved' translation - #275

Merged
ericboucher merged 5 commits into
mainfrom
add-form-count-issue-273
Sep 4, 2026
Merged

ericboucher merged 5 commits into
mainfrom
add-form-count-issue-273

Conversation

@wadhwamatic

@wadhwamatic wadhwamatic commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

Closes #273
Closes #274

Changes

  • Forms search results table (/forms/search) now shows a # row-number column and a result count ("N records found") above the table.
  • Extracted the table header into TableHeader.tsx to keep TableDisplay.tsx under the file-length lint limit.
  • Fixed the Khmer translation for the onHold-long validation status, which incorrectly said "Report approved" instead of "Report not yet approved".

Screenshot of new feature (purple boxes are just annotations of the screenshot):
image

@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Build succeeded and deployed:

(hash eef2455 deployed at 2026-09-04T08:26:32)

Surge is deprecated and will be removed once backend CORS changes are deployed to staging. Use GitHub Pages for preview; Surge remains available until then.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The results count currently renders during loading and can incorrectly display “0 records found” (or a stale count) until data finishes loading.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds UX improvements to the Forms search results table (/forms/search) by showing row numbers and a total result count, and corrects an incorrect Khmer translation for the “not yet approved” status.

Changes:

  • Add a # row-number column to the forms search results table.
  • Add a localized “N records found” count above the table.
  • Fix Khmer onHold-long translation and extract the table header into its own component.
File summaries
File Description
apps/frontend/translations/km.json Fix Khmer onHold-long text; add results_count and row_number strings.
apps/frontend/translations/en.json Add results_count and row_number strings for the table.
apps/frontend/components/TableDisplay/TableHeader.tsx New extracted header component including the new row-number header column.
apps/frontend/components/TableDisplay/TableDisplay.tsx Render results count above the table; add row numbers in each table row; adjust loading skeleton colspan.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/frontend/components/TableDisplay/TableDisplay.tsx Outdated
Comment thread apps/frontend/components/TableDisplay/TableHeader.tsx
ericboucher and others added 3 commits September 4, 2026 10:13
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ericboucher
ericboucher force-pushed the add-form-count-issue-273 branch from 988cf8e to eef2455 Compare September 4, 2026 08:24
@ericboucher
ericboucher merged commit 11e5141 into main Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Khmer translation for forms that have not yet been approved is wrong Add row number column and result count to Forms search results

3 participants