Repository navigation
Add row count/numbers to forms search table; fix Khmer 'not yet approved' translation - #275
Conversation
|
Build succeeded and deployed:
(hash eef2455 deployed at 2026-09-04T08:26:32)
|
There was a problem hiding this comment.
🟡 Changes recommended
The results count currently renders during loading and can incorrectly display “0 records found” (or a stale count) until data finishes loading.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds UX improvements to the Forms search results table (/forms/search) by showing row numbers and a total result count, and corrects an incorrect Khmer translation for the “not yet approved” status.
Changes:
- Add a
#row-number column to the forms search results table. - Add a localized “N records found” count above the table.
- Fix Khmer
onHold-longtranslation and extract the table header into its own component.
File summaries
| File | Description |
|---|---|
| apps/frontend/translations/km.json | Fix Khmer onHold-long text; add results_count and row_number strings. |
| apps/frontend/translations/en.json | Add results_count and row_number strings for the table. |
| apps/frontend/components/TableDisplay/TableHeader.tsx | New extracted header component including the new row-number header column. |
| apps/frontend/components/TableDisplay/TableDisplay.tsx | Render results count above the table; add row numbers in each table row; adjust loading skeleton colspan. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
988cf8e to
eef2455
Compare
Closes #273
Closes #274
Changes
/forms/search) now shows a#row-number column and a result count ("N records found") above the table.TableHeader.tsxto keepTableDisplay.tsxunder the file-length lint limit.onHold-longvalidation status, which incorrectly said "Report approved" instead of "Report not yet approved".Screenshot of new feature (purple boxes are just annotations of the screenshot):
