Repository navigation
chore(resync): merge upstream main 3c205e0a4 (64 commits incl. 1.3.3 security fixes) - #78
Conversation
…backend (BD-5) (gastownhall#7912) * feat(storage): add arrival_seq to both issue planes and scan it onto types.Issue BD-5, part 1 of 3: the column and its read path, with nothing writing it yet. arrival_seq is the commit-ordered create sequence the events journal will stamp on a wisp-plane row: the seq of the row's own create record, stored on the row in the same transaction, so a consumer can recover create order from rows after the journal records are pruned. - Migration 0073 adds a nullable BIGINT to issues and wisps (guarded INFORMATION_SCHEMA + PREPARE, 0060/0067 shape). The column only means something on wisps, which is clone-local; issues carries it for shape parity and it stays NULL, the wisps.row_lock/current_revision precedent. The CLI bundle gets the direct-DDL override (dolthub/dolt#11345) and the substitute is listed in cliSubstituteAssumesWispTables. - Ignored migration 0029 carries the wisps column to fresh clones and creates the clone-local UNIQUE index uk_wisps_arrival_seq. - TestLatestVersionIncludesMigration0073 supersedes 0072's pin, the way each slot's pin has superseded the previous one. - IssueBaseColumns and IssueBaseColumnsLite select it; ScanIssueFrom and ScanIssueLiteFrom read it into types.Issue.ArrivalSeq (json:"-" until the wire half lands). The legacy SQLite projection gains its placeholder. - TestEmbeddedIgnoredMigration0023NoopsOnHealthyWorkspace now stops the ignored pass right after 0023 (SetMigrateStepFaultHookForTest) and compares SHOW CREATE TABLE across that step alone. It used to run every ignored migration and require nothing to change, which ignored/0029 now breaks by design: it adds uk_wisps_arrival_seq to wisps. The test still proves what it names, that 0023 is a no-op on a healthy workspace. - TestFullChainFromPreWispsAndMissingDependenciesIDConvergesThroughDoltCLI replays the ignored series through the dolt CLI, which no-ops 0029's PREPARE'd ADD COLUMN (the dolthub/dolt#11345 limitation 0006 already works around there), so 0029's PREPARE'd unique index would then fail on a missing column. The test applies 0029's effect as Go-decided direct DDL before the frozen text, exactly as it does for 0006, and its convergence and re-open checks cover wisps.arrival_seq and uk_wisps_arrival_seq. Ported from gascity/bd-enterprise#204 (12f0a7360), renumbered from main 0070 / ignored 0028 to the next free upstream slots; the Postgres half of that commit stays downstream. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(journal): stamp arrival_seq at the journal's create seam BD-5, part 2 of 3: the writer. RecordEventInTx now decides, once, whether a create stamps: the op is a create, the row was read from wisps, and it carries no stamp yet. When it does, insertEventRow draws the seq, writes it onto the row (stampArrivalSeqInTx), and only then marshals the post-image, so the record's seq, the row's arrival_seq and the post-image agree. There is no second counter: the stamp IS the journal seq, so it inherits the counter's commit-ordered allocation on every engine, and a workspace that does not journal pays nothing and stamps nothing. - The stamp writes arrival_seq alone (updated_at self-assigned against Dolt's ON UPDATE CURRENT_TIMESTAMP), so row_lock, current_revision, updated_at and content_hash are untouched and a caller's post-create CAS still holds. It must match exactly one row. - A collision on the journal seq OR on uk_wisps_arrival_seq goes through the same single heal-and-retry; the retry moves a stamp the failed attempt already wrote. isSeqCollision also recognizes the embedded engine's unique-key error kind. - healEventSeqCounter raises the counter past MAX(arrival_seq) too, and falls back to the journal alone on a drifted clone with no wisps column. - PrepareIssueForInsert and the unit-of-work Insert clear ArrivalSeq, and the generic insert/upsert column lists never name it: no caller-supplied value is ever stored, and a plane move leaves the row unstamped. Guards: TestArrivalSeqIsWrittenOnlyByTheJournalSeam (AST scan of every SQL literal under internal/storage), TestIssueInsertAndUpsertColumnsExcludeArrivalSeq, TestOnlyRecordEventInTxRecordsCreates; the row_lock and version completeness guards learn the stamp is sink bookkeeping. Dolt-server and embedded tests pin commit order under overlapping and racing writers, uniqueness, the untouched-columns rule, both heal orders, the missing-column fallback, and that many NULLs coexist under the index. The 40-shard embedded storage manifest places the new embedded tests. Ported from gascity/bd-enterprise#204 (9ca7815c5); the Postgres refusal and its open-time reconcile stay downstream. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(httpapi): publish arrival_seq on the wire behind issues.arrivalSeq BD-5, part 3 of 3: the member on every Issue-shaped answer, the contract cases on every leg, and the interchange boundary. - types.Issue.ArrivalSeq is now `arrival_seq,omitempty`: absent on every unstamped row, so a reader that predates it sees what it saw before, and outside the content hash. `bd show`/`list`/`ready --json` carry it. - The spec adds an optional int64 arrival_seq to Issue, BatchGetIssue, IssueWithCounts, IssueDetails, IssueWithDependencyMetadata, TreeNode and BlockedIssue, documents the post-image carrying it on EventRecord.issue, and lists the new build-level behavior token issues.arrivalSeq. Whether rows are being stamped follows journal activation, which events.list's 409 already reports. apigen and the wire-shape golden are regenerated; the change is additive, so wire_revision is unchanged. The client mirrors the token (wire.CapArrivalSeq). - bd export and auto-export strip clone-local fields from every record (stripCloneLocalFields), held by an AST guard over every exportIssueRecord builder. - backend/conformance gains nine Journal-role cases (definition, batch order, every read path, immutability, journal-off, plane, create order recovered after the journal is pruned past it, no reuse across delete, supplied values ignored) with hooks bound to the public roles. They run on the dolt, embedded, unit-of-work and served-HTTP legs. The Importer role is optional (only the unit-of-work provider hands one out); the two store legs drive the import cases through CreateIssuesWithFullOptions, the seam `bd import` runs on them, and the served leg leaves the explicit-id batch, the claiming create and import to the store legs. - docs/reference/events-journal.md documents "Arrival order on the row". Ported from gascity/bd-enterprise#204 (cf9f1d431 and 7bb0899e3); the ImportIssue member, the HTTP importer's strip and the Postgres leg stay downstream, where the import operation and Postgres live. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(journal): make the arrival_seq heal tests discriminate Both heal tests wound the counter back to high-1. The first draw is then high, which is already the counter's own value, so a heal that consulted only the journal (GREATEST(next_seq, MAX(seq))) also lands on high+1 and the tests pass without the MAX(arrival_seq) term they exist to pin. Wind back three instead, with the journal empty: a journal-only heal leaves the counter in place and the retry collides with the next surviving stamp. Verified with a go test -overlay mutant that drops the arrival term from healEventSeqCounter: TestArrivalSeq_EmbeddedHealRaisesTheCounterPastTheStamps now fails with "duplicate unique key given: [2]" and passes on the real code. The domain/db twin takes the same change (Dolt-container tier). Ported from gascity/bd-enterprise#204 (8616c3cf4). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(conformance): pin that a synthetic create never moves an arrival stamp RecordEventInTx stamps only a wisp row that has no stamp yet (issue.ArrivalSeq == 0). That clause is what keeps the synthetic create records an import upsert and an id rename journal for an existing row from restamping it, and nothing tested it: an overlay mutant that drops the clause passed every embedded Journal, Import, Rename and Wisp test. Three Journal-role cases, declared before EveryMutationKindLandsARow and wired on every leg: - ArrivalReimportKeepsTheStamp: re-importing a stamped wisp leaves the stamp, journals a create with its own higher seq, and that record's post-image carries the original stamp. A real flow: bd export keeps no_history wisps. - ArrivalFirstCreateRecordStampsAnUnstampedRow: a wisp created with the journal off is stamped by the first create record journaled for it, with that record's seq. - ArrivalRenameKeepsTheStamp: the create a rename journals carries the row's stamp. Driven through a new optional JournalArrivalHooks.Rename, bound by conformance.ArrivalRenameHook on the dolt and embedded legs (the stores that expose UpdateIssueID); the served and unit-of-work legs skip it by name. The import cases run on the dolt and embedded legs through their bulk upsert (ArrivalUpsertImportHook) and on the unit-of-work leg through its Importer; the served leg skips them by name, since the wire publishes no import. Ported from gascity/bd-enterprise#204 (1efd4d571). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(journal): isolate the domain/db arrival_seq tests from suite order - TestArrivalSeq_HealFallsBackWithoutTheWispColumn drops wisps.arrival_seq on the suite-shared database and restored it with `_, _ =`. wisps is dolt_ignored, so SetupTest's DOLT_RESET never repairs it, and a failed restore would surface as unrelated failures later. The cleanup now reports each failure against this test. - TestArrivalSeq_JournalCollisionMovesTheStamp required its counter reset to clear every surviving stamp, which held only because no earlier test left a stamp above the counter. It now lifts the counter past MAX(arrival_seq) before seeding, so its records sit above every surviving stamp by construction; the Require stays as a setup check. Ported from gascity/bd-enterprise#204 (7962a4598). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(journal): budget the embedded concurrent-writer race by the test deadline TestArrivalSeq_EmbeddedConcurrentWritersAreUnique gave each of its 12 creates a fixed 60s context, but the engine serializes them, so the last one waits on all the others: the farm's -race build took about 30s, a 2x margin. The writers now share one context bounded by the test binary's deadline less 30s of grace to report a failure in, and by nothing else when no deadline is set. Ported from gascity/bd-enterprise#204 (b2b158a18). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(journal): state arrival_seq's commit-order guarantee precisely The "Commit order" guarantee was stated unconditionally, but the documented first-record rule breaks it: a row created with the journal off and later renamed or re-imported takes a stamp above rows created after it. And "no stamp and no cost" with the journal off overstated it, since uk_wisps_arrival_seq is maintained on every wisp insert and delete regardless, NULL entries included. The guarantee now reads "ordered by the commit of the create record that stamped the row" and says when that record is not the insert; "no cost" becomes "no extra statement", naming the index. The types.Issue doc and the CHANGELOG entry carry the same caveat (the spec's Issue.arrival_seq description already does). Ported from gascity/bd-enterprise#204 (c15da9a09). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(journal): hand the arrival_seq stamp back onto the caller's created issue The storage create APIs write the stored row back onto the issue they are given: CreateIssue, CreateIssues and Transaction.CreateIssue on every store (the calls the public beads.Storage exposes, and the ones gascity's native store maps its create result from), and the unit-of-work repository's Insert. PrepareIssueForInsert and Insert zero ArrivalSeq on the way in so a supplied value is never stored, but nothing put the stamp back: the row carried arrival_seq 1..N while the caller's struct still said 0, so a consumer that keeps its create result reads every stamped wisp as unstamped until it reads the row again. Only the public Lifecycle roles, which re-read the row, returned it. RecordCreateEventInTx journals the create exactly as RecordEventInTx does (both share recordIssueEventInTx, which still makes the one stamp decision) and copies the journaled snapshot's arrival_seq onto the issue. Both create seams use it: issueops.finishCreateIssueInTx, which every store's create and import funnels through, and domain/db Insert. With the journal off nothing is recorded and the field stays zero, as on the row. Red before the fix: TestArrivalSeq_EmbeddedCreateLeavesTheStampOnTheCallersIssue (the caller's issue carried 0 against rows 1..4) and, on a Dolt sql-server, TestDomainDB/TestArrivalSeq_InsertLeavesTheStampOnTheCallersIssue (0 against 17 and 18). The structural guards follow the move: the stamping insertEventRow call now lives in recordIssueEventInTx, and the unit-of-work journal-completeness guard counts RecordCreateEventInTx as an emitter. The embedded storage shard manifest places the new test. Ported from gascity/bd-enterprise#204 (3d12c16dd). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(schema): ignored/0029 raises the seq counter past every surviving stamp When bd_events_seq goes missing, the ignored series' cursor floor replays it from ignored/0022 (replayFloor 21), which re-creates the counter and seeds it from the journal's MAX(seq) alone. With the journal pruned past every record that seed is 0 while stamps survive on wisps, and the values swept or deleted wisps held are free: the next create takes one without touching the unique index, so the writer's collision heal never fires and the new row sorts before older surviving rows. ignored/0029 re-runs in that same replay, after 0022, so its third step now raises bd_events_seq past MAX(wisps.arrival_seq) (GREATEST, guarded on the counter table and the stamp column existing). It changes nothing on an in-place upgrade (every stamp NULL), on a fresh clone, or on a healthy re-run. TestArrivalSeq_EmbeddedReplayedCounterSeedClearsTheStamps drives the path end to end on the embedded engine: three stamped wisps, the two oldest deleted, the journal emptied, the counter table dropped, MigrateUp, then a new wisp must stamp above the survivor. Without the step the replay re-seeds at 0 and the test fails on the counter check. TestIgnoredMigration0029RaisesTheSeqCounterPastTheStamps pins the statement, its place after the column and index, and that bd_events_seq's replay floor still sits below 0022. Follow-up from the gascity/bd-enterprise#204 review (finding 4). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(cmd/bd): pin arrival_seq on bd create/show/list/ready/query --json The storage contract cases prove the stamp on every backend, but a consumer that shells out to bd reads the CLI's own rendering, which marshals types.Issue, IssueWithCounts or IssueDetails per command; a command that moved to a projection of its own would drop the member without any storage test noticing. TestEmbeddedArrivalSeqOnEveryJSONRead creates an ephemeral wisp, a no_history wisp and a durable bead with the journal on, and checks that bd create --json, bd show, bd list --include-ephemeral, bd ready --include-ephemeral and bd query --json carry each wisp's stamp equal to the seq of its create record in bd events export, that the durable bead carries no member, and that bd export never writes one. The 100-shard embedded cmd manifest places it. Follow-up from the gascity/bd-enterprise#204 review (finding 5). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(historyoffequiv): set arrival_seq aside in the history-off differential TestVersionedHistoryOffMatchesPreStackGolden (embedded, server and unit-of-work legs) failed on issues.arrival_seq, wisps.arrival_seq and the two new bookkeeping rows: migration 0073 and ignored/0029 add schema the goldens predate. Flag-off storage leaves it untouched (issues never carries a stamp, and wisps carries one only while the workspace journals, which the scenario does not), so it takes its own schemaAdditions entry, as the versioned-history stack's columns did, and the goldens stay as recorded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): refuse a behind schema reads cannot query; 0073 rebuilds its index Maintainer fixup for review iteration 1 of gastownhall#7912. Every issue read now selects arrival_seq, and a server-mode read-only open neither migrates nor checks a behind schema, so after an upgrade every list, show and ready on a v72 database failed on the unknown column. An open that does not migrate now refuses such a database at open with SchemaBehindError (schema.CheckReadableDrift). It does so only when the database lacks a column the shared issue projection selects; a behind database that still has every column keeps serving reads (bd-578h9.5, gastownhall#5920). The open reads the version once, as the forward-drift check it replaces did, and lists the issues columns (SHOW COLUMNS) only when the database is behind. Three paths do not migrate: - server mode: dolt.Config.RequireReadableSchema. The root pre-run sets it for every open except a preview, and so do the routed and foreign read factories (cgo and nocgo). Through a gateway the refusal names the server administrator's remedy; - proxied mode: the read-through after a refused migration; - embedded: a read-only command's open after a tolerated gate or dirty-table refusal. 0073's down drops wisps.arrival_seq and uk_wisps_arrival_seq with it, but leaves ignored/0029 recorded, so a re-applied 0073 restored the column without the index. 0073's up now creates the index as well, under 0029's guard, and its CLI bundle substitute does the same. Docs: a CHANGELOG upgrade note. "Never reused" is narrowed to values the counter, the journal or a surviving row still holds. A bead moved onto the wisp plane is documented as carrying no stamp. The 1054 and Kind.Is comments are corrected. Tests: - CheckReadableDrift unit cases; - a server-tier open matrix (behind with every column, a missing column, the gateway remedy, the escape hatch); - a 0073 rollback and re-apply through the real migration pass; - a bd list/show/ready e2e on a v72 database, converging with bd migrate schema; - proxied and embedded read-through refusals. Each test fails against its mutant. The proxied shard manifest (.github/scripts/proxied-cmd-test-shards.txt) places the new TestServerMode* test on shard 16 (gen_proxied_shard_manifest.py 34 --weights=duration --write). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…63) (gastownhall#7908) * test(dolt): pin that no-git-ops with auto-push unset never pushes (GH#3463) Add a mutation-resistant regression pin for the GH#3463 contract: with no-git-ops: true and no explicit dolt.auto-push opt-in, maybeAutoPush must never touch the remote or write push-state.json. The pin installs a fake store whose HasRemote always reports an origin remote, so restoring the pre-gastownhall#3446 push-whenever-origin-exists auto-detect fails this test instead of passing vacuously. AC: AC-1 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 9f667a7) Ported-From: glm/9f667a71763d671f0f03f4cf568c4beafd867388 AC: AC-1 * test(dolt): pin that no-git-ops does not override an explicit auto-push opt-in GH#3463: a workspace with no-git-ops: true and an explicit dolt.auto-push: true opt-in still pushes exactly once, and the debounce window holds for an immediate second tick. This subtest is also the control showing the fake store is the one maybeAutoPush reaches: with the opt-in the harness observes a real Push call. AC: AC-2 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 256a313) Ported-From: glm/256a313d5a04a3253cdca7a496acd407f2014244 AC: AC-2 * test(dolt): pin that dolt.local-only suppresses auto-push when opted in GH#3463: with no-git-ops, an explicit dolt.auto-push opt-in AND dolt.local-only: true all set, maybeAutoPush must never push. This pins the isDoltLocalOnly gate in the auto-push path, which no current test reaches — TestMaybeAutoPush_SkipsWhenLocalOnly uses a nil store and only asserts that the call does not panic. AC: AC-3 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 7c367c8) Ported-From: glm/7c367c80c772a67da04033a1f6c6b99353a30941 AC: AC-3 * docs(config): state no-git-ops scope; document dolt.local-only (GH#3463) GH#3463 was reported against a pre-v1.0.3 bd where auto-push auto-enabled whenever a Dolt origin remote existed and --stealth wired that origin, so every write stalled ~2 minutes on a failed push. At current bd both are fixed (auto-push is explicit opt-in since gastownhall#3446; stealth init no longer derives a remote since gastownhall#3909), but the docs still let users believe no-git-ops stops Dolt pushes. Say in the settings table and in the Auto-push section that no-git-ops only covers bd's own git activity and that dolt.local-only is the switch that governs Dolt networking, add the missing dolt.local-only row (previously documented only in the CLI reference), and stop the README from claiming --stealth disables all git operations. AC: AC-5 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 178d044) Ported-From: glm/178d0444f94e76cb936f2cf5de86d4c9aa1d065c AC: AC-5 * docs(config): word dolt.local-only's sync effect so the doc-flags gate passes (GH#3463) The dolt.local-only row said the setting makes `bd dolt push`/`pull` and `bd sync` "no-ops". Check 1 of scripts/check-doc-flags.sh fails any docs line that names `bd sync` next to "no-op", "removed" or "deprecated", because that is how stale docs described the JSONL-era command, so the PR's Check doc flags freshness job went red on this row. Say what the commands do under the setting instead: they report that remote sync is disabled and return without contacting a remote (cmd/bd/dolt.go push/pull, cmd/bd/sync.go). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…gastownhall#7904) * fix(dolt): describe OS-assigned port in bd dolt start help (GH#5969) Hash-derived per-project ports were removed in v0.60.0 (GH#2415), but the start help still said the port is derived from the project path. Describe the OS-assigned port recorded in .beads/dolt-server.port and that 'bd dolt stop' removes it. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 1c86cbf) Ported-From: opus/1c86cbf7fc9a417999ab99e0215f6e16f5a31652 AC: AC-1 * fix(dolt): name dolt.port as the stable-port pin in bd dolt start help Point users who need one port across restarts at dolt.port in .beads/config.yaml or .beads/config.local.yaml, and at 'bd dolt show' for the port-source order. BEADS_DOLT_SERVER_PORT and 'bd dolt set port' stay out: both mark the server externally managed. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fbc299a) Ported-From: opus/fbc299ac3ea223da6758aaf4eb40ceeda0962593 AC: AC-2 * test(bd): pin the reworded dolt start help in the command-tree golden Regenerated by hand (BD_UPDATE_GOLDEN is not runnable on this seat); TestCommandTreeGolden confirms the block matches. Only the 'bd dolt start' long block changes: two lines out, seven in. AC: AC-3 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Code <noreply@anthropic.com> (cherry picked from commit 1c4db68) Ported-From: glm/1c4db68426e561f9d0c39e9564979b29b841f166 AC: AC-3 --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
…arent (gastownhall#7911) * fix(list): wait a full poll interval after each bd list --watch refresh The --watch loop used a fixed-rate time.Ticker, so a refresh that took longer than the 2s interval was followed by the next one at once and a large watched tree kept the embedded store busy almost continuously (GH#3415). The loop is now listWatchLoop, which asks for its wait only after the previous refresh (and redraw) returned. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 24e11fb) Ported-From: opus/24e11fb0a962cf975d5399d28419a6e5e2118f35 AC: AC-3 * fix(show): wait a full poll interval after each bd show --watch fetch watchIssueLoop took a ticker channel, so a fetch slower than the 2s interval was followed by the next one at once (GH#3415). It now takes a poll function it calls each time it starts waiting, after the previous fetch and redraw returned; runIssueWatch passes time.After, for both the direct and the proxied-server route. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 04127bd) Ported-From: opus/04127bdbec745c471d602a81c96dac0c01a50780 AC: AC-4 * fix(list): walk the --parent tree through an optional store capability findAllDescendants issued one SearchIssues per tree node, and on the embedded backend each is its own engine open, so a large watched --parent tree held the store busy for most of every refresh (GH#3415). storage.SearchDescendants now runs the walk through the innermost store's DescendantSearcher when it has one, and node by node through SearchIssues otherwise (the http client store). storage.WalkDescendants is the walk both share. AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 90fab57) Ported-From: opus/90fab572c6b779d927ef72665b949124b3488d64 AC: AC-5 * fix(storage): walk the --parent tree in one read transaction on Dolt stores The embedded and Dolt server stores implement storage.DescendantSearcher through issueops.SearchDescendantsInTx, so a bd list --parent tree (and each bd list --watch --parent refresh) is one connection instead of one per tree node (gastownhall#3415). A conformance group pins that both answer what the per-node SearchIssues(ParentID=...) walk answers. AC: AC-6 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 90af84c) Ported-From: opus/90af84cacae1996d8b554c268e8c8971186235c2 AC: AC-6 * test(list): pin the --pretty --parent tree around a closed mid-level child The one-shot tree now comes from storage.SearchDescendants: with --all it shows the epic and every descendant, and without it the closed child and the subtree reachable only through it are left out while everything outside that subtree still shows (gastownhall#3415). AC: AC-7 Derived-From: opus/2da40b04f1ac195358c2746e6b354e4fb4081b00, glm/f62fec47d443410004440d33f9871837ee94281b Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(list): pin bd list and bd show alongside an embedded bd list --watch With the watcher up past a poll interval, bd list --json and bd show --json in the same embedded workspace each exit 0 within 30s and return the seeded issue (gastownhall#3415). Runs as a subtest of TestEmbeddedListConcurrent. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f4a0176) Ported-From: opus/f4a017687cd2fa0ea46cdda6679cc78f1a98f0b3 * test(list): pin bd commands alongside an embedded bd list --watch --parent With the watcher up on a 44-descendant, three-level epic, bd show, bd list and bd update each exit 0 within 30s and the watcher shows the new title within 10s (gastownhall#3415). Adds the CHANGELOG entry for the watch fixes. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0aab77f) Ported-From: opus/0aab77f6f96f31c6c4c3e4e697fc9b3fb5449cd6 * fix(list): pace proxied bd list --watch; trace the --parent walk Review fixes for gastownhall#7911: - Proxied `bd list --watch` still refreshed on a fixed-rate 2s ticker, so on the default managed-local transport a refresh of 2s or more was followed by the next one at once. runListProxiedWatch now drives listWatchLoop through proxiedListWatchLoop, which hands each redraw the dependency records its own refresh read. Paced-poll tests pin the cadence, a refresh that outlasts the interval, a stop that arrives during a refresh, and the records the redraw draws. - RunAll/SearchDescendants failed every backend without the optional storage.DescendantSearcher capability. It now walks through storage.SearchDescendants: a store with the capability is held to the per-node answer through it, and one without through the node-by-node fallback bd walks it with. - storage.SearchDescendants offers the walk to each decorator before unwrapping it, and telemetry.InstrumentedStorage implements it, so a --parent walk keeps a storage.SearchDescendants span when telemetry is on instead of losing every span to the unwrap. - Comments that said findAllDescendants re-points the filter per level now name storage.WalkDescendants, where that moved. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…t push, bd sync and auto-push (gastownhall#7910) * fix(dolt): explain the remote dangling-reference refusal on bd dolt push When Dolt refuses a push because the remote reports a chunk as missing ("Found dangling references", GH#3358), bd dolt push printed only the raw error. It now explains that the remote branch did not move, how to tell a transient race from a damaged remote, and how to recover, with a matching section in docs/recovery/sync-failures.md. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 702b260) Ported-From: opus/702b260daa2af94c6233a53d04dc3c569255ea70 AC: AC-1 * fix(dolt): explain the remote dangling-reference refusal on bd dolt push --remote The named-remote path now prints the same guidance after the "Found dangling references" refusal as the default path (GH#3358). AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit caade15) Ported-From: opus/caade1572e950fcb1ecf1d6caab525f1ca9df899 AC: AC-2 * fix(dberrors): classify Dolt's remote dangling-reference push refusal Adds IsRemoteDanglingReference, a lowercased message match for Dolt's "unknown push error; Found dangling references to HashSet {…}" so the push commands can explain it in every tier (GH#3358). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 1b75312) Ported-From: opus/1b75312de2d6ee84c930ad287e5bf2bc1930434a AC: AC-3 * fix(dberrors): keep local dangling-reference failures out of the remote classifier bd's pre-push fsck ("dangling chunk reference") and Dolt's local NBS "dangling ref:" form are not evidence about the remote, so IsRemoteDanglingReference rejects them (GH#3358). AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 3dc5d38) Ported-From: opus/3dc5d380d6b64e5f92690ef1a66b2d7b325ee305 AC: AC-4 * test(dolt): pin bd dolt push output for failures that are not the remote refusal bd's pre-push fsck, diverged history and the different-primary-keys refusal keep their Error: line and existing guidance, without the remote dangling-reference guidance (GH#3358). AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 58a0998) Ported-From: opus/58a0998a9f17d495f9066b0d52e7b09b126d10be AC: AC-5 * fix(dolt): explain the remote dangling-reference refusal on bd sync and auto-push bd sync and dolt auto-push push too, and already print the push verbs' diverged-history and primary-key guidance, but on Dolt's remote "Found dangling references" refusal they still stopped at the bare error. printSyncErrorGuidance and the auto-push failure block now print the same guidance as bd dolt push, pinned with fake-store cases; bd's pre-push fsck abort keeps its bare line on both paths. The fake-store tests in cmd/bd/dolt_push_dangling_test.go build only with cgo: they pin embedded-mode output, which a CGO_ENABLED=0 bd cannot produce, and share remedy_printing_test.go's cgo-only terminal-control check. The guidance and the playbook now share one rule: compare the hash with this clone's HEAD commit and root hashes (dolt_hashof('HEAD'), dolt_hashof_db('HEAD')), re-run the push, and seed a fresh remote only when the same hash comes back and matches neither. Before, the CLI text and the playbook's step 2 reseeded on any repeated hash, including a HEAD hash the playbook's own test calls a transient race. bd prints the two HEAD values itself, read right after the failure through storage.HeadHasher, which both Dolt stores now implement with versioncontrolops.HeadHashes. The only other way to read them is bd sql, which does not run in embedded mode, bd's default, so the guidance used to hand embedded users a probe that exits 1. The bd sql query now appears only when bd cannot read HEAD in server mode. The storage read ships in this PR because the guidance cannot work in embedded mode without it; an embedded-store test pins that it returns HEAD's commit and the root of that commit, and that neither moves with the working set. The seeding commands re-point the remote that failed: origin's recipe for the default remote and auto-push, and the named remote's own, quoted with remedy.CommandArg, for bd dolt push --remote and bd sync --remote, instead of origin commands that would rewrite sync.remote and leave the damaged remote alone. In server mode bd sends Hosted Dolt credentials only to origin, so the playbook seeds a Hosted Dolt database for another remote through origin and then restores origin. The playbook also names the bd sync and auto-push renderings, says the check asks the remote instead of pointing at the pre-push check (which runs only on the CLI route), and asks for bd version in a Dolt report (embedded mode runs the Dolt built into bd). CHANGELOG gains the Fixed bullet (GH#3358). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ent's stale bit (gastownhall#7924) * fix(storage): stop a closed or pinned parent's stale is_blocked darkening its children The parent-child legs of the should-be-blocked union cascaded on the parent's stored is_blocked with no status test. A closed or pinned row is never blocked, but BlockedStateInvariant's merge clause admits a stale 1 on it, so the next write under such a parent marked its open children blocked and hid them from bd ready (gastownhall#7626). Guard both legs with the status test legs 1-2 already apply to their targets. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 1a70ce1) Ported-From: opus/1a70ce11cd5888fbd1fabdba02f91767d5445612 AC: AC-1 Derived-From: opus/1a70ce11cd58, pr7627/1a67ce0fda99 Co-authored-by: a3ackerman <28374790+A3Ackerman@users.noreply.github.com> * test(storage): pin the doctor count and full repair over a stale closed or pinned parent With the parent-child legs guarded on status, the Blocked State count over a closed or pinned parent with a stale is_blocked = 1 names only that parent, and the full repair corrects only that row. On the base the count was 1+N and the repair 1+2N, marking the children in one pass and unmarking them in the next (gastownhall#7626). AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 06d4b54) Ported-From: opus/06d4b546a8f96536be38ceeb2f678577da25d52b AC: AC-2 * fix(storage): stop the close-gate walk reading a closed or pinned parent's stale bit blockedParentEdgesInTx met a closed or pinned parent with a stale is_blocked = 1 and a reason row of its own as blocked and not explained, so it dropped the close gate below it from the explained set and the gate's children stayed dark. Guard the walk with the same status test as the parent-child legs (gastownhall#7626). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 80bfeb0) Ported-From: opus/80bfeb08192d6936194038e1e6a12a3ebec64925 AC: AC-3 Derived-From: opus/80bfeb08192d, pr7627/1a67ce0fda99 Co-authored-by: a3ackerman <28374790+A3Ackerman@users.noreply.github.com> * test(storage): re-record the settled golden for the closed-parent guard and note the remedy The parent-child legs' new status guard turns createbatchequiv's settled step I/J cycle bright. The old legs read the just-closed eq-zI-a's pre-pass flag, which kept its child eq-zI-b dark and held the stale cross-plane cycle at 1; now eq-zI-b and the wisp eq-zI-c read 0 after steps I and J. That is BlockedStateInvariant's answer, so re-record settled.json (the issues, wisps and bd_events_journal digests and the I/J lines, measured identically on the Dolt server and the embedded engine) and document it as the fourth deliberate behavior change in the GoldenDirEnv doc. Steps I and J no longer pin when the settled-row shortcut clears the row. Say so in their doc, and in runRecomputePassInTx's, which names the one case the order still shows through: an edgeless settled row that is neither closed nor pinned, carries a stale 1 and has a child in the same chunk. Add the CHANGELOG entry for gastownhall#7626, with the one-time `bd recompute-blocked` (or `bd doctor --fix`) remedy for children a closed or pinned parent already darkened. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: a3ackerman <28374790+A3Ackerman@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…states (gastownhall#7776) * fix(issueops): treat a missing wisp_dependencies as empty in the dependents listing bd show <epic> rendered no CHILDREN section and no k/N rollup when the dolt-ignored wisp_dependencies table had been dropped from a server-mode working set: GetDependentsWithMetadataInTx returned the table-not-found error and show.go treats the read as best effort. Read both planes through one edge reader that skips only the named missing wisp table (gastownhall#3445). AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 3127220) Ported-From: opus/3127220addaea911e06ab1abf519dc8905979b88 AC: AC-1 * fix(issueops): return a cross-table duplicate dependent edge once An edge stored in both dependencies and wisp_dependencies was listed twice, so bd show <epic> printed 2N children and a 2k/2N rollup. The edge reader now keys on the far-end id, durable row first, so each child appears once carrying the durable type (gastownhall#3445). AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 4374415) Ported-From: opus/437441530376323e8f24694379bb59d1d0fa1ac9 AC: AC-2 * fix(issueops): read every both-plane dependency listing through one edge reader GetDependenciesWithMetadataInTx, GetDependentsInTx and GetDependenciesInTx had the same loop as the dependents listing: a missing wisp_dependencies failed the read and a cross-table duplicate edge was returned twice. They now share anchorEdgesInTx, so each returns one entry per distinct far end (gastownhall#3445). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit da2ed53) Ported-From: opus/da2ed531483b6950237d301f11670d4f4ad6ddf6 AC: AC-3 * fix(storage): count each distinct dependency edge once across both planes CountDependents/CountDependencies on the Dolt-server and embedded stores summed raw rows from dependencies and wisp_dependencies, so an edge held in both planes counted twice and a missing wisp_dependencies failed the count. They now delegate to issueops.CountDependencyEdgesInTx, which counts the durable rows plus the wisp rows whose far end the durable plane does not already hold for the same anchor, and treats a missing wisp_dependencies as an empty plane. The type filter applies to the outer query only. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3d18c36) Ported-From: opus/3d18c36f0045aca993d4612c4606ee6fb0a9a6ac AC: AC-4 * fix(dolt): stream durable dependents when the wisp plane is missing IterDependentsWithMetadata UNION ALLs the durable and wisp legs, so a server database without wisps or wisp_dependencies failed `bd show --json --include-dependents`. When the union fails on one of those optional tables, re-run the durable leg alone with the same columns, lease join and ordering. Any other missing table stays an error. AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 448622e) Ported-From: opus/448622e6384b29453c6242ccf96e27b95a646b4e AC: AC-5 * test(storage): pin that only a missing wisp plane is tolerated The dependency readers and CountDependencyEdgesInTx skip a missing wisp_dependencies and nothing else. Pin that a missing dependencies, leases or wisp_labels table, a missing dependencies reported from the wisp count's NOT IN subquery, and a broken connection are returned as the primed driver error (errors.Is). Hold the server iterator's durable fallback to the two optional wisp tables: with no leases table, IterDependentsWithMetadata errors instead of answering from the durable leg. Also pin in TestDependencyCycleNodes that a repeated successor (A->B twice, B->C) is a path, not a cycle. AC: AC-6 Derived-From: opus/67deb91b73c8009d0fd85ffe1ba5e15b9aa25984, glm/7f6d4e14fda02caa9b41efd3da82aceda2e808ff, glm/4065613bbd8939af30c52e4b5cb86ba53846c3d2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(dolt): stream a dependent held in both planes once, from its wisps row Review fixes for gastownhall#7776 (bd-cif6y4), iterations 1 and 2. The server's IterDependentsWithMetadata UNION ALLs the durable leg (issues x dependencies) with the wisp leg (wisps x wisp_dependencies). A dependent with a row in both issues and wisps and its edge in both tables (another clone's promotion pulled next to the local wisp copy) matched both legs, so `bd show --json --include-dependents` streamed it twice: N+1 dependents beside dependent_count N, an inflated epic rollup, and unresolvable_dependents masked. The slice path GetDependentsWithMetadata, behind text `bd show` CHILDREN and its k/N line and behind the embedded and proxied streams, lists that dependent once, with the durable edge's type and its wisps row: the wisp copy is canonical (be-iabdi), as search, ready, `bd epic` and doctor's cross-table fix also hold. The stream now probes for a durable edge whose dependent holds a wisps row and, on a hit, streams that slice, so the JSON dependents and epic rollup read the rows text `bd show` reads. bd doctor reports the state as an error, so a healthy database pays only for the probe query; a missing wisps table holds no such dependent. Without a hit no dependent is in both legs, so the union is main's again. Iteration 1's anti-join, which kept the issues row and read the epic as 1/N beside the listing's 0/N, is gone. TestDependentsAcrossWispPlaneStates gains a dual_resident state: every child also holds an older, open wisps row and its edge is mirrored. Each state now pins how many children every reader sees closed (0 for dual_resident) and that the stream carries the listing's id, type and status for every child. Without the probe the stream returns 6 rows for 3 children; with iteration 1's anti-join child-1 streams closed while the listing reads it open. The embedded twin closes its first child and gains the same state and assertions. Also: - list TestDependentsAcrossWispPlaneStates in the embedded storage 40-shard manifest (gen_embedded_storage_shard_manifest.py 40 --weights=duration --write), which //scripts:go_test_sources_test requires; - the CountDependentsByStatus docs state the depTargetExpr constraint instead of pointing at a CountDependents rationale this PR removed; - TestIterDependentsMissingLeasesStillErrors' comment says what it pins; - the AnchorEdgeCount.Count contract no longer names CountDependencyEdgesInTx as the two-plane sum: it names the counters that still sum (this role, CountDependentsByStatus, the `bd list` and `bd search` dependent_count) and the ones that count each distinct far end once. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…w-up + Oct-27 advisories) (gastownhall#7925) * fix(security): pass-3 dependency and toolchain updates (eMudhra follow-up + Oct-27 advisories) - github.com/go-jose/go-jose/v4 v4.1.4 -> v4.1.6 and golang.org/x/net v0.60.0 -> v0.62.0 (Oct-27 advisories) in the root module and both example modules. MVS also raises x/crypto 0.58.0, x/text 0.43.0, x/tools 0.51.0 and x/telemetry; tools/nogo moves to x/tools 0.51.0 so the analyzers keep linking the same x/tools as the go.work graph (the ctrlflow noreturn patch applies unchanged). - beads-mcp uv.lock: authlib 1.7.2 -> 1.9.1, dnspython 2.8.0 -> 2.9.0 for Python >= 3.11 (2.9.0 dropped 3.10; 3.10 stays on 2.8.0). - setup-python '3.14' -> '3.14.10' and uv 0.13.5 -> 0.13.6 (first uv with the patched CPython builds) in release.yml, bazel.yml, test-pypi.yml. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(nix): update vendorHash for go.sum changes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(nogo): align tools/nogo x/text (and x/sync) with the root module TestModuleRequirementsAgreeWithRoot requires tools/nogo's shared requirements to match the root go.mod after the x/net 0.62.0 bump. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
) * fix(mcp): apply update fields when status=open does not reopen beads_update_issue routed every status="open" call to bd reopen, dropping title, description, priority and the rest. When bd reopen reopens nothing (the issue is not closed), fall through to bd update with every field (GH#6872). AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f6fcade) Ported-From: opus/f6fcade55af3fa3b04baa608cfccdfac2d641e77 AC: AC-1 * test(mcp): cover status=open update on a deferred issue AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit c80adc9) Ported-From: opus/c80adc9575a1778e18b972b3f88869bc9a100993 AC: AC-2 * fix(mcp): apply other update fields after status=open reopens When bd reopen does reopen the issue, apply title, description, priority and the other fields of the same update call with a follow-up bd update instead of dropping them; notes stays the reopen reason (GH#6872). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 5c240fa) Ported-From: opus/5c240fae834f81b0186d64169384c1b2162a32dd AC: AC-3 * fix(mcp): parse bd reopen no-op (empty stdout) as an empty result bd reopen reports no-ops (already open, or status outside the done category) on stderr only and prints nothing on stdout with exit 0 (RULING R4 in cmd/bd/reopen.go). _run_command maps empty stdout to {}, which BdCliClient.reopen then rejected as "Invalid response for reopen", so the MCP reopen tool failed on any issue that was not closed. Map {} to [] before the list check; non-list output still raises. GH#6872 AC: AC-4 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Code <noreply@anthropic.com> (cherry picked from commit fa76617) Ported-From: glm/fa76617fcb68ac54f0c0180be206fb37301d4244 AC: AC-4 * fix(mcp): report reopen of an issue that is not closed beads_reopen_issue now raises a BdError naming the ids that are not closed when bd reopen reopened nothing, instead of returning an empty result (previously "Invalid response for reopen"). Document the update/reopen behaviour change in the CHANGELOG (GH#6872). AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 27f9a8d) Ported-From: opus/27f9a8d6d9df4e5eeae17c22e6d113400c0f2194 AC: AC-5 * fix(mcp): return one issue from update(status="open") and clear a dated defer Review fixes for GH#6872 (PR gastownhall#7927): - update(status="open") on a closed issue returned a list while the same call on an issue that was not closed returned one object. It now returns the one reopened or updated issue on both paths, so the MCP tool answers with one OperationResult (or one Issue with brief=False) either way. - On an issue that is not closed the plain update also sends `--defer ""`, as bd reopen clears defer_until, so an issue deferred with `bd defer --until <future>` comes back to ready instead of staying hidden with status=open. UpdateIssueParams gains defer_until for it. - When the update after a successful reopen fails, the error now says the issue was already reopened, names the fields that were not applied, and says to retry without notes; it chains the bd error. - The closed path derives its follow-up update from the one UpdateIssueParams instead of hand-copied field lists, and skips empty strings as BdCliClient.update does. Tests pin every field (priority=0 included), the empty-string skip, the failure message, both brief modes and a real dated defer. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#7508) (gastownhall#7928) * fix(create): read depends-on:/blocked-by: in a --file batch as blocking edges (gastownhall#7508) A ### Deps entry spelled depends-on:<id> or blocked-by:<id> was stored with the alias as its literal type, which never gates bd ready. Map the aliases to blocks with the canonicalDependencyType helper --deps uses. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 5d07d3d) Ported-From: opus/5d07d3d80afa981762db0241f338d437fc63b4ac AC: AC-1 * fix(create): make blocks:<id> in a --file batch reverse direction like --deps (gastownhall#7508) bd create --deps blocks:<id> makes <id> depend on the new issue; the same ### Deps entry wrote the opposite edge. Set CreateDependency.Reverse for an explicit blocks: prefix, as createDependencyRequests does for --deps. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 5762fb4) Ported-From: opus/5762fb499f431e8e3723c3947a2eabd2f1a08442 AC: AC-2 * fix(create): refuse a --file dependency type that --deps refuses (gastownhall#7508) The ### Deps section only checked that a type was non-empty and short, so a misspelling (blokcs:) or a custom type landed as a non-gating edge. Validate with validateDependencyType, as --deps and bd dep add do, and name the template; an empty target (depends-on: <id>, split on the space) is refused with the template named too. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e41ce2a) Ported-From: opus/e41ce2a37cb4d3baa7e9bc703336e252f3ccae31 AC: AC-3 * fix(create): read a --file batch's ### Deps with the --deps grammar (gastownhall#7508) Once the aliases mean blocks, depends-on:<id>, blocked-by:<id> and a bare <id> are one edge spelled three ways, and the create role refused the three identical edges as duplicates. Route the section through parseDepSpecs and createDependencyRequests, the helpers --deps uses, so the alias mapping, the blocks: reversal, the well-known type check and the GH#4626 dedupe stay in lockstep with --deps instead of in a second copy. Document the shared grammar and note the change in CHANGELOG. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit af07b76) Ported-From: opus/af07b76a35c79f525db1fa2c7d8bb1e68f0c1769 AC: AC-4 --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
…(BD-6) (gastownhall#7931) * refactor(dolt): drop the dead per-table id generator generateIssueIDInTable in internal/storage/dolt had no caller left: every id the dolt store mints goes through issueops.GenerateIssueIDInTable. The duplicate checked only its own table, so a future caller would have minted ids the shared generator refuses (for example, an id a retaining sweep is about to retire). Remove it with the helpers only it used (nextCounterIDTx, seedCounterFromExistingIssuesTx, isCounterModeTx, generateHashID, getAdaptiveIDLengthFromTable) and the two unit tests of the last one; issueops carries the live copies of each. Ported from gascity/bd-enterprise#210 (818610dc1). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(schema): id tombstone tables for retaining sweeps (main 0074, ignored 0030) Add the two tables a retaining retention sweep writes and every create path will read (BDP idempotency-expired): id_tombstones, versioned like issues, and wisp_id_tombstones, clone-local like wisps (the existing wisp_% dolt_ignore pattern covers it). Each row is the compact (id, closed_at) pair, keyed on id, nothing else from the swept row. - Main 0074 creates both, guarded and idempotent; ignored 0030 materializes the clone-local one on fresh clones in the identical shape. The slots are the next free ones, directly above arrival_seq's (gastownhall#7912: 0073, ignored 0029). 0073's latest-version pin moves here. - wisp_id_tombstones is a sentinel floored table (floor 29): a clone that lost it re-creates it on the next write-intent open instead of failing every create closed. Re-created EMPTY, the wisps-plane tombstones are gone while the wisps rows may survive, so migrate now prints a loud, unconditional notice for a lost sentinel table that carries one (cursor above its floor) — the only signal a consumer gets that the clone is a new logical scope for wisps-plane idempotency keys. - bd doctor requires id_tombstones and treats wisp_id_tombstones as clone-local; the Dolt schema-parity test pins the pair to one shape. - The history-off differential (historyoffequiv) sets both tables and their bookkeeping rows (74, ignored 30) aside: flag-off storage leaves them empty. - Three of BD-5's tests assume 0073 is the latest migration and follow the slot: the 0073 rollback test rolls back what sits above 0073 first, as an operator must (a row 74 left behind would hold the cursor past 73); the server-mode read refusal rebuilds the v72 shape without 0074 too, so the refusal names v74; and the embedded lenient-gate test regresses the cursor below 0073 rather than one migration back, so the pending 0073 still meets the dirty-table guard. Ported from gascity/bd-enterprise#210 (b60aa6a42). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(storage): retaining sweeps retire ids; every create door refuses a retired id A retention sweep can now ask to retain ids (SweepRequest.RetainIDs): in the same transaction that deletes the closed rows it writes one permanent (id, closed_at) tombstone per row into its own plane's tombstone table. From then on no write path commits that id again (BDP idempotency-expired): - every create door — Lifecycle.Create, BatchApplier and BatchCreator items, the stores' upsert CreateIssue/CreateIssues, a transaction's CreateIssue, the unit of work's domain create with or without CreateOnly — refuses it with the typed *issueops.IdempotencyExpiredError (ErrIdempotencyExpired, re-exported from storage, backend and beads); - an import skips and reports it (BatchCreateOptions.OnRetiredID, which the unit of work's Importer surfaces as ImportBatchResult.RetiredIDs; ConflictSkip, the auto-import path, skips it silently); - the generators treat it as taken: hash mode folds the tombstone check into its one collision read, counter mode walks past retired values with one probe each, the uow mint likewise. The race a create loses to the sweep of its id is closed by a lock, not by isolation: every path that decides whether an id may be written writes the id's create coordination cell (local_metadata, 4096 shards, sorted, one statement) BEFORE it reads occupancy, and a retaining sweep — the shared SweepInTx and the unit of work's retiring delete — writes the cells of every id it retires BEFORE it deletes. On a READ COMMITTED door the create that comes second waits out the sweep and then reads its tombstone; a sweep that comes second fails serialization or meets a write-write conflict and retries over the created row. Occupancy is one statement over both row tables and both tombstone tables; a live row wins. A CreateOnly batch no longer reads tombstones it never consults. Only a retaining sweep retires: a plain prune or purge, the Deleter and bd gc's decay leave ids reusable, and the Sweeper and Deleter docs say so. The IDRetention conformance contract (17 cases: opt-in, both planes, each door, the no-history re-create through every door, dry run, narrowing, history, and three staggered races — create-only, upsert and import — asserting no interleaving ever leaves a live row beside a tombstone) runs on the dolt, embeddeddolt and uow legs; the dolt races run on a multi- connection store. The http leg waives it by name until the wire lands next in this series. The two store legs hand out no Importer role, so they drive the import cases through conformance.IDRetentionUpsertImporter, over CreateIssuesWithFullOptions: the seam `bd import` writes through on them (ArrivalUpsertImportHook's precedent). The unit-of-work leg uses its Importer, which now reports RetiredIDs. The http client cannot send RetainIDs yet (apigen.SweepRequest has no retain_ids member), so it refuses a retaining sweep before the dial under a new refuse row, W-SweepRequest.RetainIDs, rather than dropping the field and running a sweep that leaves the ids reusable; the wire commit retires the row. TestSweepResultCarriesEveryWireMember skips RetainIDs by name until then. httpapi's TestSweepResponseCarriesEveryRoleField counts issueops.SweepResult against the wire's SweepResult; RetainIDs is waived there by name until the wire commit projects it, so this commit is green on its own. The history-off differential's goldens (historyoffequiv) are re-recorded from this series, as its package doc prescribes for a deliberate change to what flag-off storage writes: the coordination cells of the scenario's explicit-id upsert creates add rows to local_metadata (six on the embedded and server legs, for s1-s4, sw and t1; three on the unit-of-work leg, for u1, uw and u2). A recording of the base is byte-identical to the committed goldens, and no other table's digest moves. The digests were recorded on bd-enterprise#210, whose base carries the same goldens as main, and recorded_from says so. The createbatchequiv retired scenario stamps its seeded rows' participation (stampParticipation), as depadd and waitsfor do, so the batch's upsert of eq-rl mints under the participation-generation fence as it did when its golden was recorded. TestIDRetentionContractRaces is pinned to dolt_server_full_test's shard 16 (server-storage-test-shards.txt). Left to the name hash it lands in shard 6, which already takes about the whole 15m test timeout under load, and pushes that shard past it. Ported from gascity/bd-enterprise#210 (58d8b1527). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(cli): bd prune/purge --retain-ids, the typed create refusal, and retired rows on import - `bd prune --retain-ids` and `bd purge --retain-ids` ask the sweep to retire every id it deletes. --json gains retain_ids: true; text says "Retired N id(s)", or "Would retire N id(s) ... would be refused" in a preview; the confirm hint carries the flag so the run it suggests is the sweep that was previewed. - `bd create --id X` of a retired id renders one shared typed refusal on the direct and proxied routes: --json prints {"error","code":"idempotency_expired","id","closed_at"}, text says the create that used the id already happened and never runs again; exit 1. - `bd import` skips a retired row and reports it in retired_ids and a stderr note, on the classic and proxied routes, and `--dry-run` now agrees with the run it previews: it reads the would-create ids' tombstones through an optional store seam (RetiredIssueIDs, under the CLI's decorators) and reports them as retired instead of counting them as creates. - The confirm hint is sweepConfirmHint's, so --retain-ids joins the selectors TestSweepConfirmHintCarriesEverySelector pins. - docs/workflows/wisps.md documents --retain-ids and that only a retaining sweep retires; CHANGELOG entry for the whole series. Tests: the embedded CLI end to end (prune and purge, both envelopes, import and its dry run), the proxied route's envelope (gated on the proxied-server tier), and the dry-run classifier in both stale modes. Ported from gascity/bd-enterprise#210 (4116bc2a5). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(wire): retain_ids on issues:sweep, 410 idempotency_expired, and the served IDRetention leg The wire half of the retaining sweep. - issues:sweep takes retain_ids (and echoes it), behind the new behavior token issues.sweep.retainIds; the token also promises that every create path on that server refuses a retired id. The client refuses RetainIDs locally, sending nothing, when the server does not advertise it: a sweep that dropped the member to get past an older server would leave every swept id reusable. The interim refuse row W-SweepRequest.RetainIDs the storage commit added is retired (kept as history, like the S4 rows). - createIssue and applyBatch answer a retired id with 410 idempotency_expired (param naming the id, or the batch item's members, plus closed_at), classified ahead of the validation and already-exists arms; the client maps the code back to the typed *issueops.IdempotencyExpiredError. - The http leg wires the IDRetention contract through the served fixture and retires the series' interim waivers. Five cases stay waived by name: the in-transaction one (no transaction spans requests), the two that drive a store's upsert-shaped CreateIssue, which the wire does not serve (createIssue is create-only), and the two import cases: the wire publishes no import operation, so the client hands out no Importer. All five run on the store legs. - apigen is regenerated from the spec; the wire-shape golden follows. Ported from gascity/bd-enterprise#210 (c6e938737). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): create-only batches take every id's shard cell once, sorted A create-only batch (ExecuteCreateBatch, a CreateOnly CreateIssues) took its coordination cells one item at a time, in item order, through each row's EnsureIssueIDAvailableInTx, and an apply-batch took them per create item through ExecuteCreate. Retaining sweeps, upsert batches and imports lock large sorted cell sets, so on a backend that runs these doors read committed (bd-enterprise's Postgres store) such a batch could hold a later shard while it waited on an earlier one and deadlock against them (40P01). A SERIALIZABLE envelope or an importer retries that; a single-attempt, read-committed CreateIssues or CreateIssuesWithFullOptions, which `bd import` calls, would surface it. - newCreateBatchCache coordinates every id the batch names in one sorted write for CreateOnly batches too, and a row whose cell the batch already holds runs only the occupancy probe (checkIssueIDAvailableInTx). A row the cache never saw (a generated id) still takes its own cell. - ApplyBatchInTx takes the cells of every explicit create id in one sorted write before its first item. - CoordinateIDCreatesInTx's doc no longer says sorted order "cannot deadlock" unconditionally: it holds between callers that take all their cells in one call, and names the residual (a generated id minted mid-transaction). Tests (sqlmock statement order): a CreateOnly batch locks both ids in one sorted write before its reads and its rows probe without re-locking; a row outside the up-front set still locks first; an apply-batch's first statement is the sorted lock of its explicit create ids. Ported from gascity/bd-enterprise#210 (0802d1640). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(uow): guard only caller-named ids against retirement in the upsert Insert domain/db's upsert Insert ran RefuseRetiredIDInTx for every create, including ids the use case had just minted and child-counter ids, where issueops' create body guards only explicit ids. Every node of an applyGraph, a createMany, a graph apply or a molecule pour through the proxied server paid a coordination cell write and a four-table probe for nothing (the generators already skip retired ids), and on a Dolt server two concurrent 30-node graph applies shared a cell about a fifth of the time, so the loser retried its whole unit of work. InsertIssueOpts gains ExplicitID, set by the create use case from createIDNamedByCaller (ExplicitID, or an id preset on the issue with no parent whose child counter replaces it), and the upsert Insert coordinates and probes only then. The CreateOnly branch is unchanged: it runs the create-only guard for every id, as issueops does. Tests: a generated-id upsert's first statement is its row write; an explicit-id upsert coordinates and probes first; the explicitness rule over ExplicitID, preset, parent and minted ids. Ported from gascity/bd-enterprise#210 (8452e0a74). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): persistence moves and wisp promotion take the id's shard cell A persistence move and a wisp promotion re-insert a row into the other plane without the coordination cell or a fresh look at the row. Raced against a retaining sweep of the same closed row on Dolt, both deleted the source row (identical deletes merge cleanly), the move's insert landed in the other plane, and the sweep's tombstone committed beside it: a live row next to a tombstone, which the contract says never happens. Read-committed doors (bd-enterprise's Postgres store) behaved the same way. Creates still answered 409, so nothing re-executed, but the swept row came back. - moveIssuePersistenceInTx coordinates the id before it reads where the row lives, and a row found in neither plane (a sweep deleted it after the caller read it) is refused with ErrNotFound instead of re-inserting the caller's earlier snapshot. - PromoteFromEphemeralInTx coordinates the id before it reads the wisp. So a move or promotion that comes second behind the sweep finds no row, and one that comes first makes the sweep conflict (Dolt) or fail serialization (a SERIALIZABLE envelope) and retry. Tests (sqlmock statement order): a move's and a promotion's first statement is the id's coordination write; a move of a row in neither plane is ErrNotFound and writes nothing. Ported from gascity/bd-enterprise#210 (6c5f9e5c3). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dolt): replay a sweep that lost the commit-time merge; state the lock footprint The Dolt store's sweeper ran its write in withWriteTx, a single attempt. A retaining sweep writes one create-coordination cell per shard it retires, and the cells are 4096 shards shared by unrelated ids, so on a sql-server any create, upsert or import committing in one of those shards first conflicts the sweep (1213/1205 or the exact 1105 autocommit rollback). At a limit of 1000 that is about 22% of all shards, and at a load of about 5.8 creates/s per shard most such sweeps would have failed outright. - The sweeper writes through withRetryTx, as the deleter does: a rollback-guaranteed conflict replays the whole body, candidates re-read and the result reset at the top of each attempt. The uow sweeper (RunTxResult) already replays; the embedded store serializes its transactions. - SweepRequest.RetainIDs documents the footprint: about 4096·(1-e^(-N/4096)) shard cells held until commit, what that does to creates on a read-committed backend (they wait) and on a Dolt sql-server (one side conflicts and replays), and to size Limit around 100 and loop on Remaining. Test: a sweep whose first SQL COMMIT is refused with 1213 is replayed and succeeds (fake driver; two COMMITs). Ported from gascity/bd-enterprise#210 (0b1ac36c2). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(conformance): retire rows through the wisps-plane retaining sweep on every leg No IDRetention case swept with tier wisps-plane, the exact request an orchestrator sweeping its operation rows sends (wisps-plane, retain_ids, protect_referenced off, a limit). That tier has its own candidate path on every backend (SearchWispsPlaneInTx; sweepCandidatesInUOW on uow), so the durable and ephemeral cases did not cover it. RunIDRetentionAWispsPlaneRetainingSweepRetiresItsRows seeds a closed no-history row and a closed ephemeral row, sweeps them with that request, and asserts both tombstones land in wisp_id_tombstones with the rows' closed_at, that Remaining is 0, and that a re-create of either is refused through Lifecycle.Create and, where served, the upsert-shaped create. It is in the role bundle and wired on the dolt, embedded, uow and served (http) legs. Ported from gascity/bd-enterprise#210 (76bcf085c). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(cli): report each retired import row once and never as an update The import's accounting of retired rows disagreed with itself in places: - assembleImportResult listed a retired id once per row carrying it; the report and the spec say RetiredIDs is deduplicated. - A row the pre-filter planned as an update (live when it read it) that a retaining sweep retired before the batch wrote was reported both in UpdatedIssues/Updated and in RetiredIDs. The batch skipped it, so it is now reported retired only. - The dry-run classifier checked retired ids with slices.Contains per row, quadratic in the rows of an export full of retired op rows; it now uses sets. - Under ConflictSkip a retired row is skipped silently and still counted, as every row ConflictSkip carries is. That is kept (ConflictSkip is the auto-import recovery path, which counts the rows it submitted) and now stated on BatchCreateOptions.OnRetiredID. Test: assembleImportResult over a file with a duplicated retired row and a planned update that turned out retired. Ported from gascity/bd-enterprise#210 (6c34e757e). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: state where the IDRetention race cases bite and how to size a retaining sweep - The IDRetention race cases say where they can fail: only on a backend whose upsert and import doors run READ COMMITTED (bd-enterprise's Postgres legs). The embedded leg and the http leg served over it serialize transactions, and on a Dolt sql-server snapshot reads plus commit-time row conflicts refuse the interleavings anyway: with CoordinateIDCreatesInTx made a no-op, the uow leg (doltserver lane, remote) still passes, as the embedded leg did for the reviewer. Green on those legs is no evidence for the race fix. - CHANGELOG and docs/workflows/wisps.md say a retaining sweep holds the coordination cells of the ids it retires until it commits, and to run large sweeps in batches of about 100 (bd purge --limit; bd prune has no limit, so narrow it with --older-than). Ported from gascity/bd-enterprise#210 (b0873bffa). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): refuse a rename onto a retired id UpdateIssueIDInTx renamed a live row onto any id no live row held, so a rename (bd rename, bd rename-prefix, the storage-level UpdateIssueID) could commit a live row beside a retaining sweep's tombstone — the state the CHANGELOG says no write path produces. It was deterministic: on the embedded store, UpdateIssueID(live -> retired) returned nil and left one live row and one tombstone. The rename now calls RefuseRetiredIDInTx(newID) before anything else: it takes newID's create-coordination cell and probes the tombstones, so a retired target is refused with *IdempotencyExpiredError and nothing is written, racing sweep or not. Tests: - TestRenameOntoARetiredIDIsRefusedBeforeItWrites (sqlmock): the cell and the probe come first and a retired target stops the rename. - New IDRetention case RunIDRetentionRefusesARenameOntoARetiredID (both planes; the refused rename leaves the source row in place), with a new IDRetentionFixture.Rename door wired on the dolt and embeddeddolt legs and waived by name on uow and http, which serve no identity change. - CHANGELOG names the rename refusal. Ported from gascity/bd-enterprise#210 (556ecf460). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dolt): take the coordination cell before demoting a row to wisps DoltStore.demoteToWispInTx — the Dolt store's own persistence move, reached from the storage-level UpdateIssue and UpdateIssueChecked when the updates carry wisp or no_history — re-inserted the row into wisps without the id's create-coordination cell. On a Dolt sql-server a retaining durable sweep and the demotion could both commit: their identical deletes of the issues row and aux rows merge cleanly, and the wisps insert and the tombstone insert touch different tables, leaving a live wisp beside an id_tombstones row (review finding 6's state). The demotion now calls CoordinateIDCreatesInTx for its id before its first read of the row, as moveIssuePersistenceInTx and PromoteFromEphemeralInTx do. A retaining sweep takes the same cell before it deletes, so the two conflict on the cell and one replays: the demotion either commits first (and the sweep then finds no closed issues row) or finds the row gone and fails its update. Test: TestDemoteToWispCoordinatesBeforeItTouchesTheRow (sqlmock) pins the cell write as the demotion's first statement. Ported from gascity/bd-enterprise#210 (437ea2ca8). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(import): count every row of a retired id out of Created The unit of work's Importer set Created to the request's rows minus the stale-rejected ids minus the DISTINCT retired ids. A request may carry an id more than once, and the batch skips every row of a retired id, so a request carrying a retired id twice overcounted Created by one per extra copy, contradicting ImportBatchResult.Created's "excluding ... retired rows". Created now subtracts the request rows whose id is in the retired set. The set is per attempt and keyed by id, so a hook that fires again on a replay still counts each row once. Stale-rejected rows keep their existing per-id accounting; this change does not touch it. The store legs' upsert importer (conformance.IDRetentionUpsertImporter) counts the same way. Test: the IDRetention import case now carries the retired row twice and still wants Created == 1 (on enterprise it failed with Created = 2 before the fix). Ported from gascity/bd-enterprise#210 (195e730e9). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): skip retired child suffixes and retired auto-import rows Review fixes for gastownhall#7931, iteration 1. The child id generators (issueops.GetNextChildIDTx and domain/db's NextChildID) took the next suffix from max(child counter, highest live child) and read no tombstone table. Once a retaining sweep deletes the highest child, its tombstone is the only record that the suffix was used, and the counter can lag it: a database written before GH#4750, the uow route's explicit P.N create, or a re-created wisp parent whose counter row was deleted with it. bd create --parent then refused the minted id with idempotency_expired on every retry, and the uow upsert door (proxied bd q --parent) wrote a live row beside its tombstone. Both generators now fold both tombstone tables into their one high-water read (issueops.UsedChildIDsInTx), and the IDRetention contract gains NeverMintsARetiredChildID on every leg. Under ConflictSkip a retired row was skipped before OnRetiredID could fire, so the embedded auto-import (ImportJSONLData) and the server-mode fallback (importFromLocalJSONLConflictSkip) counted rows they never wrote as imported. OnRetiredID now fires under ConflictSkip too. ImportJSONLData registers it and returns the retired ids, and both auto-import paths count only the rows they wrote, report the skipped ones, and stamp a file whose every row was retired, so the next command does not read it again. The chunked import's dependency pass keeps the callback off, as it already does OnStaleRejected. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…tory; reset-data keeps remote data (gastownhall#7902) * fix(dolt): require proof the server serves the workspace's Dolt directory; reset-data keeps remote data Push, pull and the remote listing ran the dolt CLI in the store's CLI directory (.beads/dolt/<db> by default) for every plain TCP server on 127.0.0.1 whose port no port variable names. For a server bd does not run, on a pinned port, that serves another data directory, the dolt CLI then worked on an unserved copy: bd dolt push printed "Push complete." without the server's commits (--force replaced the remote's branch with the copy's), a pull merged into the copy, and the copy's origin made bd dolt remote add a no-op on a server that lists none. cliDirServesServer now also requires doltserver.ServesDatabaseDirOnPort, the dolt CLI's own test before it hands a command to a server: a dolt process holds the database's lock (.dolt/noms/LOCK), and the first sql-server.info found, in the database's .dolt or else its parent's, names the dialed port and a live process (signal 0, EPERM counting as alive, as dolt does). A copy of a served directory carries the server's info file but not its lock, so it counts as a copy, and so does a directory whose stale info file names a reused PID. A dead first info file does not hand the question to the parent's, since the dolt CLI command bd would run removes it and then works on the files. Neither check reads the process list, so the proof holds where ps cannot run (GH#7214). bd's own server (auto-started, adopted or shared) and a server the user runs over that directory on 127.0.0.1 keep the CLI route and the GH#2118 cold-start recovery; anything else takes the SQL route (CALL DOLT_PUSH / DOLT_PULL / DOLT_FETCH), where Dolt's remote refusals, such as the dangling-reference one bd explains, arrive with the same text. databaseLocked takes the lock shared and non-blocking and releases it at once; it never creates, writes or removes the file. A busy lock means a dolt process holds it (served); a file it cannot open, or a lock call that fails for any other reason, reads as not served, which sends bd through the SQL server. On Windows the shared lock spans every byte, so it meets the byte either of Dolt's lock libraries takes. This is the one maintainer-granted exception to the storage boundary's rule against beads-side flocks, recorded in AGENTS.md and engdocs/PROJECT_CHARTER.md, until the Dolt driver can report whether a directory is served. remoteOnlyInLeftoverDatabaseError no longer says the directory "is not the server's data"; it says bd cannot confirm the server serves it. Exit status and remedy are unchanged. bd dolt remote reset-data deleted a git-backed remote's Dolt data refs and then force-pushed. Through a Dolt sql-server that had already used the remote, that push hung to the 5-minute read timeout (or, with nothing new, reported success having written nothing), leaving the remote without its Dolt data, and the named re-run failed the same way until the server restarted: the server keeps its store for each git remote across the deletion. Through a server, reset-data now pushes the fresh store to a temporary remote and ref, moves the data ref to it with a lease on the value read first, and removes the temporary ref (from a scratch repository of the remote's object format) and the temporary remote, with a context Ctrl-C does not cancel. A failure before the move says the remote's Dolt data is unchanged and names the re-run; a temporary ref that cannot be deleted is named with the git push that deletes it, to run in a clone of that remote. After a failed move the data ref is read back: at the fresh store the reset completes with a warning, at the value read first the data is unchanged, at any other value another client changed it, and an unreadable ref is an unknown outcome that never claims the data is unchanged. The server's store for the remote still holds its pre-reset view after the move, so reset-data then restarts bd's own server on the same port (DoltStore.ManagedServerDir; in shared-server mode the shared server, which briefly interrupts every database it serves). A failed restart still reports the reset, then exits non-zero (--json: server_restart_error), saying to start the server when bd sees it stopped and to restart it otherwise. For any other server, or bd's own where ps cannot run, it warns that the server must be restarted before the next push or pull of the remote (--json: server_restart_required). Through a server, --json's deleted_refs lists only the replaced data ref. Embedded mode keeps deleting the refs and force-pushing. reset-data also refuses a file:// remote whose directory is a git repository, bare or a checkout (any .git entry). Dolt makes a file URL a git remote only when it ends in .git and stores it as git+file://, so any other file:// remote is a Dolt file store among the repository's own files: reset-data cleared a checkout, .git included, and over a bare repository reported a reset that left every old table file in place. docs/recovery/history-squash.md now sends the history-squash cleanup through reset-data, with the server restart right before it that also holds for the documented v1.3.2, and warns against running it on a file:// remote in a git repository, which v1.3.2 clears. Tests: TestServesDatabaseDirOnPort (lock held and free, copies carrying a live server's info file, a stale PID 1 file, no ps), the integration TestLifecycle_ServesDatabaseDirOnPort against a real dolt sql-server, TestStoreHostOwnershipDecisionsAgree and the remote routing tests, TestClassifyResetDataRemote, the reset-data server-route tests for the failed restart, the restart warning and the read-back after a failed move, and the server-leg TestE2E_ResetDataThroughOwnServerKeepsTheRemotesData. testutil.HoldDoltDatabaseLock holds a database's lock as a running server does. Co-Authored-By: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dolt): reset-data leaves a server declared external to its operator Review fixup for gastownhall#7902 (review loop iterations 1 to 3). refreshServerAfterReset restarted every server ManagedServerDir accepts. That proof cannot tell bd's own server from one bd adopted, such as an operator's dolt sql-server over .beads/dolt under systemd (gastownhall#6123), so reset-data could stop a server bd does not run (SIGTERM, then SIGKILL after 5 s). It now restarts the server only when no setting declares it managed outside bd. These are the settings that keep bd from killing a server (killStaleServersForDir): auto-start off (dolt.auto-start, BEADS_DOLT_AUTO_START), or, outside shared-server mode, a server mode that is not owned (ResolveServerModeIgnoringPortEnv: BEADS_DOLT_SERVER_MODE=1, dolt_server_port in metadata.json). An ambient port variable declares nothing (GH#6169). For a declared server reset-data asks for the restart, as for a server bd does not manage, and names the setting, and --json sets server_restart_required. bd starts the shared server itself, so shared-server mode keeps the restart. The text report and the --json warning now say that it interrupted every database the server serves. Also from the review (minor): - resetDataGitURL turns the ssh://[user@]host/./path that Dolt stores for an scp-style remote back into [user@]host:path, as Dolt does before it runs git. GitHub refused the ssh:// form, so reset-data failed for every remote added as git@github.com:org/repo.git. A user or host that starts with "-" keeps the ssh:// form, which git refuses, instead of becoming an option. - reset-data --json prints only the JSON report on stdout: the progress lines go through resetDataProgressf, which is silent under --json. Review loop iteration 2: - docs/recovery/history-squash.md described the server's stale view only as refs deleted under it. Through a server, reset-data moves the remote's data ref while the server runs, so the server's view of the remote goes stale at that move. The runbook now also says that bd restarts its own server after the move (in shared-server mode, the shared one), and that any other server, or bd's own while a setting declares it externally managed, must be restarted after reset-data returns, before the next push or pull of that remote. It keeps the warning against deleting refs/dolt/data by hand. - bd's restart runs doltserver's flush before a stop, as bd dolt stop does: it commits any uncommitted changes in every database the server serves, which on the shared server includes other workspaces' databases. The shared-server warning (text and --json), the help text and the CHANGELOG now say so. - After a data-ref move with an unknown outcome, when a setting kept bd from restarting its server, the hint now names that setting, as the report after a move that landed does, instead of a generic restart hint. - resetDataGitURL checks the user and the host separately for a leading "-", so git@-host keeps the ssh:// form, as its comment says. Either form fails: git hands ssh the same git@-host argument, which ssh refuses. - AGENTS.md no longer backticks repo_state.json, which //test/docsync:docsync_test (TestAgentInstructionFilesAreLinkedAndRouted) read as a repository path that does not exist; that failed the Bazel test and integration lanes at the PR head. Review loop iteration 3: - The iteration-2 runbook replaced the restart right before reset-data with a restart "after it, not before it". The docs describe the pinned release, v1.3.2 (docs/cli-docs.pin), whose reset-data deletes the data refs and force-pushes through the server without restarting it, so an operator following the page right after Step 4's force-push got "data plane reset" over a remote left without its Dolt data. The runbook again says to restart the server right before reset-data and not to push or pull that remote in between, and that running reset-data again right after a restart rebuilds a remote left without its data. That restart does no harm on later releases, whose server route pushes to a temporary remote. The server route, bd's restart after the move and the restart left to the operator are now described as the behavior of releases after v1.3.2, as the page's file:// warning already qualifies its claims. - When bd did not restart the server (a server bd does not manage, or bd's own while a setting declares it externally managed), reset-data printed a warning and exited 0, so a script's next bd dolt push ran through the server's pre-reset view and could write a manifest naming table files the remote lacks. reset-data now reports the reset and then fails, as after a failed restart: the hint asks for the restart, names the setting, and says not to run reset-data again, since the reset is done. --json keeps server_restart_required and the warning in the report on stdout, and prints the error on stderr. - resetDataGitURL keeps an ssh:// URL that names a port: the scp form has no place for one, so git dialed port 22 and took the port for part of the path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen --------- Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… match the real one (gastownhall#7983) * fix(dolt): a dry-run delete counts the request's wisps as the real one does DoltStore.deleteIssues peels a request's wisps off and deletes them itself, in batches of their own, before it hands the rest to the dependents guard (issueops.DeleteIssuesInTx), which then took only those ids as the request. A real delete has already removed the wisps and their dependency rows by then, so it changes nothing there. A dry run has removed nothing: a wisp child's parent-child row onto a durable parent read as a dependent left outside the request, so an unforced dry run refused a delete the real one performs. The embedded store passes every id to the guard and answered correctly. The store now passes the wisps it peeled off to the guard as part of the request (issueops.DeleteIssuesBesideWispsInTx; DeleteIssuesInTx is that call with none), so the dry run answers as the delete does on both stores. The guard still checks only durable rows' dependents, as before. Test: the conformance case DeleteIssuesDryRunCountsTheRequestsWisps (a durable parent with an ephemeral and a no-history child): the server-mode leg fails on the base ("issue dw-p has dependents not in deletion set") and passes with the fix. The new entry point is listed in the journal and version completeness tables. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(migrate-personal): refuse a move that would leave a dependent behind before copying Phase 2 of bd migrate-personal deletes the moved issues from the project database with cascade and force off, so it refuses an issue that a bead left there depends on, such as one someone else created. It ran only after phase 1 had committed the copy into the planning repo, so the command exited 1 with the issue in both databases and asked the user to resolve the duplicate. The move now runs that same delete first as a dry run, whose dependents guard answers before it returns and writes nothing (refuseDependentsLeftBehind), and refuses before the prompt with nothing moved, naming the issue, its dependents and the remedy (bd dep remove). The ephemeral and no-history children a move takes are part of that request, so on the server store this relies on the previous commit's dry-run fix. Tests: TestRefuseDependentsLeftBehind (one dry run of the move's ids with cascade and force off; the refusal text; a store error fails the move), TestEmbeddedMigratePersonal_refusesDependentsLeftInTheProject (someone else's dependent: refused with nothing copied, moved once bd dep remove drops the edge, the dependent stays), and two cases in TestMigratePersonalServerMode: the same refusal on a server-mode project, and a parent moved with an ephemeral and a no-history child. The embedded test and the server-mode refusal fail on the base (the parent is in the planning repo after the failed run); the server-mode child move fails with this commit but without the previous one's DoltStore change. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tained types (BD-6c) (gastownhall#7932) * feat(storage): workspace types.retained — a sweep without retain_ids skips retained types Option C of the retention design (BD-6c, stacked on the retaining sweep). - Workspace setting types.retained (issueops.SettingKeyTypesRetained): a list of issue types, in the JSON-array or comma-separated form types.custom takes. Unknown names are accepted and match nothing. It is read from the workspace database only, on the sweep's own transaction, with no cache to invalidate; a read error fails the sweep and deletes nothing. - The partition (workapi.PartitionSweepRetainedTypes) runs right after the pinned and closed_at recheck: without RetainIDs a candidate of a retained type is held back and counted in SweepSkips.RetentionRequired (dry runs too); with RetainIDs nothing is held back, so the retaining sweep deletes and retires those rows. The shared body reads the key through ResolveRetainedTypesInTx, the unit-of-work body through ConfigUseCase. The Sweeper contract states the new narrowing order. - Wire: SweepSkips.retention_required (optional, generated types and wire-shape golden regenerated), projected by the server and decoded by the client, behind the behavior token issues.sweep.retainedTypes, which gates no request member. - Conformance: two IDRetention cases on every leg (embedded, dolt, uow, served http): a plain durable, ephemeral and wisps-plane sweep holds a retained type back, a retaining sweep then takes and retires it, and unsetting the key releases the next row; and a sweep whose config read fails deletes nothing. Unit tests for the partition, the parse (held equal to types.custom's), and the resolver's read-error path. Ported from gascity/bd-enterprise#212 (27a200723). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(cli): prune, purge and gc keep retained types and say how many - `bd prune` and `bd purge` (including --wisps-plane and --dry-run) report the closed beads a plain sweep kept because types.retained names their type: --json carries retention_required, text names the count and that only --retain-ids deletes and retires them. Both commands' help says so. - `bd gc`'s decay phase holds the same beads back on the direct and proxied routes: it reads types.retained (in the proxied route, on the same unit of work as its candidate search), partitions through the sweep's own workapi function, prints the kept count and carries retention_required in --json. A read error fails the command. - `bd delete` is unchanged: it deletes the ids it names, and a test pins it. - docs/workflows/wisps.md documents types.retained (and that bd delete and bd mol wisp gc do not consult it), docs/reference/configuration.md lists the key, and the CHANGELOG has the entry. The generated CLI reference is pinned to the released bd (docs/cli-docs.pin), so it is not regenerated. Tests: the embedded CLI end to end (prune and purge in both envelopes, gc text and --json, prune --retain-ids taking the kept bead, delete), the proxied route's prune and gc (gated on the proxied-server tier), and fast unit tests for the gc partition and the --json shape. Shard manifests regenerated incrementally. Ported from gascity/bd-enterprise#212 (a94c67b50). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(workapi): one type-list parser; the retained-type partition takes no RetainIDs - workapi.ParseTypeList and workapi.ParseCommaSeparatedList are now the one parser of a list-valued type setting. issueops.ParseTypesConfigValue and issueops.ParseCommaSeparatedList delegate to them, and RetainedTypesFromSetting builds its set from ParseTypeList, so types.custom and types.retained cannot be read differently. The cross-package test that held two copies equal is replaced by a table test of the one parser. - PartitionSweepRetainedTypes drops its retainIDs parameter: every caller either sits inside `if !req.RetainIDs` or passed false, so the "retaining sweep holds nothing back" row tested no production path. Ported from gascity/bd-enterprise#212 (fdb3a9b95). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(config): refuse a types.retained value that would protect nothing types.retained is a safety setting read through the lenient list parse, so `[op]`, `["op","fact"` (truncated JSON), `"op"`, `op fact` and the alias `feat` were all accepted by `bd config set` and held back no row. The write now fails closed in workapi.ValidateSettingWrite, which every WorkspaceConfig body and every `bd config set` route passes through (where status.custom is validated): workapi.ValidateRetainedTypesValue refuses a value that opens with '[' but is not a JSON array of strings, a name holding whitespace, a quote, a bracket or a comma, and an alias of a built-in type, naming the canonical type. Well-formed unknown names stay allowed. Tests: the validator table (accepted and refused values), and the embedded CLI refusing three malformed values end to end. wisps.md and the CHANGELOG say so. Ported from gascity/bd-enterprise#212 (2a4425093). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(conformance): pin the retained-type partition before the protections and Limit New IDRetention case 22, RunIDRetentionARetainedTypeIsHeldBackBeforeTheProtectionsAndTheLimit, registered on every leg (embedded, dolt, uow, served http) and in the role bundle: - before Limit: a retained row closed a day before a plain one; a Limit-1 sweep (dry run and real) takes the plain row and reports RetentionRequired 1, Remaining 0. With the partition after Limit an orchestrator's oldest-first batch loop (`bd purge --wisps-plane --limit N`) would fill every batch with held-back rows and never drain the backlog behind them. - before the reference protection: a retained row an open bead cites counts in RetentionRequired, not Referenced. - before the live-dependent protection: a retained row with a live parent-child dependent counts in RetentionRequired, not LiveDependent (skipped by name on a fixture without AddDependencies). Mutation check (go test -overlay on the shared body, embedded leg): moving the partition after Limit, before the reference protection, or after it each fails this case; before this commit the suite passed with the partition after Limit. Ported from gascity/bd-enterprise#212 (9298b9d02). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(cli): admin cleanup and the stale-closed doctor fix keep retained types Two bulk deletes whose selection is a retention policy over closed rows selected retained-type rows and deleted them through the Deleter role (or row by row) with no tombstone. - `bd admin cleanup` (server mode; deletes ALL closed issues by default, and its unfiltered search merges in the wisps table, so it reached no-history op rows): reads types.retained (a read error fails the command), holds those issues back with holdBackRetainedTypes, prints the kept count and carries retention_required in --json (empty, preview and result). It refuses --cascade while the setting names a type, because the role expands a cascade to every dependent past the guarded selection. - `bd doctor --fix`'s StaleClosedIssues (stale_closed_issues_days > 0): reads the setting on the store it deletes from, fails on a read error, skips retained issues and says how many. - deleteBatchReporting / outputDeletionPreviewReporting let a bulk command add its own --json members; deleteBatch is unchanged for its callers. - The decision X boundary stays: `bd delete` and `bd mol burn` delete the ids or molecule they name. Tests: unit tests for the cleanup selection (retained and pinned held back; --cascade refused only while something is retained), the stale-closed selection and the --json member; a container-gated StaleClosedIssues run. Ported from gascity/bd-enterprise#212 (7fec19403), without its `bd mol wisp gc` hunks (out of scope for BD-6c: wisp gc selects only ephemeral = 1 rows). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(httpclient): refuse a plain sweep an older server would not guard by type Defense in depth for types.retained over HTTP. A server that does not advertise issues.sweep.retainedTypes holds nothing back by type, and the absent retention_required member decodes as 0, so a BD-6c `bd prune` or `bd purge` pointed at it deleted retained-type rows with no tombstone and no signal. The Sweeper role now, for a plain sweep (no RetainIDs) against such a server only, reads types.retained with one getSetting and refuses before the dial (ErrUnsupported naming issues.sweep.retainedTypes) when it names a type — the local refusal invariant 8 gives retain_ids. A read error fails the sweep. A server advertising the token and a retaining sweep never pay the read. wisps.md and the CHANGELOG say so. Tests: the five cases (refused before the dial, unset dials, failed read fails, current server not asked, retaining sweep not asked) against a stub wire that can now answer getSetting; the stub's "current server" and the S4 tests advertise the token, and the masked-server plain sweep expects the read before its dial. Ported from gascity/bd-enterprise#212 (6d2b60d63). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(cli): warn that a types.retained key in config.yaml is ignored types.retained is read from the workspace database only, so a key in config.yaml (or BD_TYPES_RETAINED) protects nothing while looking like it does — the failure the BD-6g plan would have hit had it set the key through gc's EnsureCanonicalConfig. bd prune, bd purge, bd gc (when it decays) and bd admin cleanup now print a warning naming the ignored value and the `bd config set` command that stores it. config.GetRetainedTypesFromYAML exists for that warning alone. wisps.md says so. Ported from gascity/bd-enterprise#212 (424eb2ddb), without the `bd mol wisp gc` call site (out of BD-6c's scope). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(config): set-many validates every database pair before it writes `bd config set-many` writes its batch outside issueops.WorkspaceConfig (one commit for the batch), so it skipped workapi.ValidateSettingWrite: `bd config set-many 'types.retained=[chore]'` stored a value that names no type, and a plain `bd prune` then deleted a closed chore with no tombstone. Every database-bound pair now passes ValidateSettingWrite before any pair is written, on both routes; a refused pair leaves the whole batch unwritten. The check also covers status.custom, so set-many's own copy of it goes. TestEmbeddedRetainedTypes pins the refusal and that the batch wrote nothing; TestProxiedServerRetainedTypes pins it on the proxied route. Ported from gascity/bd-enterprise#212 (22e7636e9). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(cli): the bulk deletes print the ignored config.yaml types.retained warning Only the warning's text was pinned, so a bulk delete that stopped printing it passed every test. TestEmbeddedRetainedTypes now puts `types.retained: op` in .beads/config.yaml and asserts the warning on stderr of `bd prune`, `bd purge` and `bd mol wisp gc`. Making warnIgnoredYAMLRetainedTypes a no-op fails it. Ported from gascity/bd-enterprise#212 (4eef1dc82). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(httpclient): the older-server refusal names types.retained and the remedy A plain sweep refused because the server does not advertise issues.sweep.retainedTypes answered with a bare unsupported-capability error that named neither the setting nor what to do. It now says which value types.retained holds and to re-run with --retain-ids or upgrade the server, still wrapping *storage.ErrUnsupported. refuseUnservedSweep's doc no longer says a request using none of the S4 members skips the snapshot: every sweep takes it. Ported from gascity/bd-enterprise#212 (092e408aa). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(doctor): the Stale Closed Issues check stops counting retained rows The check counted every stale closed row as cleanable, but its fix holds back the rows of a type types.retained names, so on a workspace with such rows it warned forever about rows nothing it suggests removes. It now counts by type, sets the retained ones apart (countStaleCleanable, through the workapi type set), warns only on cleanable rows, and names the retained count in its detail. A failed read of the setting answers "N/A (query failed)" as the count query does. Ported from gascity/bd-enterprise#212 (e354a28a4). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(config): one canonicalizing read of types.retained; the write check is syntax only types.retained was matched on the stored spelling, so every alias or case variant had to be refused at every write route (bd config set, set-many, WorkspaceConfig, config.set, the HTTP client) and at every older server that has no rule at all. The pass-5 review major was the route that did not: a client writing `feat` or `Chore` through an older bd serve stored a value that, after the upgrade, protected nothing. bd also has two alias tables (types.IssueType.Normalize and utils.NormalizeIssueType) that disagree on mol, mr, investigation and others. Normalize once, at the read: - workapi.RetainedTypesFromSetting returns, for each parsed name, the name itself (custom types match verbatim), its canonical form under both alias tables, and its lower-case form when that is a built-in type. A stored feat, mol or Chore protects feature, molecule or chore. Matching can only over-protect. Every reader goes through it: both Sweeper bodies, gc decay on both routes, admin cleanup, the stale-closed check and fix, and the HTTP client's older-server refusal (through a new storageops delegate). - workapi.ValidateRetainedTypesValue checks syntax only: a value opening with '[' that is not a JSON array of strings, a non-blank value that names no type (null, ",", [""]), and a name holding whitespace, a quote, a bracket or a comma. [] and a blank value stay allowed. The alias and case refusals are dropped; the read makes them unnecessary. - The HTTP client calls that validator through a storageops delegate (as it already calls ParseTypesConfigValue) instead of restating it, and TestSettingWriteValidationMatchesTheSharedValidator pins a refused and an accepted value on each rule. Tests: TestRetainedTypesFromSettingCanonicalizes (alias from each table, case, custom verbatim, union; exact sets), TestPartitionSweepRetainedTypesMatchesTheCanonicalRead, the validator table rewritten to syntax, the client drift rows and a refuse-before-the-dial row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(cli): wait 2 s before bd gc --older-than 0 in the retained-type tests --older-than 0 selects closed_at before now cut to the second, and a close stamp is stored rounded half-up to the second (DATETIME(0)), so a bead closed in the last 1.5 s can still read as not closed before the cutoff. 1.1 s flaked TestProxiedServerRetainedTypes. The set-many and config set refusal rows use `null` (names no type) now that an alias is canonicalized on read rather than refused. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(cli): bd admin cleanup keeps retained types against a Dolt sql-server Only cleanup's selection was unit-tested; the command itself is server-mode only, so no CLI test reached it. TestAdminCleanupServerModeKeepsRetainedTypes runs in the dolt-server-cmd tier: with types.retained set to "op,Chore", `--cascade --force` is refused and deletes nothing, then `--force --json` deletes the closed task and keeps the closed chore and a closed no-history op row (which cleanup's unfiltered search merges in from the wisps table), reporting retention_required 2, and a second run prints the kept line. The "Chore" spelling pins the canonicalizing read end to end. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(gc): the proxied decay selection is a helper of its own runGCProxiedServer was in the scorecard's major band before BD-6c (cyclomatic 50, cognitive 77), and the retained-type hold-back added 4/6. The decay's read (closed issues and types.retained on one unit of work), the closed-deletion safety filter, the hold-back and the kept line move into readProxiedDecayCandidates, so runGCProxiedServer is back at its base complexity (50/77) and the BD-6c change lives in a 6/7 helper. No behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: types.retained guards the retention doors; scope, semantics and non-goals written once The setting's scope is the retention doors: the commands whose selection is a retention policy over closed rows. They are the Sweeper role (bd prune, bd purge, POST issues:sweep) without retain_ids, bd gc's decay, bd admin cleanup (which refuses --cascade while the setting names a type) and the stale-closed-issues bd doctor --fix. The semantics are: a retained row protects itself only; closed rows only; in a sweep the partition runs after the pinned and closed_at rechecks and before the protections and Limit; read from the database only, on the door's own transaction, failing the door on a read error; and one canonicalizing read. Not in scope, by design, and now said so: bd mol wisp gc (it selects only ephemeral = 1 rows, so it never meets a no-history row), the doctor's Patrol Pollution and test-pollution deletes (heuristics), bd migrate-personal (a cross-store move), and the deletes that name what they delete (bd delete, bd mol burn/squash, bd cook --force, bd repo remove) and bd sql. That is stated once in each place a reader looks: the SweepRequest.RetainIDs godoc (the canonical statement; SettingKeyTypesRetained and PartitionSweepRetainedTypes point at it), wisps.md, configuration.md and the CHANGELOG, which also describe the canonicalizing read and the syntax-only write check. The CapSweepRetainedTypes godoc names the older-server refusal its absence triggers, and the server's CapIssuesSweepRetainedTypes comment no longer says a client cannot be refused. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(retention): gc, cleanup and the doctor fix read types.retained with their selection bd gc's decay, bd admin cleanup (its --cascade refusal included) and the stale-closed bd doctor --fix read the closed issues and types.retained in two snapshots, while the published rule said each door reads the setting on its own transaction. They now read both on one, through the new optional storage.IssuesWithConfigSearcher capability: SearchIssues and GetConfig of one key in one read transaction, the same two reads as before. The Dolt server and embedded stores implement it, and storage.SearchIssuesWithConfig finds it behind the decorators the way SearchDescendants does; the http client, whose wire has no transaction, gets the two reads back to back. The RetainIDs godoc, wisps.md and the CHANGELOG now say which door reads where: a sweep on the transaction that deletes; gc, cleanup and the doctor fix with their selection, before they delete. bd doctor --fix now prints the ignored config.yaml types.retained warning before it selects, as gc, cleanup, prune and purge do. The message moves to internal/config (RetainedTypesYAMLWarning) so the fix package shares it, and the Dolt-backed stale-closed test pins it: a yaml key naming task draws the warning and the task is still deleted. Minor findings fixed alongside: - the canonical read also protects each fragment of a name the write check would refuse ([op], "op", op fact), so a value stored past the check by an older bd or bd sql over-protects instead of protecting nothing; - wisps.md, configuration.md, the CHANGELOG and the SettingKeyTypesRetained godoc say a bd that predates the setting ignores it, so every bd that runs these commands must be upgraded first; - closed_delete_candidates.go no longer claims that bd mol wisp gc honors the setting or that every door deletes through the Deleter role. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…all#8013) .githooks/pre-push decided whether to run the suite with `git diff --name-only ... | grep -q .` under `set -o pipefail`. On a diff larger than a pipe buffer, grep exits on the first line, git dies of SIGPIPE writing the rest, and the failed pipeline reads as "no Go changes", so the push skips the suite. Test the captured output with `[ -n "$(git diff --name-only ...)" ]` instead. TestPrePushHookRunsSuiteForLargeDiffs pushes a 3000-file Go commit (about 300 KB of names) and asserts the suite runs, and a docs-only commit over it, which must still skip. Upstreamed from gascity/bd-enterprise#280. Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ule (gastownhall#8014) workapi.ValidateSettingWrite, which every WorkspaceConfig leg calls, now refuses a key longer than types.MaxFieldLen characters and a value larger than types.MaxTextBytes bytes. The error carries issueops.ErrValidation and types.ErrFieldTooLong. The bound applies to writes only; removing an over-long key still succeeds. Before this the bound was the HTTP operation's edge check alone: over http an oversized write was a typed, member-named ErrValidation, while a local leg let it reach the column, which refused it with a driver error no caller could classify (and a backend with unbounded text columns would have stored it). - New WorkspaceConfig contract case BoundsTheKeyAndTheValueOnSet, wired on the dolt, embeddeddolt, uow and served legs. Both halves read the table to show that a refused write left no row. - The served pin TestServedConfigWriteBoundsAreTheRolesOnBothLegs now asserts that both legs refuse. - The http client restates both bounds, as it does every role rule, so an oversized write never dials (TestConfigWriteBoundsAreNotRestatedClientSide is replaced by rows in the shared-validator and before-the-dial tables). - Divergence-ledger row L-config-bounds is retired, as the row's own upstream ask proposed; ledger doc regenerated. Upstreamed from gascity/bd-enterprise#288 (Postgres leg excluded). Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#8019) cli_fast_test.go's init() falls back to building a ~210MB bd binary into a fresh bd-cli-test-* temp dir when no prebuilt binary is supplied, and never removed it. init() runs before TestMain pins the suite temp root, so the dir landed outside the root TestMain sweeps and leaked on every plain `go test -tags integration ./cmd/bd` run. Record the dir in testBDBuildDir and remove it in TestMain after testMainInner returns, before os.Exit. Also remove it when the build fails, before panicking. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ner by id (gastownhall#8023) Follow-ups from the review of gastownhall#7821 (fork-own CI runs in mode local): - bazel.yml's rbe job runs on Blacksmith only when github.repository_owner_id is gastownhall's (255961667). In a fork repository's own CI (no Blacksmith) its pushes, dispatches and in-fork PRs would otherwise queue for a day and never reach mode local; the lanes already follow the decided mode onto GitHub-hosted runners. - The decide step's FORK_REPO compares github.repository_owner_id instead of the owner's name, so an org rename cannot turn upstream into a fork. - pr.yml's CI Gate: when the Bazel lanes did not run remotely in a fork repository's own CI ($GITHUB_REPOSITORY_OWNER_ID is not gastownhall's), the error says it is always mode local there and a re-run will not help, instead of "re-run all jobs later". - Tests: TestBazelRBERunnerOutsideGastownhall evaluates the real rbe runs-on and FORK_REPO across events and owners (renamed org, look-alike name); wantRBERunsOn and bazelForkRepoValue pin the new expressions; the gate simulation sets GitHub's default repository variables and checks both gate messages; the merge-queue contexts carry the owner id. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…stownhall#8030) * fix(conformance): cast metadata to CHAR in the batch-apply probes The batch-apply conformance probes read metadata as COALESCE(metadata, ''). On a backend whose metadata column is a native JSON type (PostgreSQL jsonb), the engine types the COALESCE at plan time, parses '' as JSON and rejects the statement at PREPARE with 22P02, so an external backend running this package fails before reading a row. Spell the probes COALESCE(CAST(metadata AS CHAR), ...) in batchApplyEdgeMetadata, batchApplyMetadataKey and the served batch-apply tests. On Dolt/MySQL the cast is a no-op on the returned JSON text; callers already decode the blob rather than comparing bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(conformance): state the CAST AS CHAR probe's dialect premise The batchApplyEdgeMetadata doc comment said CAST(metadata AS CHAR) "is a plain text cast elsewhere". It is not on PostgreSQL, the engine the comment names: a bare CHAR there is char(1), so the untranslated cast prepares cleanly and truncates the blob to "{". The probe ports because, like the rest of this package's SQL, it is MySQL dialect that a backend on another engine translates, with CHAR mapped to its text type. The comment also put the refusal on the column being a native JSON type. Dolt's metadata column is native JSON too and accepts the bare COALESCE; the 22P02 is PostgreSQL typing the untyped empty-string literal as jsonb. Reword it to say both, point at the spelling assertIssueOperationsStoredMetadata already uses, and tighten the matching note in the served test. Comment-only. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
9.3.1 fixes bazelbuild/bazel#31738 (bazelbuild/bazel#31896): when an attempt to take the repo contents cache GC lock failed, Bazel leaked the gc_lock fd, and closing it later silently dropped the shared lock a running command held, so another server's GC could delete cache entries out from under a live build. - .bazelversion: 9.3.0 -> 9.3.1 - setup-bazel: pinned sha256 for bazel-9.3.1-linux-{x86_64,arm64}, from the release's .sha256 files - rrc_verify.py: BAZEL_RRC_GUIDS["9.3.1"]; RemoteRepoContentsCacheImpl's GUID is unchanged from 9.3.0 - scripts/bazel_rrc_test.go: re-pin the vendored rrc_verify.py digest MODULE.bazel.lock is unchanged under 9.3.1. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#7930) * fix(beads): root a non-git -C target at itself, not the caller's repo From inside git repository A, `bd -C T` (or BEADS_DIR) naming a beads project in no git repository rooted RepoContext at A: isExternalBeadsDir returned the .beads-side discovery error, buildRepoContext dropped it, and the CWD-scoped GetMainRepoRoot answered. When the CWD is in a repository but git cannot place the .beads, isExternalBeadsDir now decides by work-tree position: a .beads outside the CWD's work tree is external and rooted at its parent by the existing repoRootForBeadsDir fallback. The CWD-side error (GH#4772) is unchanged. Fixes GH#5700. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 993621e) Ported-From: opus/993621e11cf8e2935ee1f06cc889d4d7d2cb2a68 AC: AC-1 * test(beads): pin implicit Contributor for a non-git -C target AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 83d772e) Ported-From: opus/83d772e4f697984c4f3c6257052b32c20696d914 AC: AC-2 * test(beads): guard NoRepoRootError for a non-git -C target from a non-git CWD AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 29a83f3) Ported-From: opus/29a83f3725fcf9d26ad02d30d185619790310f1d AC: AC-3 * test(beads): keep an in-tree .beads git cannot place local AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9322170) Ported-From: opus/93221706577ab98c74729cf1818eee5058bc2d58 AC: AC-4 * test(cmd/bd): route bd -C <non-git project> by the selected project AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit c713d65) Ported-From: opus/c713d65b550fa819032158281b1af591e8eb5940 AC: AC-5 * fix(beads): keep nested symlinked .beads local; never pin a refused repo Review fixes for GH#5700 (PR gastownhall#7930, iteration 1). A nested workspace whose .beads is a symlink to out-of-tree storage (A/sub/.beads) resolved local on main but external at the PR head: beadsDirInCWDWorkTree only recognized a symlinked <root>/.beads. It now walks from the symlink-resolved CWD up to the top level and accepts the .beads of any directory on that walk, where walk-up discovery finds it. A symlinked .beads named from elsewhere in the work tree (bd -C sub from the top level) still resolves external; REPO_CONTEXT.md documents that. The positional answer also rooted a .beads in a repository git refuses (another user's, under safe.directory) at that repository, and GitCmd's explicit GIT_DIR skips git's ownership check, so `bd dolt remote add` could run its core.fsmonitor as the caller. buildRepoContext now refuses the .beads-parent fallback whenever that parent holds a .git git did not open from the .beads, returning *NoRepoRootError. That also closes the same bypass through a .beads/redirect, which main already had. GetRepoContextAllowingNoGit still recovers the workspace, keeps it a redirect, and reports the CWD's own root and worktree status. Tests: nested symlinked .beads (discovered and via BEADS_DIR), a linked worktree of a repo whose .beads is symlinked, a sibling sharing the caller repo's path prefix, and a GIT_TEST_ASSUME_DIFFERENT_OWNER refusal with a core.fsmonitor marker, for a named .beads and for a redirect. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…all#7941) * fix(dep): warn when dep add stores an unresolved cross-prefix target bd dep add accepted a bare cross-prefix target that resolved neither locally nor through routing, stored it in depends_on_external, and reported success exactly as for a resolved target, so a typo in another rig's prefix failed open (GH#6556). The pass-through stays (it is the multi-rig "add now, route later" shape), but resolveUnresolvedDepTarget now reports it as unverified and the positional route prints a stderr warning after the write, naming the target and the bd dep remove command that deletes the stored edge. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fa94b3f) Ported-From: opus/fa94b3fd51c8b8014b68143c5ef2cf1f756dd299 AC: AC-1 * fix(dep): warn per unresolved cross-prefix line in dep add --file The --file route accepted the same unverified cross-prefix targets through resolveUnresolvedDepTarget but dropped the signal. validateBulkDepEdges now records it on the edge, and addBulkDependencies prints one line-prefixed warning per such edge after the batch is stored. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 7feda7c) Ported-From: opus/7feda7c480cb770d78fe451f40324014c89814c6 AC: AC-2 * test(dep): pin dep add --json shape beside the unresolved-target warning With --json the stdout object keeps exactly status, issue_id, depends_on_id and type, and the unresolved cross-prefix warning goes to stderr only. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f53838c) Ported-From: opus/f53838c599fea371f4dcce7740ecd5b8fad99b4d AC: AC-3 * test(dep): resolved and external dep add targets print no unresolved warning A target that resolves locally, or a well-formed external: reference, never enters the unverified pass-through, positionally or via --file, so it gets no unresolved-target warning. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit abdfe33) Ported-From: opus/abdfe3355071193ed26451d8072340ae7df9b84c AC: AC-4 * fix(dep): let --quiet silence the unresolved-target warning --quiet is documented as errors only, and the package's other non-error notices honor it; the edge is still stored. AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 068f5cc) Ported-From: opus/068f5cca9c02c4639f8340f294621cf67193e242 AC: AC-5 * fix(dep): warn on unresolved cross-prefix targets on the proxied route too Review fixes for gastownhall#7941 (GH#6556). The proxied-server writers (bd dep add, --file, and the bd dep --blocks alias) resolve no IDs, so the server stored a bare cross-prefix typo with a success line and no notice while the direct route warned. After a successful proxied write, look the target up the way proxied mode can (the server's database as an issue or wisp, then a prefix route) and print the same notice when it is missing. A cross-prefix target the server or a route finds, a same-prefix target (held by the store's foreign key) and an external: ref get none. Both lookups are exact, and only the stored ID counts as found, because the row holds the target as typed. The route's default resolver would count a unique abbreviation of a rig ID (gt-targ for gt-target1), or a hash the rig holds under another prefix, as found: that dead edge got no notice and a false "resolved to gt-target1" note. The notice now names the IDs the abbreviation matches, or the ID the rig resolved the hash to. The notice now tells a miss from a failed lookup: an unreadable route, a rig that will not open or an ID ambiguous in the routed rig is named ("could not be verified: <error>", printed as one escaped line) instead of being reported as "was not found" and blamed on a typo. resolveUnresolvedDepTarget hands back the lookup error (miss) in place of the unverified bool. A route into a rig in proxied-server mode is not a failed lookup but none at all: bd will not open such a rig as a direct store (gastownhall#5861), so that refusal says nothing about the target. Reported as a miss, it gave every valid cross-rig edge in an all-proxied town a typo notice with a bd dep remove that deletes the edge. Both routes now drop it through one helper, depTargetLookupMiss, so a target in such a rig gets no notice, typo or not, until routed reads can open one. The --file warning loop moves into warnUnverifiedBulkDepEdges, shared by both --file routes, which puts addBulkDependencies back at its base 18/25 (gocyclo/gocognit) from 20/28. Tests: stub-server pins for the three proxied writers (missing, held by the server, same-prefix, external, --quiet, a failed server lookup, a route that cannot be followed); a Dolt-backed pin for a routed target (found: no notice; missing in the rig: not found; an abbreviation, a hash the rig holds under another prefix and a hash two rig issues share: named, with no "resolved to" note; a rig in proxied-server mode: no notice and no bd dep remove for the target it holds or for a typo); a direct-route row for the same proxied-server refusal; a proxied-lane subtest against a real server; a refused --file batch and a refused --type print no notice. The docs say why an ID could not be verified and that an ID routed to a proxied-server rig is not checked. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rkspace (GH#4627) (gastownhall#7949) * test(store_reopen): pin symlinked .beads reverse mapping past a trap ancestor (GH#4627) PersistentPreRun maps the discovered database path back to a beads directory with resolveCommandBeadsDir. Pin the reporter's full GH#4627 chain — a .beads symlink to an embedded workspace not named .beads, plus an ancestor .beads holding only embeddeddolt/ — on the fix from PR gastownhall#4575 (GH#4574), which no in-tree test covered: discovery follows the symlink, and reverse mapping must return the workspace rather than letting the ancestor walk select the trap. AC: AC-1 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit 4528e0e) Ported-From: glm/4528e0e3748fcb54efd7626cd9c088496945d304 AC: AC-1 * test(store_reopen): pin explicit --db spellings onto the symlinked workspace (GH#4627) The GH#4627 reporter found only --db <real target dir> worked at v1.1.0, while --db <.beads symlink path> and --db <target>/embeddeddolt did not. Pin that all three explicit spellings now resolve through resolveCommandBeadsDir to the same workspace and none to the trap ancestor. AC: AC-2 Agent-Signature: claude-code-glm-5.3-unknown-reasoning on behalf of Julian Knutsen (cherry picked from commit fc3845c) Ported-From: glm/fc3845cfe0b32d6f5ec2be4429e61bc6c8faad42 AC: AC-2 * test(store_reopen): narrow the GH#4627 pin to what it proves Adoption review of gastownhall#7949 found that AC-2 overstated what it pins. With the parent match from PR gastownhall#4575 removed, only the <target>/embeddeddolt spelling fails. The real target directory and the .beads symlink path match resolveBeadsDirForDBPath's self-equality check, which predates gastownhall#4575, so they pass without it. The symlink path also comes back as spelled, and the workspace gate refuses a symlinked directory (workspacegate.forDir), so `bd --db <project>/.beads` still runs every store command ungated. That is a separate gate defect, outside this test. - AC-2 now says which spelling pins gastownhall#4575. The target-directory and embeddeddolt spellings must come back as the physical directory, byte for byte; the symlink spelling still only has to select the same workspace. - AC-1 now runs both discovery routes without --db: the public tree walk, and the route PersistentPreRunE takes (FindBeadsDir exported as BEADS_DIR, then FindDatabasePath). Each must return <target>/embeddeddolt exactly, and reverse mapping must return the physical workspace. The old PathsEqual comparisons let a dropped CanonicalizePath on either route pass. Mutation check with the focused bd_test filter: removing the gastownhall#4575 parent match fails both AC-1 routes, the embeddeddolt spelling and the GH#4574 test; dropping the tree walk's CanonicalizePath, or the BEADS_DIR branch's canonicalizeBeadsDirPath, fails that route's FindDatabasePath check. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ssion (gastownhall#7960) * fix(versioncontrolops): drain MergeAndSettle's DOLT_MERGE MergeAndSettleWithStrategy's CALL DOLT_MERGE(?) now goes through schema.DrainCall; the "up to date" swallow is unchanged. Adds TestMergeSettleDrainsCallResultSets, a sqlmock regression suite that fails when a merge-settle CALL goes back to ExecContext (GH#5556). AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit a62d605) Ported-From: opus/a62d6051467425c5c54c3b5c0bdaaa63a8adb29f AC: AC-1 * fix(versioncontrolops): drain MergeWithStrategy's DOLT_MERGE MergeWithStrategy pins a pooled *sql.Conn and returns it to the pool afterwards, so its CALL DOLT_MERGE('--author', ?, ?) now goes through schema.DrainCall; the "up to date" swallow is unchanged (GH#5556). AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit bc49b9e) Ported-From: opus/bc49b9eba5089df67d49c1dd9d12099d78c1018d AC: AC-2 * fix(versioncontrolops): drain config and schema_migrations conflict resolves TryAutoResolveMergeConflicts' DOLT_CONFLICTS_RESOLVE('--theirs', 'config') and resolveSchemaMigrationsVintageConflicts' DOLT_CONFLICTS_RESOLVE('--ours', 'schema_migrations') now go through schema.DrainCall; the content_hash backfill UPDATE stays an exec (GH#5556). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 304083c) Ported-From: opus/304083cd5e43febcbcc8aa5fd7b6a373acbee02f AC: AC-3 * fix(versioncontrolops): drain the FK cascade repair's DOLT_ADD TryRepairFKCascadeViolations' CALL DOLT_ADD('<table>') now goes through schema.DrainCall; both DELETEs stay execs, so the cascade DELETE's RowsAffected is unchanged (GH#5556). AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3b54672) Ported-From: opus/3b54672d3415a8e4ea4ef6f30addf9cb2c768316 AC: AC-4 * fix(versioncontrolops): drain the strategy resolve, stage and commit CALLs ResolveConflicts' DOLT_CONFLICTS_RESOLVE and SettleMerge's strategy-branch DOLT_ADD(?) and DOLT_COMMIT('-m', ?) now go through schema.DrainCall, so no undrained CALL sits between drained ones on the strategy session; every error wrapper is unchanged (GH#5556). AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit bdd61fa) Ported-From: opus/bdd61fa866216a4d422139ea04a8bd94e697fe6e AC: AC-5 * fix(versioncontrolops): drain abortMerge's abort and reset CALLs abortMerge's DOLT_MERGE('--abort') and its DOLT_RESET('--hard') fallback now go through schema.DrainCall. Both errors stay swallowed and the reset still runs only after a failed abort on a working set that was clean before the merge (GH#5556). AC: AC-6 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fe5f4e5) Ported-From: opus/fe5f4e56bf9e579b4060a89aac5373b6d6d859b7 AC: AC-6 * test(versioncontrolops): pin merge-settle CALL error semantics after the drain Every converted CALL whose error is returned keeps its exact wrapper text and errors.Is chain, and both DOLT_MERGE sites still swallow "up to date" (GH#5556). AC: AC-7 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9520cd9) Ported-From: opus/9520cd923bff6997de28d4386a1c592b7b9e8b9c AC: AC-7 * fix(versioncontrolops): drain auto-resolve CALLs on the CLI-repair session TryAutoResolveMergeConflicts' default-branch DOLT_CONFLICTS_RESOLVE, its per-table DOLT_ADD and CommitResolvedConflicts' DOLT_COMMIT now go through schema.DrainCall, so a CALL that fails before the driver drains its result sets cannot leave the pinned transaction's wire buffer dirty (GH#5556). The server-mode CLI conflict-repair sqlmock subtest now expects those CALLs as queries. AC: AC-8 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit da220ea) Ported-From: opus/da220eafd214826dbf96eb04449e883087d8e44f AC: AC-8 * fix(versioncontrolops): drain StageAndCommit's DOLT_ADD and DOLT_COMMIT MergeWithStrategy's conflicted path (`bd vc merge --strategy`) commits the resolved merge through StageAndCommit, which still sent CALL DOLT_ADD and CALL DOLT_COMMIT through ExecContext on the pinned merge session, right before the drained abortMerge. Route both CALLs, and the unauthored commit form, through schema.DrainCall, as dolt's doltAddAndCommit already does, so every CALL the merge-settle machinery issues drains. The "nothing to commit" tolerance is unchanged: DrainCall returns the driver's error as-is. StageAndCommit also backs every server-mode write (finishDoltTransaction) and the embedded stores' commits. The real-Dolt server and embedded suites that drive those paths (MergeWithStrategy ours/theirs, empty-commit guards, blocked recompute, nothing-to-commit) pass unchanged. TestMergeSettleDrainsCallResultSets gains a conflicted merge_with_strategy subtest, an unauthored-commit subtest, and errors_preserved cases for a failed DOLT_ADD and DOLT_COMMIT (each still reaches the drained DOLT_MERGE('--abort')) and the tolerated "nothing to commit". The sqlmock tests and the embedded fake that pinned the exec shape now expect queries. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…gastownhall#7933) * fix(github): close a closed bead with a follow-up PATCH after create GitHub's create-issue POST cannot carry state, so pushing a locally closed bead created an open GitHub issue (gastownhall#5486). CreateIssue now sends a state=closed PATCH after the create, mirroring the GitLab adapter. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 155016f) Ported-From: opus/155016ffacc387b3ef681ee5da8bcbcc62df6a9f AC: AC-1 * test(github): pin that only closed beads get the post-create close AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 075d12d) Ported-From: opus/075d12d46326fe24127522dbeb1cf01fe2885278 AC: AC-2 * fix(github): report a failed post-create close as a warning If the follow-up close PATCH fails, CreateIssue keeps the created issue (so the bead is linked and no duplicate is made next push) and returns the failure in TrackerIssue.Warnings, which the engine surfaces. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 1832e5f) Ported-From: opus/1832e5ffb9289c3f5971e653ccffcd894aa7b6e8 AC: AC-3 * fix(tracker): don't cache the push hash for a create that returned warnings A partial-success create (e.g. a GitHub issue whose follow-up close failed) does not leave the remote matching local content. Recording the push hash made every later push take the stored-hash fast path and skip the issue, so the drift was silent (gastownhall#5486). The next push now fetches, compares and updates. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9115819) Ported-From: opus/91158199a8a197e16587b283194b6a504e4f7a30 AC: AC-4 * fix(github): version the push hash to repair issues left open pre-fix Builds before the gastownhall#5486 fix cached the desired closed state's push hash at create time even though the issue landed OPEN, so users who already pushed closed beads stay stuck: every later --push-only run short-circuits on the stored hash. Hashing a format-version field first makes those stale hashes miss once; the next sync fetches each linked issue (the same one-time cost as a fresh clone), sees the state mismatch, closes it, and re-caches. AC: AC-5 Agent-Signature: claude-code-glm-5.3-unknown on behalf of Julian Knutsen (cherry picked from commit 5a833c6) Ported-From: glm/5a833c6f86e15bf3a672be139111309779c3c5a3 AC: AC-5 --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
…er --readonly (gastownhall#7957) * fix(sqlclass): classify reads that call a dolt_ function as Mixed Dolt can expose a write as a SELECT-callable function, so a SELECT that calls one must not take the Read path: in direct mode Read skips the --readonly gate, and in proxied mode it runs in a rolled-back read transaction (GH#6230). Walk the parsed tree for dolt_ FuncExprs so literals, comments and system table names do not match. AC: AC-1 Agent-Signature: claude-code-opus-5.5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit ad147e7) Ported-From: opus/ad147e7bb662a4c0f4ab8c64be03624c995d18b6 AC: AC-1 * fix(sqlclass): keep read-only dolt_ functions on the Read path DOLT_HASHOF, DOLT_VERSION and the other dolt_ scalars the engine registers only read; refusing them under --readonly or sending them through the committing path would break real reads. Unlisted dolt_ names still fail closed to Mixed. AC: AC-2 Agent-Signature: claude-code-opus-5.5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit fea771d) Ported-From: opus/fea771d138c2815216107c63ef711499c4570f66 AC: AC-2 * test(sql): pin the --readonly refusal of SELECT-callable Dolt writes bd sql --readonly "SELECT DOLT_COMMIT(...)" is refused by CheckReadonly before the statement reaches the server, while a dolt_log read still runs (GH#6230). AC: AC-4 Agent-Signature: claude-code-opus-5.5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit dfb5777) Ported-From: opus/dfb5777dab8b6f7f6e70a504fa03d8ad3bf975b9 AC: AC-4 * fix(sqlclass): find dolt_ calls in clauses sqlparser.Walk skips sqlparser.Walk never visits a set operation's own WITH, ORDER BY and LIMIT, a SELECT's named WINDOW clause, or the FROM and FOR operands of SUBSTRING/SUBSTR on a string literal, so a dolt_ write call there still classified as Read and skipped CheckReadonly, for example `SELECT 1 UNION SELECT 2 ORDER BY DOLT_COMMIT(...)`, `WITH t AS (SELECT DOLT_COMMIT(...) AS h) SELECT h FROM t UNION SELECT 1`, `... WINDOW w AS (ORDER BY DOLT_COMMIT(...))` and `SELECT SUBSTRING('abc' FROM DOLT_COMMIT(...) FOR 1)`, also when nested in a derived table, a WHERE clause or under EXPLAIN ANALYZE. callsDoltWriteFunction now walks those clauses itself. TestClassify pins each shape as Mixed, with read-only function, system-table, plain-window and SUBSTRING-literal controls that stay Read. Also reword the Classify comment so it describes guarding a server that exposes a Dolt write as a function rather than a live bypass, and add the CHANGELOG entry for GH#6230. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…gastownhall#7950) * fix(beads): skip the user-global <home>/.beads on implicit discovery walks GH#4402: outside a repository the ancestor walks had no boundary left above $HOME, and hasBeadsProjectFiles is a content guard, not a boundary guard, so a legacy ~/.beads holding config.yaml or a database was adopted as a workspace and writes (bd remember) landed in the global database with no warning. Every ancestor walk (FindBeadsDir steps 2 and 4, FindBeadsDirFrom, findDatabaseInTree, FindAllDatabases, findBeadsDirUpward) now passes over the <home>/.beads candidate — and any redirect file inside it — unless the repository root bounding the walk is $HOME itself (a dotfiles repository). BEADS_DIR, BEADS_DB, --db and a project's own .beads/redirect naming <home>/.beads keep working exactly as before. SkippedUserGlobalBeadsDir reports the skipped directory so cmd/bd can name it in its no-workspace refusal (next layer). AC: AC-1 AC: AC-2 AC: AC-3 Agent-Signature: claude-code-glm-5.3-unknown on behalf of Julian Knutsen Co-Authored-By: Claude Code <noreply@anthropic.com> (cherry picked from commit 93bafad) Ported-From: glm/93bafad88d26f159f9f64d541535dc91d0f7d426 AC: AC-1 AC: AC-2 AC: AC-3 Derived-From: glm/93bafad88d26 * fix(cli): name the skipped user-global ~/.beads in workspace refusals GH#4402, on top of the internal/beads skip: when discovery passed over the user's own <home>/.beads, the refusal said only "no beads database found". Both the root PreRun's refusal and bd where now append a note naming the skipped directory and the opt-in (export BEADS_DIR=<home>/.beads); where --json carries it inside the existing hint string, with no new JSON keys. The note is empty unless the skipped directory is a real workspace, so every existing refusal pin is unchanged. Docs: configuration.md's BEADS_DIR and BEADS_CEILING_DIRECTORIES rows now state the ~/.beads rule, the stale "global fallback" claims in the beads skill's WORKFLOWS.md are gone, and the CHANGELOG records the behavior change with its one-line migration. AC: AC-4 AC: AC-5 Agent-Signature: claude-code-glm-5.3-unknown on behalf of Julian Knutsen Co-Authored-By: Claude Code <noreply@anthropic.com> (cherry picked from commit 798c4d2) Ported-From: glm/798c4d2f694dd68609622acb649b4c957b3d28c6 AC: AC-4 AC: AC-5 Derived-From: glm/798c4d2f694d * fix(beads): key the user-global skip on the account home; close the import and bootstrap paths (GH#4402) Review iterations 1 to 4 of gastownhall#7950. Iteration 1: - The skip keyed on $HOME, so every harness and sandbox that points HOME at a scratch workspace and runs bd there (bdEnv, bdProxiedEnv, the http e2e and corpus fixtures: 39 red tests) refused the workspace bd itself had just created, and an empty HOME turned the skip off while the walk still climbed into the real home. It now keys on the account home (the OS account database, then $HOME), the home bd init's guard and isPathInSafeBoundary already protect. - SkippedUserGlobalBeadsDir re-derived a skip from an unbounded walk, so a git repository under the home directory with no .beads, or a BEADS_DIR naming a missing directory, was told to select ~/.beads. The workspace-selection walks (FindBeadsDir, findDatabaseInTree, FindBeadsDirFrom) now record the directory they passed over, and only that one is named. - bd import run from the home directory fell back to the working directory's .beads, which is ~/.beads; it now gets the same refusal. - The note names BEADS_DIR per command (BEADS_DIR=<dir> bd <command>, quoted by remedy.CommandArg; Windows gets the instruction alone) and says an exported BEADS_DIR overrides every project's own .beads. The CHANGELOG, configuration.md and WORKFLOWS.md say the same. - Tests: the user-global CLI pins run in-process (beads.SetUserHomeDirForTesting), since a subprocess cannot repoint the account home. New pins cover the nested-repository and missing-BEADS_DIR cases, a repointed HOME, an empty HOME, and the skip in FindAllDatabases, the redirect probe and a linked worktree's extended walk. Iteration 2: - bd import run from a subdirectory of the home directory (~/notes) still wrote into ~/.beads. Its fallback names ./.beads, and resolveCommandBeadsDir climbed from that not-yet-created directory to the first .beads above it. The import now refuses with the note wherever discovery passed over a user-level workspace, as every other command there does. resolveCommandBeadsDir returns the .beads directory a dbPath names instead of climbing past it, so a fallback or a create --repo target with no .beads yet never binds one above it: not the user-global directory (a config.yaml-only ~/.beads included), and not one beyond a repository root that discovery never reached. - bd bootstrap's findParentConfig adopted <home>/.beads/metadata.json, its database name and server, for a project under the home directory with no metadata.json of its own. It also stopped only at $HOME, so with HOME pointed elsewhere it read the account home's .beads and went on above it. It now ends at the account home without examining its .beads, unless the home directory is itself a repository root (a dotfiles repository, as discovery allows), and never searches above the account home or $HOME. beads.IsAccountHomeDir exposes the account-home test. - The CHANGELOG entry moves under Changed as a BREAKING change, and covers import and bootstrap. - Tests: subtests for import from a subdirectory of home (refusal, the user-level directory untouched, no workspace set up beside it), for resolveCommandBeadsDir under a user-level workspace and under a config.yaml-only ~/.beads, and for findParentConfig: a project under home, HOME pointed elsewhere, home a repository root, and a home repository without metadata. Each was checked against a mutant of the code it pins. Iteration 3: - An explicit target under the home directory bound ~/.beads. bd --db ~/typo/beads.db, a file-form BEADS_DB and the BEADS_DIR bd import sets up named a directory not called .beads, and resolveCommandBeadsDir climbed from it to the first .beads above, the user-global one, so the command opened and wrote the global database. The climb now ends at the account home without binding its .beads, unless the path lies inside ~/.beads or the home directory is a repository root, and bd import's fallback binds the directory it chose instead of climbing from it. - A linked worktree under the home directory whose main checkout is not an ancestor recorded the skip on its way past the home directory, so bd import there refused to set up the worktree's .beads and every refusal advised BEADS_DIR=~/.beads. The skip is now recorded only where it can be why selection finds no workspace: outside any repository, or from the home directory itself. - Passing over ~/.beads with continue let the walks adopt a .beads above the home directory (/home/.beads, /.beads) that ~/.beads used to shadow. AncestorDirWalk now carries the pass (passOverUserGlobalBeads): the walk does not yield the home directory and ends there, as bootstrap's parent-config walk does, unless a repository root above the home directory bounds it; then it ends at that root. Every discovery walk uses it, which also takes the per-walk skip branches out of FindBeadsDir and findDatabaseInTree. - The CHANGELOG entry covers the end of the walk at the home directory, the linked-worktree import, explicit targets under home and the Go package API; configuration.md's ceiling row says discovery does not look above the home directory. - Tests: discovery with a .beads above the home directory, outside a repository (with and without ~/.beads) and inside a repository rooted above home (its .beads reached, nothing beyond its root, the skip named only from home itself); both linked-worktree layouts record nothing; resolveCommandBeadsDir for a new directory under home, a path inside ~/.beads, a dotfiles home and a .beads above home; --db, BEADS_DB and bd import's BEADS_DIR (also below a project's workspace) open their own target and leave ~/.beads alone; bd create and bd import in a linked worktree under home. Nine mutants of the code they pin each failed their tests. Iteration 4: - A dbPath that is ~/.beads itself bound the home directory. The directory form of --db and BEADS_DB (GH#2548), and BEADS_DIR=~/.beads on a host-routed server workspace, hand resolveCommandBeadsDir the directory itself. With no metadata.json there to validate it (empty, config.yaml only, or the reporter's bare beads.db), the climb started at the home directory and ended there, so the command created embeddeddolt/ and its gate lock in ~ and bd where printed the home directory. A dbPath named .beads now names that directory, even before it exists, as a path directly inside one already did. The CHANGELOG says naming ~/.beads still selects it. - The passOverUserGlobalBeads comment no longer says bootstrap's parent-config walk ends "the same way": it never goes past the home directory, even below a repository root above it. - Tests: resolveCommandBeadsDir for ~/.beads holding config.yaml only, a bare database file or nothing, and not created yet; bd --db ~/.beads create and BEADS_DB=~/.beads bd create put embeddeddolt/ and its gate lock in ~/.beads, not in the home directory, and BEADS_DB=~/.beads bd where --json reports ~/.beads. All seven fail on the previous head. The walk-end tests gain a repository under home and a linked worktree beside its main checkout there; both fail under a mutant that treats every repository root as lying above home. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#7937) * fix(dolt): push to the remote named as bd dolt push's argument bd dolt push had no Args validator and read the target only from --remote, so cobra's default ArbitraryArgs accepted `bd dolt push 1st` and RunE dropped the name: the push went to the default remote and still reported "Push complete." (GH#3720). Accept an optional positional remote, route it through the existing named-remote PushRemote path, and refuse an empty name before the store opens rather than fall back to the default. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 2f51881) Ported-From: opus/2f5188154935795b8c9d5bb053a0ecfc6503cd99 AC: AC-1 * fix(dolt): pull from the remote named as bd dolt pull's argument bd dolt pull dropped a positional remote the same way push did, so `bd dolt pull 1st` pulled from the default remote (GH#3720). Route the positional through the named-remote PullRemote / PullRemoteWithStrategy path and refuse an empty name before the store opens. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 7f01bed) Ported-From: opus/7f01bed50380fcd4267ff0f4e81b203b2b2c7c14 AC: AC-2 * fix(dolt): refuse a positional remote that differs from --remote `bd dolt push 1st --remote origin` would otherwise silently discard one of two selectors the user typed. Refuse it during cobra's Args validation, before the store opens, with an error that names both remotes; an equal pair is accepted. A second positional (git's <remote> <branch> habit) is refused by MaximumNArgs(1). AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0b506be) Ported-From: opus/0b506be188e0b49e1f89d435d8ef85c9980425a3 AC: AC-3 * test(dolt): pin --remote and default-remote push/pull behaviour Regression rows for the positional-remote change: with no positional, --remote <name> still targets that remote and a bare push/pull still takes the default-remote path; a positional equal to --remote is accepted. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit b1d3bca) Ported-From: opus/b1d3bcaa1bafbb75c296f397288efaaa8ef71d13 AC: AC-4 * docs(dolt): show the positional remote in push/pull usage and help Usage lines now read `bd dolt push [remote]` / `bd dolt pull [remote]` and the long help names both spellings (`bd dolt push <remote>` and `--remote <remote>`). Splice the two command-tree golden entries and add the CHANGELOG entry for GH#3720. AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit afbe20b) Ported-From: opus/afbe20b525547915dc81c6531bb96d14b33d8d3d AC: AC-5 --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com>
…nd main-saved caches, not the network (gastownhall#7820) * ci(pr): install windows-make-shell's Make toolchains without the network windows-make-shell (required through CI Gate / Required) installed all three of its Make toolchains from the network on every PR and merge group: choco install make (the Chocolatey feed returned 503 on Oct 19), setup-msys2 downloading MSYS2 plus git and make from MSYS2's mirrors ("Operation too slow"), cygwin-install-action, and a diagnostics step whose `go env` downloads a Go toolchain (the DNS failure on Oct 23). 28 failures in two weeks, 8 of the 12 merge-queue ejections in the week to Oct 24. Each leg now takes its toolchain from the image or from a cache only main.yml writes, and keeps the network as a bounded, retried fallback (scripts/ci/windows-make-shell/): - native: the image's MinGW-w64 mingw32-make.exe (GNU Make 4.4.1 for x86_64-w64-mingw32, system DLLs only), else Chocolatey's make 4.4.1 binary from the cache (SHA-256 pinned), else choco install (3 attempts of at most 120 s, 15 s and 30 s apart). The binary is copied to $RUNNER_TEMP/native-make as make.exe and put first on PATH. - MSYS2: the image's C:\msys64 (setup-msys2 release: false, no update, no install, cache off). msys2-packages.sh resolves git and make against the image's own sync database (never refreshed), downloads only what the restored package cache lacks (3 attempts of at most 120 s), and installs with pacman's signature check, which it requires pacman.conf to make mandatory. - Cygwin: an offline install by Cygwin's setup in local mode from a cached package tree (Authenticode-checked setup, the mirror's signed setup.zst, per-archive SHA-512), otherwise cygwin-install-action as before. Both Cygwin setup steps stay warning-only. main.yml's new windows-make-shell-toolchains job (push to main, same label and guard as the other savers) is the only writer. It looks each cache up, and on a miss seeds it with the same scripts and saves it only after the seed proved the content installs. Keys change with the pinned binary, the image's MSYS2 sync database and the UTC month, never per commit. The diagnostics step no longer runs go; it prints every GNU Make on the image, C:\msys64's packages and Cygwin roots, so the first run settles the image assumptions. Tests: ci_windows_make_shell_test.go pins the PR job, the saver's agreement with it, the scripts' verification and their retry budgets. TestPRWindowsMakeShellLegsFailTheJob now allows continue-on-error on both Cygwin setup steps (ids cygwin-cached and cygwin) instead of one; TestPRWindowsMakeShellSetupStepsHaveTimeouts covers the new install steps. Refs ga-ylpbsy.51.3. Agent-Signature: claude-agent-sdk-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(pr): harden the Cygwin cache tree check; fit windows-make-shell's step caps Review LOWs on gastownhall#7820. cygwin-offline.ps1's Get-SignedPackageTree only checked that setup.zst and setup.zst.sig existed. In local mode Cygwin's setup also skips an empty index file and reads setup.xz, setup.bz2 or setup.ini instead, installs from an index with no .sig file without verifying it, prefers <dir>\x86_64 over any mirror directory, and reads <dir>\setup.rc first, whose extrakeys entry adds keys it accepts index signatures from. The check now requires no files at the package root, exactly one mirror directory not named x86_64, and in its index directory no setup.* file but exactly one non-empty setup.zst and one non-empty setup.zst.sig, hidden files included. A rejected tree fails the offline install and the job falls back to cygwin-install-action, as before. TestCygwinOfflineLeavesSetupOnlyTheSignedIndex pins the check against setup's index names. The step caps summed past the job caps (pr.yml 34 min against 30, the main.yml saver 32 against 30), so a run where every fallback hit its cap would be cancelled before the later legs' exercises. Both jobs now have timeout-minutes 40, and the cache restores give up on a stalled download after one minute instead of two, so the uncapped steps fit in 5 minutes. TestWindowsMakeShellNetworkFallbacksAreBoundedAndRetried pins step caps plus 5 below the job cap for both jobs. Refs ga-ylpbsy.51.3. Agent-Signature: claude-agent-sdk-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(pr): seed the MSYS2 cache without --needed; hold choco make to its pin Review fixes for windows-make-shell: - msys2-packages.sh downloads without --needed. With it, pacman -Sw skips a target the image already has installed while pacman -Q, the seed's only proof, still passes, so main's saver could store an empty directory as the exact cache for that sync database. pacman already skips files the cache holds. Before the install, every file the transaction resolves to (pacman -Sp --print-format '%f') must be in the cache and not empty. - native-make.ps1's Chocolatey tier throws when the make.exe it installed is not the pinned SHA-256, before the copy check and the GITHUB_PATH update, as the cache tier and Seed already refuse one. It only warned. - Tests pin both, and that cygwin-offline.ps1's $Packages and the Cygwin cache key list the online setup's packages. - Two comments still gave the old 30-minute job timeout. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…gastownhall#7988) * fix(versioncontrolops): strip userinfo from BackupRestore error text A failed restore interpolated the raw backup URL, so aws://key:secret@... printed the secret to stderr (gastownhall#6341). Name the source through sanitizeURL; Dolt still receives the URL unchanged. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e6e334b) Ported-From: opus/e6e334bda16ce660d78b8895f4baff4d23fd7947 AC: AC-1 * test(versioncontrolops): pin signed-query redaction in BackupRestore errors The sanitizeURL operand from the previous commit also drops the query and fragment; these rows fail on the base, where the raw URL was interpolated. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 61bae95) Ported-From: opus/61bae95084a3f795ecf0f580583f78833eacdcd4 AC: AC-2 * test(versioncontrolops): pin that BackupRestore hands Dolt the verbatim URL Redaction is error-text only: the credentialed URL must still be the DOLT_BACKUP bind argument, and only one statement is issued. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 8eaada7) Ported-From: opus/8eaada762cf19aa1bae10cf8e236d41fe8086e43 AC: AC-3 * fix(versioncontrolops): fail closed on unparseable BackupRestore URLs sanitizeURL returns its input raw when net/url cannot parse it, which is exactly the titled AWS shape (a base64 secret holding '/') and a password holding '#' or '?'. backupRestoreSafeURL reduces those to scheme:[redacted] in the error text; parseable URLs still go through sanitizeURL. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f451e4a) Ported-From: opus/f451e4adfb1f9d552b5a5d352de4eb4846141fa1 AC: AC-4 * fix(versioncontrolops): withhold Dolt's error when the restore URL carries credentials Naming the restore source safely was not enough (gastownhall#6341): Dolt quotes the URL in its own errors, and BackupRestore wrapped them with %w. url.Parse's error repeats every URL the fail-closed branch redacts (parse "aws://AKIAUNP:wJal/K7MDUNP@bucket/db": invalid port ":wJal"), and the remotesapi factory prints a parseable one whole (could not access dolt url 'https://user:hunter2@...'). When the URL carries userinfo, a query or a fragment, or cannot be named safely, the error now leaves Dolt's text out (restoreErrorWithheld) and still unwraps to it. backupRestoreSafeURL also fails closed where net/url parses the URL but leaves an '@' outside the userinfo (a password holding '@' before '#', '?' or '/', a '/'-secret whose head parses as an empty or numeric port), and on opaque scheme:KEY:SECRET@host forms: those printed part of the secret as the host, port or path. A file URL without userinfo, DirToFileURL's form, is named as is with Dolt's error, so Windows' file://C:\... and paths holding '%', '#' or '?' keep their diagnostic. Dolt's aws://[bucket:table] form, which net/url rejects since Go 1.25.2, is parsed the way Dolt parses it instead of being redacted. Checked against dolt 2.6.0 through a sql-server: the AC-4, https-userinfo and ':/'-secret shapes no longer print a secret, errors.As still finds the *mysql.MySQLError, and credential-free https, aws and file URLs keep Dolt's message. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…astownhall#5981) (gastownhall#8053) * fix(schema): keep issues.updated_at across frozen migrations 0046/0047 0046 and 0047 recompute issues.is_blocked without assigning updated_at, so the column's ON UPDATE CURRENT_TIMESTAMP stamps every blocked issue with the migration's wall clock (gastownhall#5981). Their SQL is frozen, so the runner now snapshots (id, updated_at) for registered steps before the pre-repair and restores changed values after the body, before the cursor row and per-step commit. Unregistered steps issue no extra queries. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit b6dca0a) Ported-From: opus/b6dca0a50649e0446e0f6f7cca473bd095b6c6e5 AC: AC-1 * test(embeddeddolt): pin updated_at in 0047's own step commit AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 2373d20) Ported-From: opus/2373d20330b62bb0721cd94fdb7a434692f445ba AC: AC-2 * fix(schema): keep updated_at on rows moved by frozen migrations 0035/0053 0035 copies agent-class issues into wisps and 0053 copies rig wisps back into issues, then each flips the moved rows' ephemeral flag without assigning updated_at. Register both with their move source: a moved row takes its source's pre-step timestamp, a destination row INSERT IGNORE kept takes its own. Runner fakes that cannot answer the guard's queries stub it. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 8ea0123) Ported-From: opus/8ea01233a91fd3c3a681ac5977c4a98962e6c10e AC: AC-3 * fix(schema): keep wisps.updated_at across ignored migration 0007 Ignored 0007 clears and recomputes wisps.is_blocked without assigning updated_at. Register it: the guard restores stamped wisps before the ignored cursor row is recorded (that source has no per-step commit). AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f2eec8a) Ported-From: opus/f2eec8a548f36d8d4cf948644e398832471cb9b9 AC: AC-4 * test(schema): stub the updated_at guard in the ignored-0007 drift fake The ignored/0007 registration makes runMigrations snapshot wisps before the step; the drift fake answers only the is_blocked repair, so stub the guard as the other runner fakes do. AC: AC-4 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0c292a4) Ported-From: opus/0c292a44459327f156f6ffc55afc94f62708e808 AC: AC-4 * test(schema): pin that a failed updated_at guard stops its step An injected snapshot or restoration failure on main 0046 returns before the step's cursor row, DOLT_COMMIT or "done" line. AC: AC-5 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0313784) Ported-From: opus/0313784b24e2d9a23f5c365fd84a24d002e8152f AC: AC-5 * test(schema): pin that unregistered steps issue no updated_at guard queries Every unregistered version of both series gets a nil, query-free snapshot, and main 0048 runs only its body and cursor row. AC: AC-6 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 4c5087f) Ported-From: opus/4c5087ff95f3536fe1c2bc369268e1e37c4c9536 AC: AC-6 * test(schema): census every migration UPDATE of an auto-stamped table TestMigrationUpdatesOfAutoStampedTablesKeepUpdatedAt parses both shipped series (top-level SQL and PREPARE'd string literals) and requires every UPDATE of a table whose updated_at auto-stamps to assign updated_at or be covered by its step's updatedAtGuards restore target; registry entries must name a shipped step, an unsafe UPDATE and a real move source. Dropping main/47 or adding an unguarded UPDATE fails it. The migrations README records the self-assign rule and the closed registry. AC: AC-7 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 90142b2) Ported-From: opus/90142b2a34ada3a029e964602cb24b1d435e0f93 AC: AC-7 * test(embeddeddolt): pin updated_at auto-stamp definitions after guarded steps After a full upgrade through every guarded step, issues, wisps, routes and federation_peers still declare updated_at NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, and the clause still fires on an ordinary write. CHANGELOG names the protected versions and notes already-stamped values are not repaired. AC: AC-8 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit dc77cb4) Ported-From: opus/dc77cb47739f27265407334559f7d85805341378 AC: AC-8 * test(schema): pin the updated_at restore's place, skips and batching in the runner Main 0046's restore runs between a successful body and the cursor row on both the per-step-commit and the bounded (MigrateUpTo) path. Rows the body left alone get no restore statement, a compare-and-swap miss (another writer moved the row after the reread) does not fail the step, and restoreBatchSize+1 stamped rows split into one full and one single-row statement. Adapted from GLM's sqlmock cases to this guard's column probe, SELECT and UPDATE shapes, against the fixed batch constant. AC: AC-1 Derived-From: opus/b6dca0a50649e0446e0f6f7cca473bd095b6c6e5, glm/ec4420c260205f49142c2e4ef886f9eba84afb56 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(schema): pin 0035/0053 move lookup precedence and the moves' own effects At statement level, main 0035's restore takes a moved row's issues value, keeps a pre-existing wisps row's own value over a same-ID source value, and leaves rows the step created or deleted alone. The embedded 0035 and 0053 fixtures also check that the migration's own work still lands: the moved rows' ephemeral flag flipped and the moved source rows are gone. AC: AC-3 Derived-From: opus/8ea01233a91fd3c3a681ac5977c4a98962e6c10e, glm/e32c76f3c6773d8037c06389d110ff36a7971c0f Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(embeddeddolt): cover a wisp-to-wisp blocker in the ignored 0007 fixture The genuinely pending ignored-0007 fixture gains a wisp blocked by another wisp and that blocker: both keep their historical updated_at, the dependent ends up blocked and the blocker does not, next to the existing issue-blocked and free wisps. AC: AC-4 Derived-From: opus/f2eec8a548f36d8d4cf948644e398832471cb9b9, opus/0c292a44459327f156f6ffc55afc94f62708e808, glm/40457f26f04416388910a8b3f81daa0df0a9ddac Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(schema): pin that a failed post-body reread stops its step Adds the restore's reread failure to the guard-failure table: on main 0046 the injected error returns before the cursor row, DOLT_COMMIT or "done" line, as the snapshot and restore-write failures do. AC: AC-5 Derived-From: opus/0313784b24e2d9a23f5c365fd84a24d002e8152f, glm/53a49a4b5e334fd129ab5d391b24cedda55f19d8 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(schema): restore updated_at only on rows the frozen body rewrote Review fixes for the updated_at guard (gastownhall#5981): - Only the frozen body's own rewrites are undone. Each updatedAtGuards entry now names the one column its body assigns on the restore target (is_blocked for 0046, 0047 and ignored 0007; ephemeral for 0035 and 0053) and whether the body clears and recomputes it. The snapshot and the post-body read carry that column, so a row whose column shows the body left it alone keeps an updated_at another session gave it during the step instead of having it rolled back. A row the body did rewrite that another session edited before the post-body read still gets its pre-step value. The census now fails when a guarded step's UPDATE assigns anything but its registered column, and a two-session embedded test edits an untouched issue while 0047 runs. - The restore selects each batch with `id IN (...)` and a per-row CASE compare-and-swap instead of an OR of `(id = ? AND updated_at = ?)` terms. On Dolt 2.6.0 the OR form plans as a full table scan (8.1 s per 500-row batch on a 20k-row table); the IN form is an IndexedTableAccess on the primary key (0.4 s). - Regenerate .github/scripts/embedded-storage-test-shards.txt for the new TestEmbedded* tests, so TestStorageEmbeddedShardManifestGeneratorNotStale passes again. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(dolt): pin the updated_at guard on the sql-server driver path (gastownhall#5981) The guard reads timestamps and writes them back through whatever driver the migration connection uses. The embedded tests cover dolthub/driver, where the restore's timestamps reach the engine as typed bind values. A sql-server connection goes through go-sql-driver/mysql with ParseTime and InterpolateParams, so the snapshot scans DATETIME text into time.Time and the restore and its compare-and-swap reach the server as string literals. A compare-and-swap miss is deliberately not an error, so a coercion regression on that path would silently disable the restore in server mode while every embedded test stayed green. TestServerMigrate0046And0047KeepIssueUpdatedAt migrates a v45 store with open and closed blockers and a parent-child edge to the latest version over a ServerDSN connection and checks every issue's updated_at and is_blocked in the working set and AS OF HEAD. It fails without the guard (srv-blocked and srv-child take the migration's wall clock). Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(dolt): let independently upgraded clones merge without pinning updated_at (gastownhall#5981) TestCrossUpgradeBoundaryMerge forks two clones from a v0040 ancestor, upgrades each to HEAD and merges them. It pinned issues.updated_at to a constant after each upgrade because 0046/0047's is_blocked recompute stamped the blocked ancestor issue with each clone's own migration wall clock, and the merge then conflicted on that cell (bd-578h9.19). With the runner's updated_at guard both upgrades leave that row's updated_at at the ancestor's value, so the pin is dropped and the "synced clones" case now asserts it: anc-x is blocked after the upgrades and the merged row still holds the ancestor's updated_at. Without the guard the merge reports a conflict again. Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(embeddeddolt): restore updated_at across full-size batches on the real engine (gastownhall#5981) The sqlmock runner test pins how stamped rows split into 500-row restore statements, and the embedded fixtures stamp a handful of rows, so no test ran a full-size batch (1000 CASE arguments, 500 IN entries, 1000 compare arguments) through the engine. TestEmbeddedMigrateGuardRestoresAcrossBatches seeds a v46 store with 1001 issues blocked by one open blocker, two thirds already flagged blocked and the rest flagged for the first time, stops right after 0047 and checks every row's updated_at and is_blocked in the working set and in the step's commit. Regenerates the embedded storage shard manifest for the new test. Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(schema): restore updated_at on rows frozen migrations stamp through joins (gastownhall#5981) go-mysql-server, unlike MySQL, applies the ON UPDATE CURRENT_TIMESTAMP of every table a multi-table UPDATE joins, and writes the joined row back even when the statement assigns none of its columns. Frozen migration 0041's dependency split (`UPDATE dependencies d JOIN issues i ON ... SET d.depends_on_issue_id = ...`, and the same against wisps) therefore stamps every issue and wisp a dependency points at: blockers, parent epics, related targets. On a v40 store with 5000 issues chained by dependencies, 0041 stamped 4999 of them. The guard did not cover it, and the census only looked at assigned columns, so it passed. TestCrossUpgradeBoundaryMerge exposed it once its updated_at pin was dropped: anc-y (anc-x's dependency target) was stamped on each clone and the merge conflicted in CI. - updatedAtGuardSpec gains joinStamped: the auto-stamped tables a step's UPDATEs join without assigning. The snapshot reads a fingerprint (MD5 of JSON_ARRAY of every other column, the column list fixed at snapshot time) for those tables. After the body, a row whose fingerprint is unchanged but whose updated_at moved was stamped by the join and gets its pre-step value back. A row whose other columns changed was edited by another writer and keeps its time, the same principle as the flag rule. If the step drops a fingerprinted column, the join rule is off for that table. - Registry: main 0041 (issues, wisps), 0047 (its legacy wisp_dependencies split joins issues and wisps), 0053 (its child_counters UPDATE joins the rig wisps it then deletes), ignored 0003 (issues, wisps) and ignored 0011 (wisps). - The split-target pre-repair that runs before 0047 and 0053 is Go, not frozen SQL, so it now tests a target with `IN (SELECT id FROM ...)` instead of joining wisps or issues, and stamps nothing. - The census records every table an UPDATE references. It fails on an auto-stamped table that is joined but neither assigned `alias.updated_at = alias.updated_at` nor listed as joinStamped, and on a joinStamped entry whose step never joins that table. - README and CHANGELOG describe the join rule and the added steps. Tests: TestUpdatedAtGuardRestoresJoinStampedRowsOnly (sqlmock: the join rule, another writer's edit kept, the dropped-column cutoff), new census subtests, and TestWispDependenciesSplitTargetBackfillLeavesTargetsUpdatedAtThroughDoltCLI, which fails with the old JOIN form. Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(storage): pin updated_at through 0041's and ignored 0011's joins (gastownhall#5981) - TestEmbeddedMigrate0041KeepsDependencyTargetsUpdatedAt: a v40 store with a blocks edge, a parent-child edge, a related edge to a wisp and an external edge keeps every issue's and the wisp target's updated_at through 0041 (working set and step commit) and through the rest of the upgrade. The split itself lands and the blocked issue is flagged. Without the join rule, the target, the parent epic and the wisp target take the migration's wall clock. - TestEmbeddedMigrateIgnored0011KeepsUpdatedAt: a wisp with a leftover child_counters row keeps its updated_at through ignored 0011, whose wisp_child_counters UPDATE joins wisps. The counters still fold. - TestCrossUpgradeBoundaryMerge's synced-clones case asserts that all three ancestor issues keep the ancestor's updated_at after both clones upgrade and merge. Before, it checked only the blocked one. anc-y, the edge's target, is the row 0041 stamped. Without the join rule the merge conflicts again, locally as it did in CI. - Regenerates the embedded storage shard manifest for the two new tests. Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(schema): fingerprint join-stamped rows per column so out-of-band TEXT reads (gastownhall#5981) The join rule's fingerprint was MD5(JSON_ARRAY(<every other column>)). On stores that historical releases wrote, a TEXT value is stored out of band, and it reaches SQL functions as Dolt's *val.TextStorage, which JSON_ARRAY rejects. Upgrading such a store therefore failed at 0041's snapshot ("reading issues.updated_at: Error 1105: unsupported type: *val.TextStorage"). CI's historical_upgrade_v0_63_3, v1_0_0 and v1_0_1 tests failed this way on 31f5c84. Casting the column to CHAR inside JSON_ARRAY fails the same way. The fingerprint is now MD5 over each column's MD5 of CAST(col AS CHAR), with '-' for NULL, joined by commas. That reads TextStorage, still keeps NULL apart from the empty string, and keeps every column apart from its neighbors. TestEmbeddedMigrate0041KeepsDependencyTargetsUpdatedAt now gives the dependency targets ~60 KiB TEXT values, which are stored out of band. With the JSON_ARRAY form it fails with the same TextStorage error. The sqlmock test builds its expected SELECT from fingerprintSQL. Locally, scripts/migration-test/historical-dolt-upgrade-test.sh --version v1.0.0 and --version v0.63.3 fail against a candidate built with the JSON_ARRAY form and pass with this one. Refs bd-chqckf. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…rgv (gastownhall#7881) * fix(security): stop option injection via sync remotes and beads-mcp argv A committed .beads/config.yaml could set sync.remote (or sync.git-remote) to "--upload-pack=<cmd>", which bd bootstrap / bd init passed straight to `git ls-remote`, running the command. bd now rejects remote values that start with "-" (naming the config key) and passes git remote operands after "--" in the ls-remote probe and the reset-data ls-remote/push. beads-mcp built bd argv with caller text (titles, comment text, ids) as bare positionals, so a comment like "--file=~/.ssh/id_rsa" became a bd flag. Flag values now use the single-token --flag=value form and caller-supplied operands follow "--". Agent-Signature: devin-unknown-model-unknown-reasoning on behalf of Wenjix * fix(security): refuse option-shaped remotes before init writes and keep local bootstrap recovery Agent-Signature: devin-unknown-model-unknown-reasoning on behalf of Wenjix * docs: limit CLI reference change to the bootstrap remote note Agent-Signature: devin-unknown-model-unknown-reasoning on behalf of Wenjix * docs: drop generated and hand-written copies of unreleased remote note The docs track docs/cli-docs.pin; the note lives in bootstrapCmd.Long and reaches the reference when the pin advances. Agent-Signature: devin-unknown-model-unknown-reasoning on behalf of Wenjix * docs(sync): note the sync.remote option-value restriction Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): reject option-shaped sync remotes after git+ prefix Also add single-dash (-u) test cases and pin the non-proxied bd init refusal before filesystem writes. Agent-Signature: antigravity-unknown-model-unknown-reasoning on behalf of Wenjie Fu * test(security): move forge sync-remote helpers to the pure-Go file init_proxied_server_test.go is untagged but called newForgeSyncRemoteWorkspace, which lived in the cgo-tagged bootstrap_guard_test.go, breaking pure-Go and Windows test builds. Move the helper and its dependencies (setupSyncRemoteConfig, snapshotBootstrapEnv) to test_helpers_pure_test.go; they only need stdlib and internal/config. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * test(cli): regenerate command tree golden for bootstrap help The option-injection note stayed in bd bootstrap's long help when the docs copies were dropped, leaving the generated golden out of sync with the live command tree. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): guard reset-data's server-mode git calls against option remotes Rebase adaptation. main's gastownhall#7902 (c153e3b) added a server-mode reset-data path (resetGitBackedThroughServer) that reaches the git remote through lsRemoteRefOID, deleteTempGitRef and moveGitRef, each passing the remote URL as a bare positional. That is the same option-injection class this PR closes for lsRemoteDoltDataRefs / deleteGitDoltDataRefs, so apply the same two layers: refuse a remote starting with '-' and pass it after "--". TestResetDataGitCommandsRejectOptionRemote now covers the three helpers; with the lsRemoteRefOID guard removed it fails ("an injected git option ran a command"). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(mcp): expect --defer= for a cleared defer in the single-token argv form Rebase adaptation. main's test_update_defer_until (landed after this PR's base) asserted the two-token --defer "" argv; this PR builds every flag as a single --flag=value token, so a cleared defer is --defer= (pflag sets the empty string and marks the flag Changed, which is what bd update reads). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(security): refuse ssh remotes whose user or host ssh reads as an option The option check this PR adds looks only at the first character of the remote URL, and at the first character after git+. An ssh:// URL whose user name or host starts with "-" passes it, and Dolt's native ssh:// transport (dbfactory buildTransferCommand) runs ssh [-p port] [user@]host "<dolt> --data-dir <path> transfer" with nothing that ends ssh's options before the destination. A committed sync.remote: ssh://-oProxyCommand=<command>@host/path (also with the user %2D-encoded, which Dolt decodes, or as the host, ssh://-oProxyCommand=<command>/path) is not a forge URL, so bd bootstrap plans a clone from it, and bd init, whose git probe of it fails ("strange hostname blocked") and is then treated as remote history, clones it too. The embedded DOLT_CLONE runs in bd's own process and execs `ssh -oProxyCommand=<command>@host ...`. OpenSSH 9.6, and distro builds that carry the CVE-2023-51385 backport, refuse it only because Dolt's remote command lands in the destination slot and contains spaces; an unpatched OpenSSH (checked with 8.3p1) runs the command. The same URL reaches Dolt from routing.default/maintainer/contributor (bd create -> remotecache.Ensure -> dolt clone), repos.additional (bd repo sync) and federation.remote (bd config apply -> DOLT_REMOTE add, which every later push, pull and auto-push dials). remotecache.OptionShapedPart now names the part of a remote URL a program would read as an option: the URL itself starting with "-" (also after git+), or the user name (percent-decoded, as Dolt reads it) or host of an ssh:// or git+ssh:// URL starting with "-". checkRemoteNotOption (sync.remote, sync.git-remote, reset-data) and remotecache.ValidateRemoteURL (dolt CLI clone, remote cache, CLI remote mirror) both use it, and bd config apply checks federation.remote before it opens the store. No usable remote has such a part: a DNS host name never starts with "-", and OpenSSH refuses a user name that does. The new ssh rows in TestResolveSyncRemoteCheckedRejectsOptionValue, TestDetectBootstrapAction_OptionSyncRemoteBlocksWithoutProbe, TestInitCommandRejectsOptionSyncRemoteBeforeWrites, TestRunInitProxiedServerRejectsOptionSyncRemoteBeforeWrites, and the new TestApplyRemoteRefusesOptionShapedFederationRemote, TestValidateRemoteURL rows, TestEnsureRefusesOptionShapedSSHRemote and TestOptionShapedPart all fail against the leading-dash-only check and pass with this one. Agent-Signature: claude-agent-sdk-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(sync): name the ssh user and host restriction on sync.remote bd now also refuses an ssh:// sync.remote whose user name or host starts with "-", which Dolt's ssh transport would hand to ssh as an option. Agent-Signature: claude-agent-sdk-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…wnhall#7885) * fix(security): harden proxy and server startup on shared hosts Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): serialize managed proxy snapshot startup Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * docs(doltserver): keep log level rationale Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * docs(dbproxy): document the BDPROXY1 handshake upgrade requirement A proxy started before this handshake existed rejects the BDPROXY1 line, and it holds proxy.lock, so a mixed-version pair needs the old proxy stopped before the managed proxy restarts. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): verify proxy data port before auth and stop pre-MAC proxies on upgrade - Bind data-port HMAC to the target port via identity.DataAuthTokenForPort and verify pidfile.Read(rootDir, PIDFileName).Port == port in dialData before dialing or sending the token so a caller cannot send a valid MAC to an unverified port. - Export RegisterDataAddress and update cmd/bd proxied test helpers to register the proxy workspace before opening connections. - Defer p.activeConns.Add(1) until after data-port authentication succeeds so unauthenticated connections cannot block idle shutdown. - Stop verified pre-MAC proxies holding proxy.lock on upgrade when discovery fails with identity.ErrIdentRefused. - Pin IdentRequestMAC wire format and stub groupHasNoOtherPrimaryMembersFn in TestIsUserPrivateGroupNameComparisonExercisedDirectly. Agent-Signature: antigravity-unknown-model-unknown-reasoning on behalf of Wenjie Fu * fix(dbproxy): verify data port at registration, not on every pool dial GetCreateDatabaseProxyServerEndpoint registers a data address only after readAndDial has verified the proxy pidfile, process identity, and IDENT response, so the extra proxy.pid re-read inside dialData adds nothing — and it races normal shutdown, where the proxy removes proxy.pid first and a pooled dial in flight then fails with a permanent "stale data address". Keep the port-bound HMAC handshake as the per-connection check: a stale registration can only hand a token for its own port to whatever listens there, and the registration is refreshed on every endpoint lookup. Also register the managed-local test helper against p.proxyRoot, where the pidfile actually lives, instead of p.beadsDir. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(dbproxy): gate pre-MAC stop on a pidfile marker, parameterize DSN network A silent IDENT refusal is not proof of a pre-upgrade proxy: a current proxy's control handler also drops a probe silently when its ident slots are full or the read deadline trips, and killing it on that evidence would replace a healthy process. Proxies now publish control_proto=1 in proxy.pid, and the stop dispatch only fires when the record lacks the marker — a marked proxy that refuses a probe falls back to the bounded poll instead of a kill. Also thread the MySQL dial network through openAndInitSchema and buildDSN: production callers keep proxy.DataNetwork (the BDPROXY1 handshake), while tests that reach a bare dolt sql-server pass "tcp", fixing the version-floor test's direct connection. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * test(dbproxy): pin that unauthenticated data connections stay inactive A connection parked in the BDPROXY1 handshake read must not increment activeConns, or any unauthenticated client holding the port open would gate the idle watcher forever. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * test(proxied): match backend argv on proxy-root launch configs Since 0bcd3fa the managed backend runs dolt sql-server --config <proxyRoot>/proxy-child.launch-config.yaml, so the operator config path no longer appears in its argv and managedProcessPIDs counted zero backends. Match the launch config and the port-recovery runtime config under the proxy root alongside the operator path. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(dbproxy): keep the root lock across a proven-foreign port retry Rebase adaptation, NOT mechanical. This PR holds the proxy root lock across Start's port-recovery attempts and lets the supervising goroutine keep it only when the child reported its port taken (watch.SawPortInUse). main's gastownhall#8037 (027635c), which landed after this PR's base, added a second ErrPortInUse source: waitReady returns it when the dial reached a listener ownsListener proves is another process's (foreign, or unlisted on a provable host), which the child never reports. On that path the goroutine released the lock, startWithPortRecovery retried with the released lock, and the next release panicked ("util: failed to release lock: bad file descriptor") - main's TestDoltServer_Start_QuietLogLevelMovesOffUnlistedListener crashed the dbproxy/server test binary. It also dropped the serialization between attempts that this PR adds. The goroutine and the waitReady error path now decide under one mutex: an attempt ending in ErrPortInUse with recovery pending keeps the lock, and the lock is released exactly once. If the child exited and released the lock before the conflict was proven, Start returns the error without ErrPortInUse rather than retrying without the lock. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dbproxy): make the proxy prove its secret on every data connection BDPROXY1 authenticated only the client. dialData sent its token to the registered address and handed the connection straight to the MySQL driver, on the reasoning that a token minted for that port is useless to whatever else listens there. The token is; the session is not. A registration outlives its proxy (bd serve never re-resolves its endpoint), the proxy can exit (idle timeout, crash, its backend exiting, bd dolt stop, an upgrade stopping a pre-MAC proxy), and any local user can then bind the freed port and receive, and answer, every query and write that client sends. The proxy now answers a valid hello with a proof, an HMAC under the proxy secret over a label, its port and the client's nonce, before anything else, and dialData returns the connection only when the proof checks out. A listener that stays silent, hangs up, answers garbage or a MySQL greeting, or replays an answer from an earlier connection receives the hello and nothing more. The proof goes out before the backend dial, so upstream-outage reports still reach the driver as the greeting. The client's wait is bounded by its dial context (at most 5s) and ends at once on cancellation. BDPROXY1 has not shipped, so its wire format changes without a version bump. TestDialDataRequiresTheProxysProof fails against the one-way exchange (every impostor case connects); TestDataServerProof pins the wire format with a fixed vector, and server_test.go's dialProxy spells the exchange out independently of the package's helpers. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(dbproxy): give Start's root lock one owner while a start settles 5b2630e decided whether to keep the root lock for a port-conflict retry in two places: the supervising goroutine kept it whenever the child had said its port was taken, and waitReady's error path claimed it for a retry. When the child had said so but the start then ended some other way (its context canceled, as a stop that begins mid-boot does, or the readiness deadline passing as the child exits), neither released it: Start returned without retrying, its cleanup could not take the lock to remove the launch snapshot and runtime config, and the lock stayed held for the life of the process. After a successful start the goroutine still consulted the port-in-use scan, which never stops at warning level. The lock now has one owner at a time. Until waitReady settles, the attempt owns it whenever the child exits: it releases it, or keeps it for the next attempt when Start retries an ErrPortInUse. Once the server is ready, the goroutine owns it and releases it when the child exits. A conflict proven after the child already exited now retries under the lock too, instead of ending Start. TestDoltServer_Start_CanceledDuringPortConflictReleasesLock fails before this change ("Start returned without releasing proxy-child.lock"). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(doltserver): refuse another user's listener at server-mode startup on macOS Finding 19 is startup accepting another user's listener as its own dolt. This PR keeps Linux and macOS on the warning log level and the PID/owner check, but server mode's listenerOwnership counted an unlisted listener as unknown, and at warning level an unknown owner lets the greeting decide. darwin's lsof cannot see another user's socket without privilege, so on macOS another account's listener on the port server mode picked was reported unlisted and its greeting accepted, and every server-mode connection then went to that listener. Count it as the proxied launcher already does (gastownhall#8037): an unlisted listener is another process's where ListenerOwnershipProvable shows the host lists this user's own listeners. Where the host lists no sockets at all (WSL1, some sandboxes) it stays unknown, as before. TestAwaitOwnedListener_UnlistedListenerOnProvableHostIsForeign accepts the foreign greeting without this change; the Linux and darwin ownership tables now cover both provability cases. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(changelog): note the shared-host proxy hardening and its upgrade path Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…tion guard (gastownhall#8080) The updated_at guard (gastownhall#8053) probed every snapshot and restore table through INFORMATION_SCHEMA.COLUMNS: an updated_at count, a flag count and, on a joinStamped table, an ordered column listing. Dolt does not push that predicate down, so each probe walks every database on the server, and the guard runs them all while holding the schema migration lock. Each table is now read once per snapshot or restore with SHOW TABLES and, when present, SHOW COLUMNS; updated_at, the step's flag and the fingerprint columns all come from that one listing. The existence check first keeps a missing table (a clone without wisps) from sending a failing SHOW COLUMNS, which would pin the pooled session (be-bv7x), and reads it as absent as the old count did. Names compare case-insensitively. The per-column MD5 fingerprint is unchanged: the same columns in table order, minus updated_at. A full upgrade of a v30 store on a scratch Dolt 2.6.0 server with 50 populated databases (30 tables each) went from 200 s to 137 s: 51 fewer INFORMATION_SCHEMA.COLUMNS probes, and the guard's snapshots from 31 s to 0.08 s. The remaining 70 probes belong to the older pre-migration repairs. TestUpdatedAtGuardProbesColumnsWithoutInformationSchema runs every registered step's snapshot and restore and fails on any INFORMATION_SCHEMA statement. Agent-Signature: claude-agent-sdk-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…all#7887) * fix(security): pin shared credential endpoints on first use Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(dolt): check the metadata socket without changing the dialed transport Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): allow private endpoint use without pin writes Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): serialize endpoint trust pins across processes Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): trust Dolt TCP fallback with sockets Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): resolve AI key before endpoint trust Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * docs(security): document endpoint trust APIs Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * test(security): align Dolt socket trust expectations Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): pin default endpoints, scope pins by path, and harden private-source checks - Normalize endpoint origins with scheme, host, port, and cleaned path so path-scoped pins (e.g. the Linear /graphql default) cannot be bypassed by pointing the same host at another path. - Pin vendor default endpoints and bd's local loopback Dolt server on first use, so a later shared-config change is a pin mismatch that requires private confirmation instead of a silent first-use pin. - Keep .beads/config.local.yaml, .beads/.env values, and synced database values on the project side: add MarkDotenvValue/IsDotenvKey/PrivateGetenv, PrivateConfigValue, RecordWorkspaceBeadsDir, and ProjectConfigFileUsed; a workspace .beads that doubles as the legacy ~/.beads user config stays project-controlled. - Reject Dolt unix sockets owned by another uid, and honor APPDATA / XDG_CONFIG_HOME / $HOME/.config when locating trusted-endpoints.json. - Key pins to the workspace discovered before .env could redirect BEADS_DIR, so a committed .env cannot re-key pins to a fresh entry. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * fix(security): refuse unconfirmed shared endpoints on first use A fresh workspace carrying a committed custom endpoint had no pin, so the gate silently pinned whatever shared config pointed at and sent the credential — the exact gastownhall#7886 scenario. First use of a shared endpoint now returns a FirstUseError naming the confirming env var and user config key; a private source (env or user-level config) still pins silently. - endpointtrust.Check: replace pin-on-first-use with FirstUseError for unconfirmed shared endpoints; default/loopback origins still pin. - Tests: confirm shared endpoints privately via the matching env var in the ADO/Linear round-trips (the six CI failures), jira/ado/github/ frontdoor/gateway/haiku fixtures, and rework endpointtrust tests to pin through a private source; new TestCheckSharedFirstUseRefusesUntilPrivatelyConfirmed pins the refusal. - config_test: add a key defined only in .beads/config.local.yaml so a regression dropping localConfigPath from project paths is caught. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * docs(config): describe private-confirmation pinning for shared endpoints The first-use text predated the FirstUseError change: shared custom endpoints are refused until privately confirmed now; only the vendor default and bd's local Dolt server pin on first use. Agent-Signature: Devin-unknown-model-unknown-reasoning on behalf of Devin AI * test: pass nil aiOptions at main's reportFindDuplicates test callers Rebase adaptation. This PR adds an aiOptions parameter to reportFindDuplicates so the endpoint-trusted AI client options flow through; main's remedy-printing tests (remedy_printing_test.go, remedy_store_hint_pure_test.go) landed after the PR's base and call it with the old signature on the mechanical path, which never reads the options. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(linear): confirm the endpoint privately in main's overlap-sync test Rebase adaptation. TestLinearSyncOverlapKeepsEchoOfNameMappedStatus landed on main in gastownhall#8005, after this PR's base. It puts linear.api_endpoint in store config, which this PR treats as shared configuration, so Init now refuses with "cannot determine workspace". Give it the same setup the PR gave the six round-trip tests: setupEndpointTrustWorkspaceForTest plus a private LINEAR_API_ENDPOINT confirmation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(github): confirm the endpoint privately in main's renamed-repository Init test Rebase adaptation. TestInit_ResolvesRenamedRepositoryName landed on main in gastownhall#8068 (0e7b758), after this PR's base. It puts github.url in store config, which this PR treats as shared configuration, so Init refused with "cannot determine workspace". Give each subtest a workspace and isolated HOME/XDG for the pin and a private GITHUB_API_URL confirmation. The gate still runs before gastownhall#8068's resolveRepositoryNames requests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(security): close endpoint-pin gaps — private pin store and Dolt diagnostics Review fixes for PR gastownhall#7887 (automated Opus 5.5 max review). Two gaps let the credential redirection the PR fixes still happen: - The pin store's own location honored a committed .beads/.env. gotenv.Load imports every .env key into the process environment, and endpointtrust.pinsPath read XDG_CONFIG_HOME / APPDATA / HOME through os.Getenv, so a repository could set XDG_CONFIG_HOME into itself, relocate trusted-endpoints.json under its own control, and — where the checkout path is predictable, e.g. CI and agents — commit a pins file that pre-authorizes its own endpoints. pinsPath now resolves the location through config.PrivateGetenv, which ignores .env values, the same way WorkspaceKey already refuses a .env BEADS_DIR. - BEADS_DOLT_PASSWORD was still sent without a pin check on the paths that build their own Dolt connection outside the store's gated open: bd dolt status, bd dolt clean-databases, and the bd doctor checks and bd doctor --fix repairs. gastownhall#7874 routed these through one endpoint resolver, but the PR's gate lives in applyResolvedConfig, which they bypass (dolt.New and raw DSN builders). Added doltserver.Endpoint.EnsureTrustedForCredential and a central gate in dolt.New — every store open funnels through New, so this covers bd doctor's federation/validation/maintenance/migration opens — and gated the raw-DSN builders (bd dolt status, bd dolt clean-databases, doctor openDoltDB / checkDoltVersion / Fresh Clone / openWorkspaceDB / openServerCatalogDB). Each is a no-op for bd's own local server and the vendor default; it refuses a shared-config host (metadata.json dolt_server_host / config.yaml dolt.host) the workspace never pinned. Tests: the pin store ignores a dotenv XDG_CONFIG_HOME (TestPinsPathIgnoresDotenvConfigHome); doltserver CheckEndpointTrust / EnsureTrustedForCredential refuse an unpinned shared host and accept a private confirmation (TestCheckEndpointTrustGatesTheServerPasswordSend); dolt.New refuses an unpinned remote endpoint when a password would be sent (TestNewRefusesUnpinnedRemoteEndpointWithPassword); bd doctor --fix openFixDB / openScanDB refuse the same (TestOpenFixDBRefusesUnpinnedRemoteEndpointWithPassword). Co-Authored-By: Wenjix <wenjiefu8@gmail.com> Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(security): refuse Dolt hosts that smuggle a second dial target into the DSN Review fix for PR gastownhall#7887 (automated Opus 5.5 max review), found while re-reviewing bacae68. The Dolt trust check classified the host by re-parsing a synthesized mysql://host:port URL, while the dial goes through go-sql-driver's DSN grammar (user:pass@net(addr)/db), whose FormatDSN does not escape the address. A committed metadata.json dolt_server_host of "localhost#@tcp(evil.example" therefore read as "localhost" for the trust check (bd's own server: trusted, no pin needed) while ParseDSN, which splits user:pass at the last '@' before the final '/', dialed evil.example:3306 with the password embedded. "127.0.0.1/x@tcp(evil.example" did the same, as does a socket path carrying '@', '(' or ')'. This bypassed the Dolt pin on every gated path, including the diagnostic gates added in bacae68, since they share CheckEndpointTrust. CheckEndpointTrust, the only producer of dolt-server endpoints, now refuses a host outside the host-name / IP-literal character set (IPv6 zones included: netip does not validate zone text, so the charset covers the whole host and anything with ':' or '%' must parse as an IP), and a socket path holding the DSN delimiters, before any credential is sent. Legitimate hosts (127.0.0.1, localhost, ::1, [::1], 0.0.0.0, DNS names with '_', IPv6 literals and zoned link-local addresses) are unaffected. TestCheckEndpointTrustRefusesDSNSmuggledHost asserts each smuggled value really places a second @tcp(evil.example:3306) in the DSN and is refused, covers the socket and zone variants, and checks valid spellings still pass; disabling the guard fails it. Co-Authored-By: Wenjix <wenjiefu8@gmail.com> Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…a or the 0062 merge diagnosis (gastownhall#8092) v1.3.3 (hotfix line) ships gastownhall#8068, gastownhall#8046 and the git-checkout part of gastownhall#7902, so the docs' "after v1.3.2" statements for those stay true. It does not ship gastownhall#8047 (events restore), gastownhall#7902's server-mode reset-data rework or gastownhall#8049 (0062 merge diagnosis), so the pages that promised those "after v1.3.2" now say v1.4.0 and later, and their "v1.3.2 or earlier" workarounds now cover v1.3.3 as well. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gastownhall#8110) * perf(bazel): ask rbe-cache for zstd in the committed fork-cache config Contributors using --config=fork-cache (.bazelrc.local, make BAZEL_FLAGS) never asked rbe-cache for compressed transfers: only setup-bazel's generated rc added --remote_cache_compression, behind cache-zstd-probe.sh. On 2026-11-03 every rbe-cache read was identity, about 0.5 TB that day, mostly Go archives that zstd-3 shrinks to 0.16. Move the flag into .bazelrc's fork-cache config so contributors and fork CI both get it, and drop the probe-gated echo from write-bazelrc.sh. The flag is transport only (keyNeutralFlag), so fork actions still hash like trusted CI's. If rbe-cache ever stops advertising zstd, Bazel refuses the remote and fork-cache's fallback flags build locally, as when the endpoint is closed; revert the line then. Policy tests now require the flag in fork-cache and allow it nowhere else. cache-zstd-probe.sh stays as an operator check (byte copy of gascity's) with its header and verdicts updated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * ci(bazel): warn when rbe-cache stops advertising zstd; widen the zstd scan Review follow-ups to the fork-cache zstd change: - write-bazelrc.sh runs cache-zstd-probe.sh again, as a diagnostic in every fork-cache job. .bazelrc's fork-cache now asks for zstd, so if rbe-cache stops advertising it Bazel refuses the remote and builds locally: the job prints a ::warning:: saying so and gets no remote repo contents cache lines (they would only cost lookups). It never fails the job. - TestBazelRemoteCacheCompressionOnlyForkCache also scans .githooks/, scripts/pre-push-suite.sh, tools/rbe/ and the Makefile. - .bazelrc: the identity-read figure is contributors' reads. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
v1.3.3 shipped from hotfix/1.3.1 (the promotion of v1.3.3-rc.1). Bring main's version files, release history and docs pin in line with the newest tag: - ./scripts/update-versions.sh 1.3.3 (main read 1.3.2); check-versions.sh passes. integrations/beads-mcp/uv.lock changes only the beads-mcp version line; uv lock --check passes. - CHANGELOG: the [1.3.3] and [1.3.3-rc.1] sections, byte-identical to the v1.3.3 tag, inserted between [Unreleased] and [1.3.2]. The region from [1.3.3] down to the [1.3.2] heading matches the tag. - cmd/bd/info.go: versionChanges entries for 1.3.3 and 1.3.3-rc.1, the region 1.3.3 -> 1.3.2 identical to v1.3.3:cmd/bd/info.go. - docs/cli-docs.pin v1.3.2 -> v1.3.3, generate-cli-docs.sh regenerated (--check passes). The docs/index.md release line names 1.3.3 and scopes the recompute-blocked note as the v1.3.3 CHANGELOG does. Every code fix in v1.3.2..v1.3.3 is a cherry-pick or backport of a commit already on main. The joserfc 1.7.7 lockfile bump (4f6b8c4) has no main counterpart: main's beads-mcp lock still pins joserfc 1.7.4, which a follow-up must bump. Agent-Signature: claude-agent-sdk-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
GHSA-9pg5-8c7x-5hfx (gastownhall#8115) main's beads-mcp lock still resolved joserfc 1.7.4 (pulled in by authlib and fastmcp's server extra), which OSV flags for GHSA-jpxq-7h8p-2q76 (fixed in 1.7.5) and GHSA-9pg5-8c7x-5hfx (fixed in 1.7.6). v1.3.3 fixed this on the hotfix line (4f6b8c4); the v1.3.3 forward-port (gastownhall#8114) found main never got it. `uv lock --upgrade-package joserfc` (uv 0.13.6, lock revision 5 as on main) resolves 1.7.7 for Python 3.10 and 1.8.0 for Python >= 3.11. No other package moved. osv-scanner on the lock: 3 advisories -> 1 (the dnspython 2.8.0 / Python 3.10 one, which has no fix). make ci-package-mcp: ruff and mypy clean, 258 passed, 5 skipped, sdist and wheel build. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* fix(env): allow GT_ROOT in a project .beads/.env `gc rig add` records the city root as GT_ROOT in each rig's .beads/.env so bd run inside a rig finds the city's formulas and molecules. The .env allowlist from gastownhall#7879 admits only BEADS_*/BD_* (minus command and credential-redirect keys) and the Dolt remote credential pair, so it dropped GT_ROOT: every bd command in a rig warned `beads: ignoring GT_ROOT from .beads/.env` (twice), and bd run there without GT_ROOT exported lost $GT_ROOT/.beads/formulas and the town molecules file. gc's own agent sessions export GT_ROOT, so they only saw the warning. GT_ROOT is now admitted via AllowedOrchestratorEnvKeys. bd only reads from it: $GT_ROOT/.beads/formulas is the LAST formula search path (after the repo's .beads/formulas, the checkout and ~/.beads), $GT_ROOT/.beads/ molecules.jsonl is template data, and two diagnostics print it. It names no command and no credential target, and a repository can already ship formulas in its own .beads/formulas, so a committed .env gains nothing. The refusal message now lists GT_ROOT. TestLoadBeadsEnvFileAdmitsGTRoot pins import (any case), no warning, and shell precedence; it fails without the change. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(env): state GT_ROOT's full reach and pin that only the exact key is admitted From the Opus 5.5 max review of gastownhall#8117 (minor items, no code change to the filter): - AllowedOrchestratorEnvKeys' comment now covers what a committed value can reach: bd's own reads (last formula path; the town molecules catalog loads first, so a town template wins over a same-ID ~/.beads template; diagnostics), inheritance by child processes (git/dolt/ssh/gh ignore it; gt consults it only after its working-directory walk and GT_TOWN_ROOT), and that only the selected workspace's .env is read. - TestLoadBeadsEnvFileRejectsCommands also refuses GT_TOWN_ROOT and GT_ROOT_X, so widening the exemption to GT_* fails a test. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…wnhall#8078) * fix(delete): cascade follows only parent-child edges (GH#6301) bd delete --cascade walked every incoming dependency edge, so deleting an epic also deleted unrelated issues that merely blocked, related to or were discovered from something in its tree. The closure walk (FindCascadeClosureInTx, formerly FindAllDependentsInTx) now follows only parent-child edges, in both dependency planes. Fixtures that relied on cascading over blocks edges now build their trees from parent-child edges. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit bcf68e0) Ported-From: opus/bcf68e073fb19301363143e4617b1bf0d2adc08c AC: AC-1 * fix(delete): report the dependents a cascade leaves behind (GH#6301) With cascade limited to parent-child descendants, rows joined to the deleted tree by any other edge survive and lose that edge. Every delete body now names them in DeleteResult.Orphaned (and the domain result's OrphanedIssues), checked against the whole deletion set so a dependent of a cascade-deleted descendant is reported too. The dry run names the same rows. AC: AC-2 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3b404bf) Ported-From: opus/3b404bfb923fee858bbb4e2b26fd7d19235893cb AC: AC-2 * feat(httpapi): announce containment-only delete cascade and refuse it on older servers Add the issues.delete.containmentCascade behavior token to the server's capability list and the client's handshake vocabulary. httpDeleter refuses a cascade (preview included) with *storage.ErrUnsupported before the dial when the server does not advertise it, because an older server's cascade deletes every transitive dependent. Non-cascade deletes are unaffected. The OpenAPI delete prose now describes the parent-child-only cascade. AC: AC-6 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 1d702e7) Ported-From: opus/1d702e7affd6a6a4361280ceef4804b7aeb214bc AC: AC-6 * docs(delete): describe the parent-child-only cascade in help, flags and CHANGELOG bd delete and bd admin cleanup help and --cascade flag text now say the cascade deletes parent-child descendants and other dependents survive. The command-tree golden and plugin command doc follow. The CHANGELOG records the behavior change, the new JSON and wire members, and the issues.delete.containmentCascade compatibility refusal. The generated CLI reference is left alone: it tracks the pinned release (docs/cli-docs.pin). AC: AC-7 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3cdedfb) Ported-From: opus/3cdedfb3810bb5c16a3564957b72ef0951512140 AC: AC-7 * fix(delete): cascade preview names every row it deletes and orphans (GH#6301) The cascade preview printed only the requested ids and the closure's count, so a caller agreed to delete rows it never saw. DeleteResult and the domain result now carry DeletedIDs (sorted, unique, one per counted row, filled before the dry-run return). Both the classic and proxied previews list that resolved set, once, under "Issues to delete (N)" instead of the requested ids, batch-loading titles for rows the front door did not read and listing a row by id when its title is missing; every orphaned id is listed too. The cascade notice now says it follows parent-child descendants only. AC: AC-3 Derived-From: opus/ec42ee3c719aeac0589f3a5d91feb897fac46246, glm/c18421915680956b0a507f4b9bf7bb1187f4a8a3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(delete): JSON names every row a cascade deletes and orphans (GH#6301) The --json previews reported counts beside the requested ids, so a script could not name what a cascade would take. Both previews now add would_delete_ids and would_orphan_ids, the confirmed run adds deleted_ids, and the cascade success text on both routes lists the deleted ids. `deleted` stays the requested ids and the single-ID envelope is untouched, so existing parsers keep their shape. AC: AC-4 Derived-From: opus/612079d681f059903b01633203aed31511d028b7, glm/03dcf16f17e48c53dbc0ba3e4a1c8bdf5f798efb Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(httpapi): carry the deleted ids on the delete wire result (GH#6301) The delete wire result now carries optional deleted_ids, projected by the server and mapped by the client, so every role backend (direct Dolt, embedded, UOW and served HTTP) returns the same complete deleted and orphaned sets; the shared deleter conformance cases assert them. The proxied cascade parity suite gains a containment_cascade scenario that replays a parent-child tree plus an association-joined epic through the real CLI on both storage modes and pins one outcome: the associated epic and its child survive. AC: AC-5 Derived-From: opus/ab8a64db69d74362ec2dedea274deff3c811d8d2, glm/0b586d30c4b84d611fbb10ab2befee68cbbc2b72 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(delete): align refusal, suites and ledger with the cascade (GH#6301) Review-loop fixup for gastownhall#8078, iteration 1. - tests/regression TestDeleteCascade built its A<-B<-C chain from default blocks edges and diffed the export against v0.49.6, whose cascade walks every edge type, so the required cmd/bd Dolt-server tier failed (ISSUE-2 and ISSUE-3 in candidate, missing from baseline). The chain is now parent-child, which both binaries cascade through. The blocks-chain divergence stays pinned on the candidate side by RunDeleterCascadeFollowsOnlyContainment. - backend/http/corpus shape gc-delete-cascade runs gc's workflow delete (bd delete <ids> --cascade --force) through the reference server's capability set, which has no issues.delete.containmentCascade. The new client refuses that cascade before dialing, so corpus_served_test failed (served exit 1, embedded exit 0). Mark the shape pending SRV-1, as the other capability-gated shapes are, until reference_server.json is upgraded. - The unforced dependents refusal said "use --cascade to delete them", which --cascade no longer does for a blocks, related or discovered-from dependent. Both copies (issueops and the domain use case) now say "use --force to orphan them, or --cascade to also delete its parent-child descendants (other dependents are orphaned)" and keep the "has dependents not in deletion set" prefix callers match on. Fix the contract comments that still described a cascade over every transitive dependent. - Add divergence-ledger row W-DeleteRequest.Cascade for the client's capability-gated cascade refusal, pinned by TestDeleteCascadeRefusesAServerWithoutContainmentCascade. Correct L-delete-notfound and L-delete-bound, which said bd delete cannot reach an http workspace, and regenerate engdocs/design/http-divergence-ledger.md. Validation: regression_test TestDeleteCascade and TestDeleteWithDependencies (--config=doltserver-cmd); corpus_served_test (all parts: 132 passed, gc-delete-cascade parked pending SRV-1) and corpus_test; encode_test (TestDivergenceLedgerDocMatchesLedger); httpclient_test, wire_test, httpapi_test, the issueops role and root targets, domain_test; db_test TestIssueUseCase_Delete against Dolt; bd_test delete output and command goldens; bd_proxied_test TestProxiedServerDelete*; bd_embedded_test TestEmbeddedDelete*. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(delete): register the cascade test, wire member and if-revision suite (GH#6301) Pre-approval CI repair for gastownhall#8078 (PR run 41562843171). - TestEmbeddedIfRevisionCascadeDelete linked its child to the parent with a default blocks edge and expected bd delete --cascade to delete it, which the containment-only cascade no longer does, so the embedded Dolt tier failed (bd show cd-eph succeeded). Link the child with a parent-child edge, as TestDeleteCascade already does. - .github/scripts/embedded-cmd-test-shards.txt did not list the new TestEmbeddedDeleteCascadeFollowsOnlyParentChild, so TestCmdEmbeddedShardManifestGeneratorNotStale and TestEmbeddedCmdShardManifestBareWriteIsIdempotent failed. Place it with gen_embedded_cmd_shard_manifest.py 100 --weights=duration --write (incremental: one line, shard 84). - TestWireShapeDigest failed on the new DeleteIssuesResult.deleted_ids member. Regenerate internal/httpapi/wireshape/testdata/golden.json with gendigest: a pure addition, no wire_revision bump. Validation: bd_embedded_test --config=embedded TestEmbeddedIfRevisionCascadeDelete and TestEmbeddedDeleteCascadeFollowsOnlyParentChild (6 ran, 6 passed); go_test_sources_test (26 passed) and, under --config=integration, TestEmbeddedCmdShardManifestBareWriteIsIdempotent; wireshape_test (54 passed, TestWireShapeDigest included). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
…astownhall#4470) (gastownhall#8055) * fix(schema): suspend dolt_transaction_commit for the migration pass (gastownhall#4470) Frozen migrations 0040 and 0041 carry in-body CALL DOLT_COMMIT. On a session with @@dolt_transaction_commit = 1 every preceding statement is already committed, so the in-body commit fails with "nothing to commit" and a fresh bd init dies at 0040. Turn the session setting off once a migration pass is needed, before its first write; converged opens issue no extra statement. AC: AC-1 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 819b7c8) Ported-From: opus/819b7c8e0ebaa4098b8507ef15554fcef9690dfa AC: AC-1 * test(init): pin bd init --server --external under dolt_transaction_commit (gastownhall#4470) Drives the bd binary against an isolated Dolt server whose new sessions start with @@dolt_transaction_commit = 1: init must exit 0 with no "nothing to commit" and leave both migration cursors at latest. With the suspension neutered it fails exactly as reported, at 0040. AC: AC-3 Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit cb6b4eb) Ported-From: opus/cb6b4eba9188a75c9cf61a736aeb3532d33d1672 AC: AC-3 * fix(schema): restore dolt_transaction_commit when the migration pass returns (gastownhall#4470) The pass now hands the pinned session back with its original @@dolt_transaction_commit on success and on failure. The restore runs on an uncanceled cleanup context, a restore error is joined to the pass's own result instead of replacing it, and a session that could not be restored is discarded (as ReleaseMigrationLock does) so no later work inherits the altered setting. MigrateUp now documents that it needs one session for the whole call. Tests cover the full enabled pass, a converged open (no read), read and SET failures, a dirty-guard refusal (typed error kept), restore failures joined to a refusal and reported after a successful pass, a canceled caller, and a retry after a mid-pass fault converging. AC: AC-2 Derived-From: opus/9063104dd38dad644e46d18184f4de84b49a1684, glm/40e71267ae33118f16d9895c39cf51634d7588c8, glm/7caca2d68ee363a8d192f91aa1f56c41b07abb7f Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(schema): review fixes for the dolt_transaction_commit suspension (gastownhall#4470) - Regenerate the 40-shard embedded storage manifest for the five new TestEmbedded*_4470 tests. The stale manifest failed TestStorageEmbeddedShardManifestGeneratorNotStale in //scripts:go_test_sources_test. - Report a migration failure and a failed restore on one line, the pass's error first, as MigrateUpWithLock reports a failed lock release: errors.Join's newline let a last-line-only capture drop the migration diagnostic. The dual-failure tests now assert one line. - Add SetKeepTransactionCommitForTest so TestEmbeddedTempRebuildIntermediatesNeverReachHistory runs its pass with automatic transaction commits on again: with the suspension it passed without the "__temp__%" ignore pattern. The comments on the pattern now say what it still guards. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
64 upstream commits since the 2026-10-27 resync (#73, upstream 43f4137), including upstream's 1.3.3 release (security, data-loss and dependency backports) and the fork-own-CI owner-id gating (gastownhall#8023). Conflict resolutions (27 files): - Version strings (version.go, winres, plugin and package manifests, marketplace, beads-mcp pyproject/__init__/uv.lock, git hooks, default.nix version): the fork's 1.95.0, per hunk, so upstream's other edits in those files are kept. check-versions.sh passes. - cmd/bd/info.go versionChanges: both kept, fork 1.95.0 first, then upstream 1.3.3 and 1.3.3-rc.1. - go.mod: upstream's newer x/* versions; x/time stays the fork's direct dependency (no duplicate indirect line). go mod tidy -diff is empty. - default.nix vendorHash: recomputed for the merged go.mod/go.sum (sha256-gRGuM1...). Computed as the NAR hash of a fresh `go mod download` cache minus sumdb, the proxyVendor goModules output; the same method reproduces bfork/main's and upstream's committed hashes exactly. - cmd/bd/db_proxy_child.go and its test: the fork's Debug field (proxy log hygiene) beside upstream's new ServerLogPath and --rotate-logpath; both tests kept. - cmd/bd/errors.go imports, internal/storage/embeddeddolt/BUILD.bazel srcs: both sides kept. - bazel.yml rbe runs-on and ci_workflow_test.go wantRBERunsOn: upstream's owner-id-gated expression (gastownhall#8023) with the fork's Blacksmith label swapped for ubuntu-latest, so the line differs from upstream only in the label. TestBazelRBERunnerOutsideGastownhall (new upstream) is fork-adjusted to expect ubuntu-latest for gastownhall's same-repo events too. - pr.yml windows-make-shell: windows-latest with upstream's new 40-minute timeout; CI Gate comment: upstream's fork-CI note plus the fork's local/true note. - main.yml windows-make-shell-toolchains (new upstream job, no conflict): Blacksmith Windows label swapped for windows-latest, per TestForkWorkflowsUseNoBlacksmithRunner. The job only runs in gastownhall/beads. - embedded-cmd shard manifest: upstream's, regenerated incrementally with --write so the five fork-only tests keep a shard; all three generators' --check pass. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
Two follow-ups from the upstream merge that make test caught: - cmd/bd/dolt_remote_reset_data.go: upstream's new externalServerDeclaration called the global doltserver.IsAutoStartDisabled(), which TestNoGlobalAutoStartCheckInProductionCode refuses (fork #56/#57). It now passes serverDir, the same directory killStaleServersForDir checks, which outside shared-server mode is the workspace's .beads. - cmd/bd/info.go: versionChanges is newest-first by date (TestGetVersionsSinceOrder), so upstream's 1.3.3 and 1.3.3-rc.1 (2026-11-03) now sit above the fork's 1.95.0 (2026-10-28). The next fork release adds its own entry on top. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
- Upstream-status table re-dated to 2026-11-04, each row checked with gh: gastownhall#6125 in review round 3 (CHANGES_REQUESTED 2026-11-02); gastownhall#7565 approved but superseded by upstream gastownhall#8088 (approved, not merged), which keeps a soft-skip for a missing metadata table that gastownhall#7565 refused, so the resync after it merges brings upstream's version; gastownhall#8040 approved; issue gastownhall#8044 filed for the global verifier. - Blacksmith runner guard: the manual grep used \s, which matches nothing on macOS; use [[:space:]]. Record upstream gastownhall#8023's owner-id gating and the fork adjustment to TestBazelRBERunnerOutsideGastownhall. - vendorHash chore: how to compute it with neither nix nor Docker. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
…tes for schema 0074 Review follow-up on #78. - cmd/bd/dolt_remote_reset_data_fork_test.go: a workspace whose own config.yaml sets dolt.auto-start: false makes reset-data decline to restart its server (externalServerDeclaration via IsAutoStartDisabledFor(serverDir)), with a control workspace that is restarted. Mutation-checked: with upstream's global IsAutoStartDisabled() the decline subtest fails. - FORK_DIVERGENCE.md: the release after this resync is a schema migration (main 0072 -> 0074, ignored 0028 -> 0031), with the deploy order of the 1.95.0 window (gascity ga-s69mk.18) and upstream 1.3.3's .beads/.env filtering (gastownhall#7879) and endpoint pinning (gastownhall#7887). Also notes that TestBazelRBERunnerOutsideGastownhall is kept for line shape only, and the 2026-11-04 fork-only shard test count (5). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
…ownhall#8222) buildResource used resource.WithProcess(), which includes the SDK's command-args detector: process.command_args carried the raw os.Args on the resource attached to every exported metric and span, bypassing scrubArgsForTelemetry (the scrub covers the bd.args span attribute only). With telemetry on, a --password=... flag, search text or an issue title reached the OTLP metrics receiver on every export. WithProcess also added process.executable.path and process.owner (the OS user name). The resource now lists the process detectors explicitly and keeps only process.pid, process.executable.name and the Go runtime attributes, next to host.name, service.* and OTEL_RESOURCE_ATTRIBUTES. Test: TestBuildResource_NeverCarriesCommandLine sets a canary argv and asserts the built resource has no command-args/path/owner attribute and no attribute value holding argv text. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 3a068db) Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
…wnhall#8221) * docs: re-review azure-devops and json-schema references against current code Both docs were last reviewed 2026-08-07 and now fail the 90-day freshness check. Re-reviewed each against its freshness sources and the commits to them since then, corrected what had drifted, and moved Last reviewed to 2026-11-07. azure-devops.md: document the endpoint-trust gate on ado.url (gastownhall#7887), the HTTPS requirement, ado.projects precedence, the day-granular incremental WIQL window, the beads_priority metadata that restores P4 locally, the Resolved->closed and fallback reverse mappings, the real create-then- transition sequence and which paths beads knows, --no-create in both directions, the relation pass that --issues/--parent do not narrow, the Project and Team PAT scope for bd ado projects, and which statuses retry. json-schema.md: document the proxied-server capability refusal shape ({code, error, mutates, reason}) and the migration-freeze exit 14, say which error handlers use which stream, list every built-in status and issue type, and mark the omitempty import summary members as optional (adding retired_ids). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(otel): re-review the OTel data model against current code Reviewed every metric, span, attribute and env var in engdocs/design/otel/otel-data-model.md against internal/telemetry/, internal/storage/dolt/, internal/compact/haiku.go, cmd/bd/find_duplicates.go, internal/hooks/ and internal/tracker/ at 087a4ec: completed the storage span inventory (77 direct, 48 role), corrected the bd.storage.* metric labels (duration and errors carry no db.operation), added the unlisted bd.db.* counters and pool gauges, the real resource attributes, the export-path conditions, the hook event set and the tracker.* spans, re-pinned the source audit, and moved Last reviewed to 2026-11-07. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(otel): fix a stale internal/telemetry/storage.go line reference The db.commit_msg note pointed at storage.go:556,564; the attributes are set at :674,682, as the appendix already says. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(otel): review fixes: done-only metric labels, raw command line on the resource - Metric labels: done records only what each method passes to it. 48 direct operations pass their start attributes; the other 29 direct operations and every role operation pass none (twelve of the 29 have start attributes that reach only the span and the counter, e.g. db.commit_msg). Section 3 and the section 8 duration/errors rows now say so, with the exact split. - Section 1.1/2: resource.WithProcess() puts the raw, unscrubbed os.Args on process.command_args, attached to every OTLP metric export, bypassing scrubArgsForTelemetry (fix pending). - AI: the compact span covers bd's whole retry loop; the Anthropic SDK default MaxRetries=2 retries under both callers. - Naming table hedged for Prometheus translation (_milliseconds, _bucket/_sum/_count); a Unit column in section 8; Event Index names bd.command.<name>. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(otel): the resource no longer carries the command line (gastownhall#8222) the resource carries no process.command_args, process.executable.path or process.owner. §1.1, the bd.args row and the source table now say so instead of "fix pending", with the new buildResource line range. host.name stays on the resource, and laptops are often named after their user, so both §1.1 and docs/reference/observability.md say how to override it (OTEL_RESOURCE_ATTRIBUTES=host.name=...). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: review fixes: P4 does not survive an ADO pull, plain-text --json errors Review fixes for gastownhall#8221 (adopt-pr bd-xpin7b, iteration 1), plus the three items of the steward's CHANGES_REQUESTED review at 5d2dee7. The two user pages describe the pinned release (docs/cli-docs.pin = v1.3.4; engdocs/decisions/2026-07-17-docs-release-pin.md, beads-docs skill §8), so they no longer document two main-only behaviors: ADO endpoint pinning (gastownhall#7887; internal/endpointtrust is not in v1.3.4) and import's retired_ids (gastownhall#7931). The incremental-window sentence keeps v1.3.4's behavior; main's five-minute pullFetchOverlap (gastownhall#8005) is not in that release either. docs/integrations/azure-devops.md - Nothing stores beads_priority: a push sets it only on the in-memory issue, and a pull rebuilds metadata from the work item, so a pushed P4 bead comes back as P3, usually on the first pull after the push. The note says so again, and "Metadata Preserved" lists only what a pull stores (ado.rev, area and iteration paths, story points); beads_priority, ado.remaining_work and ado.severity are never stored. - A custom ado.type_map.* value is matched first; the defaults still apply to the types it does not name. - Dropped the Scrum Bug transition row: bd has no path for it. - A failed create transition leaves the bead unlinked, so each later push creates another work item and a pull can import each one; the page says how to clean up. - The type and state filters restrict push whether they come from the flags or from config. docs/reference/json-schema.md - With --json, many failures stay plain text on stderr (HandleError, flag parsing, --readonly, the migration freeze), and some commands exit with another code (bd update's 13). mutates is always false on a refusal; reason is also carried by proxy.store.unrouted and proxy.migrate.external_endpoint and omitted on runtime-state refusals. engdocs/design/otel/otel-data-model.md - VictoriaMetrics stores OTLP names as is by default; the table is the Prometheus-style translation (Prometheus' default, or VictoriaMetrics with -opentelemetry.usePrometheusNaming). - A batch push (bd notion, bd linear outside --dry-run) returns before setting the tracker.push completion attributes. - The audit appendix is stamped 3a068db, the commit its buildResource line range already matched. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com> (cherry picked from commit bc07541) Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
PR preflight process (macos-latest) failed the three "symlinked <file> is
refused" subtests of TestAutofixWorkflowDownloadStep on GitHub's
macos-26-arm64 image 20261102.0473 (macOS 26.7.2). That image's unzip
does not create the link ("symlink error: Permission denied") and leaves
the entry out, so the step never reaches its own "is not a regular file"
refusal: the patch case ends found=false, the meta case found=true with
no meta file. Image 20261026.0455 (macOS 26.6.2) created the link and
the same test passed on 2026-11-05; the workflow and test are unchanged.
The step stays safe on such a host: nothing symlinked is extracted. The
test now accepts that outcome only when unzip reported the refusal, the
entry is absent (lstat), no patch never yields found=true, and the step
exits 0 as for a missing optional file. Hosts whose unzip creates the
link (Linux, the production ubuntu-latest runner, macOS 27.0) still take
the strict branch.
Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
…ards //internal/storage/dolt:dolt_server_full_test shard 13 of 16 hit the 15m test timeout on both CI runs of the 2026-11-04 resync (886s on the re-run that passed; 907s, timed out, on 6094252). Its 96 tests are the same on fork main and on the merge: no new test hashed into it. It was already the slowest shard (600-705s on 2026-10-30/11-01, next heaviest about 470s) because it holds TestCreateBatchFastPathsMatchPerRow_Dolt, the package's heaviest serial test (196s), and upstream gastownhall#7931 added that test's "retired" scenario (43s) plus growth elsewhere in the shard. From the CI test logs, shard 13 ran 526s of serial tests (next shard 267s) and 1309s of parallel ones (next 1132s). Following the manifest's documented practice, pin the four heaviest tests hashing there to the lightest shards: TestCreateBatchFastPathsMatchPerRow_Dolt to 14, TestDeleterContract to 8, TestDoltNew_WispRowLockSelfHeal_RealDolt to 16 and TestDoltNew_SmartRemoteMigrateGate_BelowLatestDegrades_RealDolt to 7. Estimated from the same logs (serial + parallel/4), shard 13 drops from about 853s to 557s and the heaviest receiver (14) rises to about 369s. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
//scripts/repochecks:doc_freshness_test fails on engdocs/SERVE_RUNBOOK.md (Last reviewed 2026-08-10, 91 days old on 2026-11-09). The check is wall-clock relative with no exemption list; upstream main fails it the same way in its uncached nightly run (42549591390) and passes PRs only on cached test results. Re-reviewed against internal/httpapi (server.go, events_watch.go, auth.go, problem.go and the write handlers) and cmd/bd/serve.go: - the pool idle reclaim is 20s (ConnMaxIdleTime, under the 30s Dolt wait_timeout), not 5 minutes; event=limits prints the pool_* limits; - --large-apply-ceiling is the one envelope flag; one large apply runs, at most one more waits up to semAcquireTimeout (10s), others get 503 busy; - the Host allowlist's loopback spellings, the wildcard-bind numeric case, and the --allowed-host refusals (port, empty, URL-shaped); - limit=0 is refused on all three paged reads beyond loopback; - Cache-Control: no-store on every response; the event stream's 1s jittered poll, 20s heartbeat, X-Accel-Buffering: no, retry 3000ms, Retry-After on events_watch_saturated, and bd serve's 5-minute journal auto-prune ticker with its 410 events_journal_truncated; - the startup fields, the limits fields, the request_refused event the write handlers emit, the embedded refusal's full text, the bare-port --addr and non-positive ceiling refusals, and the bind error shape; - Go's listener keepalive sets idle, interval and count (15s/15s/9). Last reviewed moves to 2026-11-09. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor
|
Disclosure: the five CI-fix commits ee3fc4e..7778764 were pushed with claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor |
…(refs be-c65udwe) setupStraddledCutoff builds the gastownhall#6645 history with two UPDATEs of one issue: edit A sets the title to "edit A", then B sets it back to "ORIGINAL". issues.updated_at carries ON UPDATE CURRENT_TIMESTAMP at second precision (migration 0001), so an UPDATE that does not assign it re-stamps it from the wall clock. When the stamps before A, at A and at B land in different seconds, compact's cherry-pick of A onto the squashed B conflicts on updated_at and fails with "Merge conflict detected" before it reaches the divergence check. TestEmbeddedCompactAbortsDivergentReplay then fails on a second-boundary race instead of asserting the refusal it exists for. Assign updated_at to itself in both UPDATEs so the title is the only column that differs between the commits and the divergence check is the one that always runs. Checked with the embedded lane's own target, 3 runs of the test per command. With two temporary 2 s sleeps in the fixture to put the stamps in different seconds (not committed), the test failed 3 of 3 runs with "Merge conflict detected"; with the same sleeps and this change it passed 3 of 3. The diagnosis is from the release-prep notes on gastownhall#8085. Agent-Signature: claude-code-claude-sonnet-5-5-max on behalf of Jim Wordelman (cherry picked from commit 61364d9)
|
Pushed f56cb94, a The other fixes held on run 42685802427: server-storage shard 13, macOS preflight and doc freshness are all green. claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor |
This PR merges upstream main (
3c205e0a4) into fork main (74306adc3, v1.95.0). That is 64 upstream commits since the 2026-10-27 resync (#73). They include upstream's 1.3.3 release (security, data-loss and dependency backports) and its fork-own-CI owner-id gating (gastownhall#8023). It is a merge commit, not a rebase, in the same shape as #73.This is a schema migration, NOT a binary swap. The main schema goes from 0072 to 0074:
0073_add_arrival_seq(upstream 5011528, gastownhall#7912) and0074_create_id_tombstones(9353122, gastownhall#7931). The ignored plane goes from 0028 to 0031:0029_add_wisps_arrival_seq(5011528),0030_create_wisp_id_tombstones(9353122) and0031_restore_preflip_events(7ac98ae, gastownhall#8047). 9311c24 (gastownhall#8053) adds no migration file but changes how the runner applies old migrations (it keeps issue and wispupdated_at). Once one database is migrated to 0074, every host still on 1.95.0 refuses it (schema skew).The version is not bumped here. Fork main reports 1.95.0, and its newest fork
info.goentry still says "SCHEMA: 0069 -> 0072", until the follow-up release PR bumps the version and adds its entry, as #77 followed #73. Nobody deploys main before that release PR lands.schema.goalso gainsCheckReadableDriftand a gateway variant ofSchemaBehindError. The fork's migration-freeze gate still runs before the consent gate inMigrateUpand inmigrateUpConsented.Deploy notes (for the release that follows this PR; also in FORK_DIVERGENCE.md, "The release after the 2026-11-04 resync")
Order, the same as the 1.95.0 window (gascity ga-s69mk.18):
43f41374a(schema 0072). From the code, it refuses: that library's server-mode open runsschema.CheckForwardDrift, which refuses a database ahead of its latest migration, and gc unsetsBD_IGNORE_SCHEMA_SKEWfor the open (bdRemoteMigrateOpenEnvKeys). Confirm it against a migrated copy before the window.bdand runbd migrateper database in a window, after the backup and rehearsal steps.fix(security): block executable settings from .beads/.env and workspace API gastownhall/beads#7879,
.beads/.envfiltering.loadBeadsEnvFile(cmd/bd/main.go) imports only keys thatcreds.AllowedProjectEnvKey(internal/creds/command.go) admits:BEADS_*,BD_*,GT_ROOT(fix(env): allow GT_ROOT in a project .beads/.env gastownhall/beads#8117) andDOLT_REMOTE_USER/DOLT_REMOTE_PASSWORD. It drops every other key and printsbeads: ignoring <KEY> from .beads/.env (<reason>). Command keys (BEADS_DOLT_CREDENTIAL_COMMAND,BEADS_HTTP_TOKEN_COMMAND,BD_MAIL_DELEGATE,BD_PAGER,BEADS_DOLT_BIN,EDITOR,PAGER, ...) and credential-redirect keys (BEADS_DOLT_SERVER_HOST,BEADS_CREDENTIALS_FILE,BEADS_CENTRAL_CONFIG,BEADS_HTTP_CA_FILE) are dropped even with aBEADS_/BD_prefix..beads/.env, and no file in its tree writes one (the only references are scratch copies of gascity source). The rigs invoxist-city/.gc/site.tomlwith a.beads/.envare wise-stack, asr-all, asr-medical, voxist-identity, voxist-platform, livecenter and voxmemo. voxist-web-stack, voxlingo and jambonz/agent-ia-entreprise have none. voxist-app and livetranslate-webrtc also have one. Every one of those files holds exactly one key,GT_ROOT, which fix(env): allow GT_ROOT in a project .beads/.env gastownhall/beads#8117 admits. Only key names were read, not values.fix(security): pin shared credential endpoints on first use gastownhall/beads#7887, endpoint pinning. When
BEADS_DOLT_PASSWORDis set,resolveDoltServerConnection(cmd/bd/main.go) callsCheckServerEndpointTrustbefore sending it. A loopback endpoint, or a host from a private source (process environment or user config, not.beads/.env), is trusted and pinned per workspace in~/.config/beads/trusted-endpoints.json. A non-loopback host that only committed config names is refused until a private source confirms it, and so is a later change to a pinned shared endpoint. gc passesBEADS_DOLT_SERVER_HOSTin the process environment (cmd/gc/bd_env.go), so the fleet's endpoints count as private.arrival_seqand gascity's writers. Migration 0073 adds a nullablearrival_seqtoissuesandwisps. The unique indexuk_wisps_arrival_seqis onwispsonly. Only bd's journal create seam writes it (stampArrivalSeqInTx, pinned byTestArrivalSeqIsWrittenOnlyByTheJournalSeam). gascity has no direct-SQLINSERT INTO issues/wispsand noUPDATEof either table incmd/orinternal/outside tests: its raw SQL writes there touchmetadata,dolt_ignore, the health-probe table, wisp query indexes, dropped-database cleanup andDOLT_COMMIT. Its bead writes go through the bd library (native store) or the bd CLI, so on a 0074 binary they take the same create seam. A row that seam does not stamp (journal off, a non-create write, or a row from before 0073) keepsarrival_seqNULL, and that is safe:WHERE id = ? AND (arrival_seq IS NULL OR arrival_seq = ?)).types.Issue.ArrivalSeqisomitempty.opjournal.Op.ArrivalSeqstays 0 until its OJ-10a work maps the column. That consumer must treat 0 as "unstamped", not as the first arrival.A gascity library still pinned at 0072 never writes to a 0074 database, because it refuses the open (above).
Commits
e9ff091c7merges upstream. Its message gives the full resolution detail.7919a3d42fixes two defects the merge introduced, both caught bymake test.b88aef854refreshes FORK_DIVERGENCE.md.6094252c3(review follow-up) adds a unit test for the reset-data fork change and the schema 0074 deploy notes in FORK_DIVERGENCE.md.Conflict resolutions (27 files)
version.go, winres, the plugin, package and marketplace manifests, beads-mcp, the git hooks anddefault.nix's version line. Upstream's other edits in those files are kept, andcheck-versions.shpasses.cmd/bd/info.go: both sides' entries are kept. The array is newest-first by date (TestGetVersionsSinceOrder), so upstream's 1.3.3 and 1.3.3-rc.1 (2026-11-03) now sit above the fork's 1.95.0 (2026-10-28). The next fork release adds its own entry on top.go.mod: upstream's newer x/* versions. x/time stays a direct fork dependency, andgo mod tidy -diffis empty.default.nixvendorHash: recomputed for the merged modules, without Docker. The method is the NAR hash of a freshgo mod downloadcache withsumdbremoved, which is whatproxyVendorhashes. It reproduces both bfork/main's and upstream's committed hashes exactly. CI'sTest Nix Flakeis the confirmation.Debugfield (proxy log hygiene) is kept next to upstream's newServerLogPathand--rotate-logpath. Both tests are kept.runs-on(andwantRBERunsOn) takes upstream's owner-id-gated expression with the Blacksmith label swapped forubuntu-latest. The line now differs from upstream only in the label. Upstream's newTestBazelRBERunnerOutsideGastownhallis adjusted to expectubuntu-latesteverywhere.windows-make-shell-toolchainscame in onblacksmith-4vcpu-windows-2025and is swapped towindows-latest, perTestForkWorkflowsUseNoBlacksmithRunner. pr.yml's windows-make-shell keepswindows-latestand takes upstream's 40-minute timeout.--writeso the five fork-only tests keep a shard. All three generators'--checkpass.errors.goimports andembeddeddolt/BUILD.bazelsrcs keep both sides.make bazel-syncchanged nothing.Fixes the merge needed (
7919a3d42)externalServerDeclarationcalled the globaldoltserver.IsAutoStartDisabled(), whichTestNoGlobalAutoStartCheckInProductionCoderefuses. It now callsIsAutoStartDisabledFor(serverDir), the directorykillStaleServersForDirchecks. Outside shared-server mode, that directory is the workspace's.beads.info.goorder described above.Test for the reset-data change (
6094252c3):TestResetThroughServerHonorsTheWorkspacesOwnAutoStart(cmd/bd/dolt_remote_reset_data_fork_test.go) gives a temp workspace aconfig.yamlwithdolt.auto-start: falseand checks that reset-data declines to restart its server and names the auto-start declaration. A control workspace without the line is restarted.bazel test //cmd/bd:bd_test --config=ci --test_filter=...shows 3 PASS lines (the test and both subtests), with no SKIP. Mutation check: with the call reverted to the globalIsAutoStartDisabled(), the decline subtest FAILs (externalServerDeclaration(...) = "", and bd restarted the server) and the control subtest still passes. The source was restored before the commit.Gates run locally (macOS arm64, host load about 650)
make testran to completion before the fixes: 155 of 199 tests executed, 141 passed, 14 failed, 44 skipped. Two targets failed on merge defects, both fixed in7919a3d42://scripts:go_sources_test(TestNoGlobalAutoStartCheckInProductionCode) and//cmd/bd:bd_testshard 13 (TestGetVersionsSinceOrder). Twelve failed locally only, on host causes://internal/storage/issueops:issueops_test: TIMEOUT at 300 s under the host load. It passes with a longer timeout (below).//scripts:scripts_test: TIMEOUT at 300 s. With a longer timeout, 3 tests still fail on the host (below).//scripts/repochecks:fmt_test: TIMEOUT at 300 s.//scripts/repochecks:go_install_guidance_test: TIMEOUT at 300 s.//internal/httpclient:httpclient_test: TIMEOUT on 1 of 2 shards at 900 s; the other shard passed in 775 s.//internal/doltserver:doltserver_test: theTestAwaitOwnedListener_*,TestStart_RecoversWhenEphemeralPortIsTakenandTestReclaimPort_NonDoltError_IncludesDiagnostics_GH3516tests. In the darwin sandbox,lsofcannot identify a port's owner ("port … is busy but cannot identify the process"), andstartowned.gorelies on it.//scripts:shell_scripts_test: theTestCheckBuildTags*tests. The sandbox runs macOS bash 3.2, which has nomapfile.//scripts/repochecks:build_tags_test: the samemapfilecause (exit 127).//scripts/repochecks:winget_portable_alias_test:yqis not on the sandbox PATH (it is in/opt/homebrew/bin).//tests/hook_timeout_backends:hook_timeout_backends_test:timeoutis not on the sandbox PATH.//tests/migration:legacy_bridge_test: "timeout is required to verify historical release binaries safely", the same PATH cause.//scripts/gitattributespolicy:gitattributespolicy_required_host_test: "runtime GOOS darwin does not match protected expected GOOS linux". It is a Linux-only contract.//cmd/bd:bd_testalso failed on two more shards for host reasons. Shard 1 isTestRunTestsAndSweepReapsOrphanedServer, a darwin-only test:runTestsAndSweep() = 0, want 1, so the sweep saw no leaked server inside the sandbox. I assume the cause is the same process-visibility limit, but did not confirm it. Shard 12 isTestAcquireCommandWorkspaceGatesQueuesBehindWaitingInit, with the exact race message that test(cmd/bd): wait for the intent sidecar before checking the queued-init notice gastownhall/beads#8040 fixes. None of these tests' files carries fork changes, apart from an unrelatedifconstant inrbe_worker_env_test.go. I ran no control on clean upstream for them.After the fixes, rerun with
--test_timeout=1800://scripts:go_sources_testpasses (60 PASS, 0 FAIL, 0 SKIP), includingTestNoGlobalAutoStartCheckInProductionCode.//internal/storage/issueops:issueops_testpasses (1189 PASS, 0 FAIL, 0 SKIP).//scripts:scripts_test: 1487 PASS, 30 SKIP (linux-only), 3 FAIL. The failures areTestSetupBazelForkCredential,TestRRCWriterCredential(macOS LibreSSL'ssubject=format) andTestRBEWorkerEnvSyncRef/hung(notimeouton the sandbox PATH). The fork-adjusted runner tests pass:TestBazelRBERunnerOutsideGastownhall,TestForkWorkflowsUseNoBlacksmithRunner,TestSameRepoBlacksmithRunnersandTestWindowsMakeShellToolchainSaverMatchesPRJob.make ci-pr-lintpasses (nogo native plus windows/darwin non-cgo, 555 s).make check-docspasses ("All documentation references are consistent with CLI").Rerun on
6094252c3:make ci-pr-lintpasses (nogo native plus windows/darwin non-cgo, 303 s),make check-docspasses, andmake bazel-syncchanges nothing.Left to fork CI (Linux, mode local with every Dolt tier): the full
make testlane is NOT green locally and is left to fork CI. So are the embedded, integration, proxied, server-storage and cmd-dolt tiers, Windows, macOS, andTest Nix Flake.gastownhall#8025 (
TestArrivalSeqIsWrittenOnlyByTheJournalSeamfailing on macOS): it did not reproduce here. The test passed in theissueops_testrun above (--- PASS: TestArrivalSeqIsWrittenOnlyByTheJournalSeam).Docs-pin tag.
docs/cli-docs.pinis nowv1.3.3. The tag (007780ee4, identical to upstream's tag object) was pushed to the fork on 2026-11-05, before this PR opened (resync chore 1 in FORK_DIVERGENCE.md).FORK_DIVERGENCE.md
gh:metadatatable, so the next resync brings in upstream's version.\s, which matches nothing on macOS. It now uses[[:space:]]; the old form missed the new main.yml job.claude-code-claude-opus-5-5-unknown-reasoning on behalf of voxist.executor