Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show aggregation if one column is grouped #28

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

asimonok
Copy link
Contributor

Resolves #19

@asimonok asimonok added the enhancement New feature or request label Aug 22, 2024
@asimonok asimonok added this to the Table 1.1.0 milestone Aug 22, 2024
@asimonok asimonok requested a review from mikhail-vl August 22, 2024 06:53
@asimonok asimonok self-assigned this Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (90d798f) to head (84ee2be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          54       54           
  Lines         851      853    +2     
  Branches      203      203           
=======================================
+ Hits          850      852    +2     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 49943fb into main Aug 22, 2024
6 checks passed
@mikhail-vl mikhail-vl deleted the feat/show-aggregation branch August 22, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Show aggregation field in column editor if one or more is grouped
3 participants