Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(groupComparisonPTM): Fix bugs and unit tests #107

Merged
merged 5 commits into from
Mar 13, 2025
Merged

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Mar 11, 2025

Motivation and Context

Problem 1

This commit is causing build failures.

Problem 2

User was having issues because proteinGroups was NULL when including a global proteome dataset. User should get an error about this field being null. Right now, the error is:

Error in data.table::fread(input, showProgress = FALSE, ...) : 
  input= must be a single character string containing a file name, a system command containing at least one space, a URL starting 'http[s]://', 'ftp[s]://' or 'file://', or, the input data itself containing at least one \n or \r

Changes

  • Fix changes related to groupComparisonPTM in code and tests
  • Add error message early on that validates that the proteinGroups file is not null

Testing

Dry run passes

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999 tonywu1999 changed the title chore(maxq): Add error message for null proteinGroups parameter chore(groupComparisonPTM): Fix bugs and unit tests Mar 13, 2025
@tonywu1999 tonywu1999 merged commit 81e2e48 into devel Mar 13, 2025
1 check passed
@tonywu1999 tonywu1999 deleted the error-message branch March 13, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant