Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metamorpheus): Add converter from metamorpheus to core MSstats #109

Closed
wants to merge 1 commit into from

Conversation

tonywu1999
Copy link
Contributor

Motivation and Context

As a part of this issue, users are requesting a converter from Metamorpheus to MSstatsPTM. The first step is to create a converter from Metamorpheus to core MSstats.

Long term, we may reconsider moving all converter logic into MSstatsConvert instead of MSstats for scalability purposes. But for now, we will place them in their respective packages to reduce confusion, i.e. core MSstats converter is in MSstats, PTM converter is in MSstatsPTM.

Changes

  • Created a new converter called MetamorpheustoMSstatsFormat in MSstats.

Testing

  • Added unit test to test basic functionality of MetamorpheustoMSstatsFormat

Checklist Before Requesting a Review

  • I have read this repository's contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules [Not yet, MSstatsConvert changes are not in bioconductor yet]

@tonywu1999
Copy link
Contributor Author

Closing this PR in favor of Vitek-Lab/MSstatsConvert#85

@tonywu1999 tonywu1999 closed this Feb 7, 2024
@tonywu1999 tonywu1999 deleted the feature-metamorpheus-converter branch March 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant