Skip to content

Changed to work without ColorAxis. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: polygonseries
Choose a base branch
from

Conversation

SADASHIMA
Copy link

  • Add Fill in PolygonSeries class
  • polyColor works as follows
    • If Fill Is Undefined
      • If Is ColorAxis valid
        • Get color from ColorAxis
      • Else
        • Get Default Color
    • Else
      • If Fill Is Automatic
        • Get Default Color
      • Else
        • Fill
  • Added an example without ColorAixs

@SADASHIMA
Copy link
Author

If the usage is the same when using ColorAxis and Value and when using Fill, I think the Fill should be defined in PolygonItem.
In that case, I also think the Stroke should be defined in PolygonItem.
What do you think about this?

@VisualMelon
Copy link
Owner

Yes, I'd be in favour of allowing full control of the presentation in the individual items

Thanks for working on this, I'll try to review your PR properly over the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants