Fixing Appveyor build; making the VS analyzer happy

VioletGiraffe · Jul 30, 2020 · 2c01f7a · 2c01f7a
1 parent e833e82
commit 2c01f7a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/CPPCheckPlugin/CPPCheckPluginPackage.cs b/CPPCheckPlugin/CPPCheckPluginPackage.cs
@@ -47,7 +47,7 @@ public static CPPCheckPluginPackage Instance
 			get { return _instance; }
 		}
 
-		public static async void addTextToOutputWindow(string text)
+		public static async Task AddTextToOutputWindowAsync(string text)
 		{
 			try
 			{
@@ -332,7 +332,7 @@ private void documentSavedSync(Document document)
 					if (_outputPane != null)
 					{
 						_outputPane.Clear();
-						addTextToOutputWindow("Exception occurred in cppcheck add-in: " + ex.Message);
+						_ = AddTextToOutputWindowAsync("Exception occurred in cppcheck add-in: " + ex.Message);
 					}
 					DebugTracer.Trace(ex);
 				}

diff --git a/CPPCheckPlugin/ICodeAnalyzer.cs b/CPPCheckPlugin/ICodeAnalyzer.cs
@@ -204,7 +204,7 @@ private void startAnalyzerProcess(string analyzerExePath, string arguments)
 				process.OutputDataReceived += new DataReceivedEventHandler(this.analyzerOutputHandler);
 				process.ErrorDataReceived += new DataReceivedEventHandler(this.analyzerOutputHandler);
 
-				CPPCheckPluginPackage.addTextToOutputWindow("Starting analyzer with arguments: " + arguments + "\n");
+				_ = CPPCheckPluginPackage.AddTextToOutputWindowAsync("Starting analyzer with arguments: " + arguments + "\n");
 
 				var timer = Stopwatch.StartNew();
 				// Start the process.
@@ -235,11 +235,11 @@ private void startAnalyzerProcess(string analyzerExePath, string arguments)
 				timer.Stop();
 				analysisFinished(arguments);
 				if (process.ExitCode != 0)
-					CPPCheckPluginPackage.addTextToOutputWindow(analyzerExePath + " has exited with code " + process.ExitCode.ToString() + "\n");
+					_ = CPPCheckPluginPackage.AddTextToOutputWindowAsync(analyzerExePath + " has exited with code " + process.ExitCode.ToString() + "\n");
 				else
 				{
 					double timeElapsed = Math.Round(timer.Elapsed.TotalSeconds, 3);
-					CPPCheckPluginPackage.addTextToOutputWindow("Analysis completed in " + timeElapsed.ToString() + " seconds\n");
+					_ = CPPCheckPluginPackage.AddTextToOutputWindowAsync("Analysis completed in " + timeElapsed.ToString() + " seconds\n");
 				}
 				process.Close();
 				process = null;
@@ -280,7 +280,7 @@ private void analyzerOutputHandler(object sendingProcess, DataReceivedEventArgs
 			{
 				addProblemsToToolwindow(parseOutput(output));
 				try {
-					CPPCheckPluginPackage.addTextToOutputWindow(output + "\n");
+					_ = CPPCheckPluginPackage.AddTextToOutputWindowAsync(output + "\n");
 				}
 				catch (Exception) { }
 			}

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,5 +1,5 @@
-version: 1.3.{build}
-image: Visual Studio 2017
+version: 1.4.{build}
+image: Visual Studio 2019
 configuration: Release
 platform: Any CPU
 assembly_info: