Skip to content

Add missing builtin functions and autocmd events based on Vim 8.1.72 - #289

Open
rhysd wants to merge 3 commits into
Vimjas:masterfrom
rhysd:missing-builtin-funcs
Open

rhysd wants to merge 3 commits into
Vimjas:masterfrom
rhysd:missing-builtin-funcs

Conversation

@rhysd

@rhysd rhysd commented Aug 3, 2018

Copy link
Copy Markdown
Contributor

I noticed some functions (e.g. json_decode()) are not recognized as builtin functions. I have updated the list of builtin functions in vint based on :help eval@en using MacVim 8.1.72.

I updated list of builtin functions based on `:help eval@en` using
MacVim 8.1.72.
@Kuniwak
Kuniwak self-requested a review August 3, 2018 03:31

@Kuniwak Kuniwak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I appriciate your contribution.

@Kuniwak

Kuniwak commented Aug 3, 2018

Copy link
Copy Markdown
Member

I'm gonna merge into v0.4a2 with #288.

@rhysd

rhysd commented Aug 3, 2018

Copy link
Copy Markdown
Contributor Author

@Kuniwak I noticed another lists are in vint/ast/dictionary. I also updated them 👍

I'm gonna merge into v0.4a2 with #288.

Sure. Makes sense.

@rhysd rhysd changed the title Add missing builtin functions based on Vim 8.1.72 Add missing builtin functions and autocmd events based on Vim 8.1.72 Aug 3, 2018
@blueyed

blueyed commented Aug 3, 2018

Copy link
Copy Markdown
Member

@rhysd
Thank you!
In case this was (semi-)automated it might be a good idea to share the script and maybe even include it in CI to have the list up-to-date always.

@blueyed

blueyed commented Aug 3, 2018

Copy link
Copy Markdown
Member

Haven't checked but there is likely a Neovim specific list also?

@rhysd

rhysd commented Aug 3, 2018 •

Copy link
Copy Markdown
Contributor Author

@blueyed

In case this was (semi-)automated it might be a good idea to share the script and maybe even include it in CI to have the list up-to-date always.

Yeah, automating this should be done. I actually created changes from help text; copy list in :help eval to temporary buffer, modify it to dict items of Python, paste it to Python file, run :sort u (Vim is sometimes an automating tool for me).

Haven't checked but there is likely a Neovim specific list also?

I greped sources but I could not find Neovim specific list. I'm not sure I should add Neovim things to the list. What do you think @Kuniwak?

@blueyed

blueyed commented Aug 3, 2018

Copy link
Copy Markdown
Member

@rhysd
There is --enable-neovim, which I assumed would enable such a list - but maybe it is only used by vimlparser then?

@Kuniwak

Kuniwak commented Aug 3, 2018 •

Copy link
Copy Markdown
Member

I greped sources but I could not find Neovim specific list. I'm not sure I should add Neovim things to the list. What do you think @Kuniwak?

@rhysd Yes, I have not implemented the Neovim specific list yet. But we can (and should) switch the list by checking that whether --enable-neovim was specified or not.

@blueyed

blueyed commented Nov 29, 2018

Copy link
Copy Markdown
Member

@rhysd
Can you address/respond to the last comment from @Kuniwak, please?

It would also be really good to have a script to build the list(s) to easily update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants