Feat(eos_designs): Add 'maximum_routes_warning_only' to the 'bgp_peer…

…s' in network_services data model (aristanetworks#3645)
Vibhu-gslab · Feb 22, 2024 · 1213921 · 1213921
1 parent 95301e0
commit 1213921
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 2 deletions.
diff --git a/ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1A.cfg b/ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1A.cfg
@@ -360,7 +360,7 @@ router bgp 65104
       neighbor 123.1.1.10 ebgp-multihop 3
       neighbor 123.1.1.10 shutdown
       neighbor 123.1.1.10 send-community standard extended
-      neighbor 123.1.1.10 maximum-routes 0
+      neighbor 123.1.1.10 maximum-routes 0 warning-only
       neighbor 123.1.1.10 default-originate route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT
       neighbor 123.1.1.10 update-source Loopback123
       neighbor 123.1.1.10 route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT out

diff --git a/ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1B.cfg b/ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-BL1B.cfg
@@ -341,7 +341,7 @@ router bgp 65105
       neighbor 123.1.1.10 ebgp-multihop 3
       neighbor 123.1.1.10 shutdown
       neighbor 123.1.1.10 send-community standard extended
-      neighbor 123.1.1.10 maximum-routes 0
+      neighbor 123.1.1.10 maximum-routes 0 warning-only
       neighbor 123.1.1.10 default-originate route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT
       neighbor 123.1.1.10 update-source Loopback123
       neighbor 123.1.1.10 route-map RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT out

diff --git a/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1A.yml b/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1A.yml
@@ -167,6 +167,7 @@ router_bgp:
       description: External IPv4 BGP peer
       send_community: standard extended
       maximum_routes: 0
+      maximum_routes_warning_only: true
       default_originate:
         always: false
         route_map: RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT

diff --git a/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1B.yml b/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1B.yml
@@ -172,6 +172,7 @@ router_bgp:
       description: External IPv4 BGP peer
       send_community: standard extended
       maximum_routes: 0
+      maximum_routes_warning_only: true
       default_originate:
         always: false
         route_map: RM-Tenant_A_WAN_Zone-123.1.1.10-SET-NEXT-HOP-OUT

diff --git a/...vd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml b/...vd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml
@@ -158,6 +158,7 @@ tenant_a:
             description: External IPv4 BGP peer
             send_community: standard extended
             maximum_routes: 0
+            maximum_routes_warning_only: true
             default_originate:
               always: false
             update_source: Loopback123

diff --git a/.../arista/avd/roles/eos_designs/docs/tables/network-services-vrfs-bgp-settings.md b/.../arista/avd/roles/eos_designs/docs/tables/network-services-vrfs-bgp-settings.md
@@ -77,6 +77,7 @@
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;next_hop_self</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].next_hop_self") | Boolean |  |  |  |  |
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;timers</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].timers") | String |  |  |  | BGP Keepalive and Hold Timer values in seconds as string <0-3600> <0-3600>. |
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;maximum_routes</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].maximum_routes") | Integer |  |  | Min: 0<br>Max: 4294967294 | Maximum number of routes (0 means unlimited). |
+    | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;maximum_routes_warning_only</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].maximum_routes_warning_only") | Boolean |  |  |  |  |
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;default_originate</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].default_originate") | Dictionary |  |  |  |  |
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;always</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].default_originate.always") | Boolean |  |  |  |  |
     | [<samp>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;update_source</samp>](## "<network_services_keys.name>.[].vrfs.[].bgp_peers.[].update_source") | String |  |  |  |  |
@@ -330,6 +331,7 @@
 
                 # Maximum number of routes (0 means unlimited).
                 maximum_routes: <int; 0-4294967294>
+                maximum_routes_warning_only: <bool>
                 default_originate:
                   always: <bool>
                 update_source: <str>

diff --git a/ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml b/ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml
diff --git a/...ns/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_network_services.schema.yml b/...ns/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_network_services.schema.yml
@@ -886,6 +886,8 @@ $defs:
                       min: 0
                       max: 4294967294
                       description: Maximum number of routes (0 means unlimited).
+                    maximum_routes_warning_only:
+                      type: bool
                     default_originate:
                       type: dict
                       keys: