A lot of fixes related to swimming and water movement on Bedrock. #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianMichael
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Going to leave the functionality review to @RaphiMC , this is just styling things
...n/java/com/viaversion/viafabricplus/injection/mixin/features/movement/water/MixinEntity.java
Outdated
Show resolved
Hide resolved
.../com/viaversion/viafabricplus/injection/mixin/features/movement/water/MixinLivingEntity.java
Outdated
Show resolved
Hide resolved
.../com/viaversion/viafabricplus/injection/mixin/features/movement/water/MixinPlayerEntity.java
Outdated
Show resolved
Hide resolved
...om/viaversion/viafabricplus/injection/mixin/features/bedrock/movement/MixinPlayerEntity.java
Show resolved
Hide resolved
...om/viaversion/viafabricplus/injection/mixin/features/bedrock/movement/MixinPlayerEntity.java
Show resolved
Hide resolved
...om/viaversion/viafabricplus/injection/mixin/features/bedrock/movement/MixinPlayerEntity.java
Show resolved
Hide resolved
oryxel1
commented
Nov 1, 2025
|
|
||
| @Redirect(method = {"shouldStopSprinting", "canStartSprinting"}, at = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/ClientPlayerEntity;canSprint(Z)Z")) | ||
| private boolean allowNonSwimWaterSprinting(ClientPlayerEntity instance, boolean allowTouchingWater) { | ||
| return this.canSprint(allowTouchingWater || ProtocolTranslator.getTargetVersion().equals(BedrockProtocolVersion.bedrockLatest) && (instance.isSwimming() || instance.isOnGround())); |
There was a problem hiding this comment.
Note to self: This part is wrong.... The condition for this is not swimming or on ground, it's depending on the water height maybe... however the player will sprint when swimming.
There was a problem hiding this comment.
However if the water height can't be figure out then we can avoid sending raw sprinting value to the server in certain cases, since BDS use the raw value to determine if we're sprinting or not instead of START/STOP.
FlorianMichael
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowhere near perfect, but well, feel free to play around as much as you'd like to...