Bedrock block hitboxes #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/bedrock-hitboxes
Exterminate5573
force-pushed
the
feat/bedrock-hitboxes
branch
from
7967f98 to
7677987
Compare
Contributor
|
Collision is still wrong, however not noticeable (on BDS atleast), looks at the Y coords slightly being pushed up. Minecraft_.1.21.10.-.Multiplayer.3rd-party.Server.2025-10-21.17-40-38.mp4 |
FlorianMichael
requested changes
Oct 21, 2025
Member
FlorianMichael
left a comment
FlorianMichael
left a comment
There was a problem hiding this comment.
Please make sure they're all tested. If a PR is not tested or still in progress, mark them as draft or change the PR title to something like "[WIP] Add hitboxes"
.../java/com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinChestBlock.java
Outdated
Show resolved
Hide resolved
.../java/com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinChestBlock.java
Show resolved
Hide resolved
...n/java/com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinDoorBlock.java
Outdated
Show resolved
Hide resolved
...n/java/com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinDoorBlock.java
Outdated
Show resolved
Hide resolved
.../viaversion/viafabricplus/injection/mixin/features/block/shape/MixinEndPortalFrameBlock.java
Outdated
Show resolved
Hide resolved
.../com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinEnderChestBlock.java
Show resolved
Hide resolved
...va/com/viaversion/viafabricplus/injection/mixin/features/block/shape/MixinTrapdoorBlock.java
Outdated
Show resolved
Hide resolved
Exterminate5573
changed the title
Contributor
Author
|
|
Contributor
Author
|
All values have been triple checked and are correct |
FlorianMichael
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes i tested them this time (sorry)
Fixes #918