Skip to content

Commit

Permalink
Add FAQ and Contact links to ListWidget; update terminology from Modu… (
Browse files Browse the repository at this point in the history 
#668)

* Add FAQ and Contact links to ListWidget; update terminology from Modules to Subjects

* Add step to install WebKit dependencies in Playwright workflow

* Update WebKit dependency version in Playwright workflow

* Enhance Playwright workflow by adding specific WebKit dependencies installation and clearing Playwright cache before installation

* Update WebKit dependencies installation to use correct ICU version and streamline installation process

* Refactor WebKit dependencies installation in Playwright workflow to include specific ICU version and streamline installation process

* Update upload-artifact action to version 4 in Playwright workflow

* added libvpx7

* Refactor Playwright workflow to improve caching and streamline WebKit dependencies installation

* Update WebKit dependencies with correct package versions in Playwright workflow

* Refactor Playwright workflow to let Playwright handle dependencies installation

* remove webkit

* Remove WebKit configuration from Playwright setup

* add to playwright to depenencies

* save

* save

* update web server command in Playwright config to use 'npm run dev'

* Update Playwright config to run build before starting server and extend ESLint rules for devDependencies
  • Loading branch information
@jeromehardaway
jeromehardaway authored Dec 19, 2024
1 parent 89b13e9 commit 1bcbc5f
Show file tree
Hide file tree
Showing 11 changed files with 1,368 additions and 1,577 deletions.
219 changes: 115 additions & 104 deletions .eslintrc.json
View file
Original file line number Diff line number Diff line change
@@ -1,105 +1,116 @@
{
"extends": [
"next/core-web-vitals",
"airbnb",
"airbnb-typescript",
"prettier",
"plugin:@typescript-eslint/recommended"
],
"plugins": ["react", "@typescript-eslint", "prettier"],
"env": {
"browser": true,
"es2023": true,
"node": true
},
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "./tsconfig.json",
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": "latest",
"sourceType": "module"
},
"rules": {
"@typescript-eslint/no-misused-promises": [
"error",
{
"checksConditionals": false,
"checksVoidReturn": false
}
],
"no-underscore-dangle": "off",
"react/react-in-jsx-scope": "off",
"react/prop-types": "off",
"react/require-default-props": "off",
"react/default-props-match-prop-types": "off",
"react/jsx-props-no-spreading": "off",
"import/prefer-default-export": "off",
"no-param-reassign": "off",
"import/extensions": [
"error",
"ignorePackages",
{
"ts": "never",
"tsx": "never"
}
],
"import/no-unresolved": "error",
"consistent-return": "off",
"arrow-body-style": "off",
"prefer-arrow-callback": "off",
"react/jsx-filename-extension": ["error", { "extensions": [".tsx", ".jsx"] }],
"react/function-component-definition": [
"error",
{
"namedComponents": "arrow-function",
"unnamedComponents": "arrow-function"
}
],
"prettier/prettier": "warn",
"jsx-a11y/anchor-is-valid": [
"error",
{
"components": ["Link"],
"specialLink": ["hrefLeft", "hrefRight"],
"aspects": ["invalidHref", "preferButton"]
}
],
"jsx-a11y/label-has-associated-control": [
"error",
{
"required": {
"some": ["nesting", "id"]
}
}
],
"jsx-a11y/control-has-associated-label": "off", // Added this line
"@next/next/no-img-element": "off",
"react/no-danger": "off",
"no-void": ["error", { "allowAsStatement": true }]
},
"settings": {
"react": {
"version": "detect"
},
"import/resolver": {
"typescript": {},
"node": {
"extensions": [".js", ".jsx", ".ts", ".tsx"]
}
}
},
"overrides": [
{
"files": ["*.js"],
"rules": {
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "off"
}
}
]
}
"extends": [
"next/core-web-vitals",
"airbnb",
"airbnb-typescript",
"prettier",
"plugin:@typescript-eslint/recommended"
],
"plugins": ["react", "@typescript-eslint", "prettier"],
"env": {
"browser": true,
"es2023": true,
"node": true
},
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "./tsconfig.json",
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": "latest",
"sourceType": "module"
},
"rules": {
"@typescript-eslint/no-misused-promises": [
"error",
{
"checksConditionals": false,
"checksVoidReturn": false
}
],
"no-underscore-dangle": "off",
"react/react-in-jsx-scope": "off",
"react/prop-types": "off",
"react/require-default-props": "off",
"react/default-props-match-prop-types": "off",
"react/jsx-props-no-spreading": "off",
"import/prefer-default-export": "off",
"no-param-reassign": "off",
"import/no-extraneous-dependencies": [
"error",
{
"devDependencies": [
"**/*.test.ts",
"**/*.test.tsx",
"**/playwright.config.ts",
"tests/**/*"
]
}
],
"import/extensions": [
"error",
"ignorePackages",
{
"ts": "never",
"tsx": "never"
}
],
"import/no-unresolved": "error",
"consistent-return": "off",
"arrow-body-style": "off",
"prefer-arrow-callback": "off",
"react/jsx-filename-extension": ["error", { "extensions": [".tsx", ".jsx"] }],
"react/function-component-definition": [
"error",
{
"namedComponents": "arrow-function",
"unnamedComponents": "arrow-function"
}
],
"prettier/prettier": "warn",
"jsx-a11y/anchor-is-valid": [
"error",
{
"components": ["Link"],
"specialLink": ["hrefLeft", "hrefRight"],
"aspects": ["invalidHref", "preferButton"]
}
],
"jsx-a11y/label-has-associated-control": [
"error",
{
"required": {
"some": ["nesting", "id"]
}
}
],
"jsx-a11y/control-has-associated-label": "off",
"@next/next/no-img-element": "off",
"react/no-danger": "off",
"no-void": ["error", { "allowAsStatement": true }]
},
"settings": {
"react": {
"version": "detect"
},
"import/resolver": {
"typescript": {},
"node": {
"extensions": [".js", ".jsx", ".ts", ".tsx"]
}
}
},
"overrides": [
{
"files": ["*.js"],
"rules": {
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "off"
}
}
]
}
30 changes: 14 additions & 16 deletions .github/workflows/playwright.yml
View file
Original file line number Diff line number Diff line change
@@ -1,25 +1,21 @@
name: Playwright Tests

on:
push:
branches: [main, master]
pull_request:
branches: [main, master]

jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Cache node modules
uses: actions/cache@v4
env:
cache-name: cache-node-modules
with:
# This path is platform dependent; use **/node_modules for Windows
path: |
node_modules
**/node_modules
Expand All @@ -28,14 +24,14 @@ jobs:
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
- uses: actions/setup-node@v3
with:
node-version-file: '.nvmrc'

- name: Install dependencies
run: yarn

- name: Cache Playwright Browsers
uses: actions/cache@v4
with:
Expand All @@ -44,16 +40,18 @@ jobs:
key: ${{ runner.os }}-playwright-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-playwright-
- name: Install Playwright Browsers
run: yarn playwright install --with-deps

- name: Install Playwright and browsers
run: yarn playwright install --with-deps chromium firefox
- name: Run Playwright tests
run: yarn playwright test

- uses: actions/upload-artifact@v3
run: |
yarn build
yarn playwright test --project=chromium --project=firefox
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30
retention-days: 30
2 changes: 1 addition & 1 deletion next-env.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.
Loading

0 comments on commit 1bcbc5f

Please sign in to comment.