-
Notifications
You must be signed in to change notification settings - Fork 224
feat: add custom MCP #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add custom MCP #1416
Conversation
lib/src/mcp/mcp_command.dart
Outdated
| import 'package:dart_mcp/server.dart'; | ||
| import 'package:dart_mcp/stdio.dart'; | ||
| import 'package:mason/mason.dart'; | ||
| // Note: stream_channel is a transitive dependency via dart_mcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add it as direct dependency then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
lib/src/mcp/mcp_command.dart
Outdated
| ) | ||
| ..info( | ||
| ''' | ||
| - packages_check: Verify package licenses for compliance and validation in a Dart or Flutter project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change the name of this to be more self-explanatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, at this level we can put whatever name we want for the tool. Any suggestions for this one and others?
check_packages_licenses for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would join the current commands on the CLI with underscores, in this case: packages_check_licenses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
marcossevilla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! but let's wait for another review from @RuiMiguel and @omartinma
|
LGTM! Thanks @RuiMiguel and @PabloTortosaLopez for finishing this up 🚀 |
Status
READY
Description
Added MCP support to CLI
Type of Change