Skip to content

Add timeout to notebook session lookup #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
massy-o wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add timeout to notebook session lookup #4630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/verta/verta/_internal_utils/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,6 +1297,7 @@ def get_notebook_filepath():
response = requests.get(
urljoin(server["url"], "api/sessions"),
params={"token": server.get("token", "")},
timeout=5,
Copy link
Copy Markdown
Author

@massy-o massy-o May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: This lookup runs against locally listed notebook servers, so a short timeout is enough to avoid blocking forever while preserving the existing behavior of trying the remaining servers and eventually raising OSError.

)
if response.ok:
for session in body_to_json(response):
Expand Down