Nft Product Bug #515
Merged
Nft Product Bug #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/nft/intersection.cc:210
- Extra semicolon detected which might indicate a copy-paste error; please remove the redundant semicolon.
State product_source = worklist.back();;
Co-authored-by: Copilot <[email protected]>
jurajsic
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
nft::algorithms::productwhen usingJumpMode::RepeatSymbol. It closes issue #512, where the bug was reported.When using
JumpMode::RepeatSymbol, the computation of the product waits in a source state that has a deeper target. This waiting in old states caused the creation of unexpected transitions from levelnto leveln.To fix this, we now forbid, in the next iteration, transitions that have already been visited — no matter the fact that we may wait in the source state.