feat(BetterRoleContext, ViewRaw, PermissionsViewer): improvments #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s prop to context menus; assign modalKey to permissions modal
…display sorting; support for PermissionsViewer plugin; make patch appliable for list of guild roles
Vendicated
reviewed
Oct 12, 2025
Comment on lines
+87
to
+101
| const contextItems = copyableRoleProperties.reduce((acc, propertyInfo) => { | ||
| const propertyValue = propertyInfo.value(role); | ||
|
|
||
| if (propertyValue) | ||
| acc.push( | ||
| <Menu.MenuItem | ||
| id={propertyInfo.id} | ||
| label={propertyInfo.name} | ||
| icon={propertyInfo.icon} | ||
| action={() => copyToClipboard(propertyValue)} | ||
| /> | ||
| ); | ||
|
|
||
| return acc; | ||
| }, [] as React.ReactElement[]); |
There was a problem hiding this comment.
use .map() and just return null to render nothing
| contextMenus: { | ||
| "guild-context": MakeContextCallback("Guild"), | ||
| "guild-settings-role-context": MakeContextCallback("Role"), | ||
| "vc-permviewer-role-context-menu": MakeContextCallback("Role"), |
There was a problem hiding this comment.
don't do this. just make the plugin export a function like buildContextMenuEntries() and import that
|
|
||
| children = p.children; | ||
| } else { | ||
| if (!Vencord.Plugins.isPluginEnabled("BetterRoleContext")) { |
| const GuildSettingsActions = findByPropsLazy("open", "selectRole", "updateGuild"); | ||
|
|
||
| const DeveloperMode = getUserSettingLazy("appearance", "developerMode")!; | ||
| const DeveloperMode = getUserSettingLazy("appearance", "developerMode"); |
There was a problem hiding this comment.
undo this change
Suggested change
| const DeveloperMode = getUserSettingLazy("appearance", "developerMode"); | |
| const DeveloperMode = getUserSettingLazy("appearance", "developerMode")!; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PermissionsViewer:
Copy User/Role IDandView Server As RolecontextMenuAPIArgumentsprop to context menus to use in ViewRaw & BetterRoleContext pluginsmodalKeytoViewPermissionsmodal to close it onEdit Rolebutton clickViewRaw:
PermissionsViewerplugin to open role/user rawBetterRoleContext:
#000 #000format) / role icon urlCopy User/Role IDbutton > copy buttons from plugin >View RawPermissionsViewerplugin to copy some properties