Add plugin ui customisation options #3693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendicated
commented
Oct 2, 2025
| function VencordChatBarButtons(props: ChatBarProps) { | ||
| // FIXME: subscribing to all settings here is bad, but the settings api currently | ||
| // only supports exact key subscriptions, which doesn't work for our use case | ||
| const { chatBarButtons } = useSettings().uiElements; |
There was a problem hiding this comment.
TODO: we should probably fix this before merging to avoid unnecessary rerenders
Vendicated
commented
Oct 2, 2025
|
|
||
| // FIXME: subscribing to all settings here is bad, but the settings api currently | ||
| // only supports exact key subscriptions, which doesn't work for our use case | ||
| const { messagePopoverButtons } = useSettings().uiElements; |
Vendicated
commented
Oct 2, 2025
| .filter(([key]) => messagePopoverButtons[key]?.enabled !== false) | ||
| .map(([key, { render }]) => { | ||
| try { | ||
| // FIXME: this should use proper React to ensure hooks work |
There was a problem hiding this comment.
probably better done in a separate PR but still needs fixing in the future
Vendicated
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to toggle plugin ChatBar and MessagePopover buttons.
We could also allow hiding stock Discord buttons in the future but that will require more code / patches
Screencast.From.2025-10-02.23-40-55.mp4