Add hardware breakpoint support #950
Merged
+3,063
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xusheng6
force-pushed
the
test_hardware_breakpoint_2
branch
from
3229306 to
d2bb5be
Compare
plafosse
reviewed
Jan 9, 2026
api/python/debuggercontroller.py
Outdated
| """ | ||
| def __init__(self, module, offset, address, enabled, condition=""): | ||
| def __init__(self, module, offset, address, enabled, condition="", bp_type=DebugBreakpointType.BNSoftwareBreakpoint, size=1): |
Member
There was a problem hiding this comment.
Seems like this should really be a dataclass. I think this would clean up this class a bunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix github.com/Vector35/debugger/isses/53