Skip to content

Enable Ruff check PLR0915 #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Enable Ruff check PLR0915 #2034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ ignore = [
# Ignore "too-many-*" errors as they seem to get in the way more than
# helping.
"PLR0913",
"PLR0915",
# Allow 'assert' in tests as it is the standard for pytest.
# Also, allow 'assert' in other code as it is the standard for Python type hint
# narrowing - see
Expand Down
14 changes: 4 additions & 10 deletions tests/mock_vws/test_docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import requests
from docker.errors import BuildError, NotFound # type: ignore[import-untyped]
from docker.models.containers import Container # type: ignore[import-untyped]
from docker.models.networks import Network # type: ignore[import-untyped]
from mock_vws.database import VuforiaDatabase
from tenacity import retry
from tenacity.retry import retry_if_exception_type
Expand All @@ -26,6 +25,7 @@
from collections.abc import Iterator

from docker.models.images import Image # type: ignore[import-untyped]
from docker.models.networks import Network # type: ignore[import-untyped]


# We do not cover this function because hitting particular branches depends on
Expand Down Expand Up @@ -81,7 +81,6 @@ def fixture_custom_bridge_network() -> Iterator[Network]:
driver="nat",
)

assert isinstance(network, Network)
try:
yield network
finally:
Expand Down Expand Up @@ -138,8 +137,9 @@ def test_build_and_run(
"no matching manifest for windows/amd64" not in exc.msg
): # pragma: no cover
raise AssertionError(full_log) from exc
reason = "We do not currently support using Windows containers."
pytest.skip(reason)
pytest.skip(
reason="We do not currently support using Windows containers."
)

vwq_image, _ = client.images.build(
path=str(repository_root),
Expand Down Expand Up @@ -191,13 +191,9 @@ def test_build_and_run(
},
)

assert isinstance(target_manager_container, Container)
assert isinstance(vws_container, Container)
assert isinstance(vwq_container, Container)
for container in (target_manager_container, vws_container, vwq_container):
container.reload()

assert isinstance(target_manager_container.attrs, dict)
target_manager_port_attrs = target_manager_container.attrs[
"NetworkSettings"
]["Ports"]
Expand All @@ -209,12 +205,10 @@ def test_build_and_run(
"HostPort"
]

assert isinstance(vws_container.attrs, dict)
vws_port_attrs = vws_container.attrs["NetworkSettings"]["Ports"]
vws_host_ip = vws_port_attrs["5000/tcp"][0]["HostIp"]
vws_host_port = vws_port_attrs["5000/tcp"][0]["HostPort"]

assert isinstance(vwq_container.attrs, dict)
vwq_port_attrs = vwq_container.attrs["NetworkSettings"]["Ports"]
vwq_host_ip = vwq_port_attrs["5000/tcp"][0]["HostIp"]
vwq_host_port = vwq_port_attrs["5000/tcp"][0]["HostPort"]
Expand Down