Skip to content

Use Paths rather than strings where possible#1040

Closed
oscargus wants to merge 1 commit intoVUnit:masterfrom
oscargus:pathlib
Closed

Use Paths rather than strings where possible#1040
oscargus wants to merge 1 commit intoVUnit:masterfrom
oscargus:pathlib

Conversation

@oscargus
Copy link
Contributor

Avoids quite a bit of conversions back and forth.

Also add some typing to make it easier to remember...

@oscargus oscargus force-pushed the pathlib branch 4 times, most recently from 1bde33f to d2865ed Compare July 11, 2024 14:58
@oscargus
Copy link
Contributor Author

oscargus commented Jul 11, 2024

The !s specifier is not required (unless a special case where one would like to override specifiers in the string). There are 200 or so remaining locations, but I changed where I saw them.

The cwd argument can be a Path. A bit unsure about the other arguments though, so still use strings there.

@oscargus oscargus marked this pull request as ready for review July 11, 2024 16:36
@oscargus
Copy link
Contributor Author

Probably should do this in a more systematic way later, so closing.

@oscargus oscargus closed this Apr 25, 2025
@oscargus oscargus deleted the pathlib branch April 25, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments