-
Notifications
You must be signed in to change notification settings - Fork 102
propagate custom constructor of base class through abstract class in inheritance chain #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PetrShumilov
merged 3 commits into
master
from
pshumilov/fix_trying_to_access_property_of_null_object
Apr 3, 2025
Merged
propagate custom constructor of base class through abstract class in inheritance chain #1272
PetrShumilov
merged 3 commits into
master
from
pshumilov/fix_trying_to_access_property_of_null_object
Apr 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Shumilov <[email protected]>
69ae06b
to
c3e49d9
Compare
mkornaukhov03
previously approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Petr Shumilov <[email protected]>
c3e49d9
to
da31259
Compare
a8a36d6
to
2ff6d77
Compare
ZemlyakovDmitry
previously approved these changes
Apr 2, 2025
142d0bf
to
f797ee1
Compare
Signed-off-by: Petr Shumilov <[email protected]>
f797ee1
to
6158ae7
Compare
ZemlyakovDmitry
approved these changes
Apr 3, 2025
mkornaukhov03
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following code:
should lead to output like this:
Currently, we get empty output due to incorrect code gen. Constructor of class
C
looks like:Constructor for
A
has not been generated