Change branch_names type to tuple #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Python documentation, 'sets do not record element position or order of insertion' and the ordering of the elements is not deterministic, i.e. might change with the random seed or other seemingly irrelevant operations (in my case it changed with changing the test batch size). If the order of branches changes, attempting to load a model will result in layer name mismatch, and hence the layers being incorrectly populated with random weights, preventing the reproducibility of results in testing. Changing the type of branch_names to tuple ensures the object is still immutable and has deterministic behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Python documentation, 'sets do not record element position or order of insertion' and the ordering of the elements is not deterministic, i.e. might change with the random seed or other seemingly irrelevant operations (in my case it changed with changing the test batch size). If the order of branches changes, attempting to load a model will result in layer name mismatch, and hence the layers being incorrectly populated with random weights, preventing the reproducibility of results in testing. Changing the type of branch_names to tuple ensures the object is still immutable and has deterministic behaviour.