Add documentation for Delta Sharing node type #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritesh.K <[email protected]>
Signed-off-by: Ritesh.K <[email protected]>
stv0g
requested changes
Oct 16, 2025
|
|
||
| Supported Keys: | ||
|
|
||
| - `profile_path` (string, required): Path to a Delta Sharing profile file. |
There was a problem hiding this comment.
Are these referring to the configuration file? If so, please move them to the configuration section.
Please try to follow the same structure as in the other node-type pages.
| - `profile_path` (string, required): Path to a Delta Sharing profile file. | ||
| - `cache_dir` (string, optional): Local directory for caching fetched parquet files. | ||
| - `table_path` (string, required for `read`/`write`): Table path in the format `server#share.schema.table`. | ||
| - `op` (string, optional): One of `read`, `write`, `noop`. Defaults to `noop`. |
There was a problem hiding this comment.
Please try to avoid abbreviations for options. A full operation is easier to understand by the user.
|
|
||
| ## Prerequisites | ||
|
|
||
| - A reachable Delta Sharing server and a valid Delta Sharing profile path (`profile_path`). |
There was a problem hiding this comment.
Can we please add some hyperlinks to the project of the delta sharing server, as well as add the exact name of the libraries and links which need to be installed as a pre-requisite?
Please make sure to add these new dependencies also to this table, as well as the two command invocations below it (apt|dnf install):
Comment on lines
+36
to
+38
| type = "delta_sharing" | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| type = "delta_sharing" | |
| type = "delta_sharing" | |
Co-authored-by: Steffen Vogel <[email protected]> Signed-off-by: RiteshKarki27 <[email protected]>
Co-authored-by: Steffen Vogel <[email protected]> Signed-off-by: RiteshKarki27 <[email protected]>
Co-authored-by: Steffen Vogel <[email protected]> Signed-off-by: RiteshKarki27 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new lab (lab 21) for Delta Sharing node type.