Open
Conversation
This commit achieves the following: - renames disaggregation/groupby variables according to new template - renames specific survey responses based on new template
made in the new template. The commit achieves the following: - Conduct testing at 2 separate points to avoid template merge from interfering with testing results. - Debug incorrect filtering of responses. - Filter out "Religion" ntee codes earlier for readability. - Renames filtertype, filteropt, splitbyopt based on recent template - Stop filtering out invalid responses using num_responses, this should be done in the transformation layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should've pushed the year 5 to the dev branch so it could make the push request easier but I only pushed the new file.