Make spammy logs slightly less spammy. Clarify out-of-devices warning. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running rotom with a high workers-to-devices ratio (in my case nearly 200) and with a device cooldown enabled (my mistake, and fixed now) the logs are extremely spammy, with hundreds or thousands of the same message printed per second, since it is printed once per unavailable worker, per connection attempt.
This PR moves the extremely spammy message down to
debuglevel, and also makes the error printed to the log more concise and offers troubleshooting instructions so that future users are more easily able to resolve it.Example of two seconds of the log spam in question:
rotom-spam.log
I've tested this change by building it into a docker container and running it on my unown stack.