Don't unset properties just default to null

Universal-Omega · Feb 10, 2025 · 1617c15 · 1617c15
1 parent 3f27d39
commit 1617c15
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/includes/services/PortableInfoboxDataService.php b/includes/services/PortableInfoboxDataService.php
@@ -146,9 +146,7 @@ public function save( NodeInfobox $raw ) {
 	 */
 	public function delete() {
 		$this->clear();
-
-		// @phan-suppress-next-line PhanTypeObjectUnsetDeclaredProperty
-		unset( $this->cache );
+		$this->cache = null;
 
 		return $this;
 	}
@@ -158,16 +156,14 @@ public function delete() {
 	 */
 	public function purge() {
 		$this->memcached->delete( $this->cachekey );
-
-		// @phan-suppress-next-line PhanTypeObjectUnsetDeclaredProperty
-		unset( $this->cache );
+		$this->cache = null;
 
 		return $this;
 	}
 
 	// soft cache handlers
 	protected function get() {
-		if ( !isset( $this->cache ) ) {
+		if ( !$this->cache ) {
 			$this->cache = $this->load();
 		}