Skip to content

fix: resolve failing pre-commit hooks by formatting SVGs and newlines#491

Merged
wry-ry merged 1 commit into
mainfrom
fix-svg-formatting-and-newlines
May 29, 2026
Merged

fix: resolve failing pre-commit hooks by formatting SVGs and newlines#491
wry-ry merged 1 commit into
mainfrom
fix-svg-formatting-and-newlines

Conversation

@ptiper
Copy link
Copy Markdown
Contributor

@ptiper ptiper commented May 29, 2026

Description

This PR resolves the repository issue where local and CI pre-commit and pre-push git hooks were failing due to formatting violations.

Causes

Solution:

  • Ran pre-commit locally to auto-format all 23 partner SVGs, .linkignore, and docs/index.md into absolute compliance.
  • All style and formatting checks now pass successfully in the local pre-commit environment!

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

@ptiper ptiper requested review from a team as code owners May 29, 2026 16:51
@ptiper ptiper requested review from aksbro-gpu, cusell-google, richmolj and wry-ry and removed request for aksbro-gpu, cusell-google and richmolj May 29, 2026 16:51
@wry-ry wry-ry merged commit ac16a3a into main May 29, 2026
16 checks passed
@wry-ry wry-ry deleted the fix-svg-formatting-and-newlines branch May 29, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants