feat: add serving instructions to the end of the build script output#432
Open
pemamian wants to merge 2 commits into
Open
feat: add serving instructions to the end of the build script output#432pemamian wants to merge 2 commits into
pemamian wants to merge 2 commits into
Conversation
pemamian
requested review from
dwdii,
knightlin-shopify,
nicholasjameshall and
richmolj
dwdii
approved these changes
May 12, 2026
Contributor
Author
|
these was removed by prior commits, returning them back. |
damaz91
reviewed
May 21, 2026
| echo " python3 -m http.server 8000 -d $OUTPUT_DIR" | ||
| echo "" | ||
| echo "Alternative (faster for live editing current version):" | ||
| echo " uv run mkdocs serve" |
Contributor
There was a problem hiding this comment.
i'm not convinced "uv run mkdocs serve" produces the exact same result of "python3 -m http.server 8000 -d $OUTPUT_DIR"; also, we added the instruction of 136 in #452 so i'm not sure it's super useful to have it printed in the output of the script as well
Contributor
Author
There was a problem hiding this comment.
although #452 is explaining the issue, we want to encourage developer builds and helping them see the issues sooner. These instructions used to be in the file before some update removed them. (personally useful)
-- no comment on the different of python3 vs uv run mkdocs serve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
instruction for hosting docs locally after successful local build.
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
Screenshots / Logs (if applicable)