feat: automate stale and abandon PR detection and labeling#41
Open
pemamian wants to merge 11 commits into
Open
feat: automate stale and abandon PR detection and labeling#41pemamian wants to merge 11 commits into
pemamian wants to merge 11 commits into
Conversation
feat: automate stale and abandon PR detection and labeling
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
pemamian
requested review from
cusell-google,
dwdii,
kmcduffie,
ptiper and
wry-ry
ptiper
reviewed
May 22, 2026
| ADDITIONAL_ABANDON_DAYS = 30 | ||
| ABANDON_THRESHOLD_DAYS = STALE_THRESHOLD_DAYS + ADDITIONAL_ABANDON_DAYS | ||
|
|
||
| # Label Constants |
Contributor
There was a problem hiding this comment.
Make sure to create the labels before merging :)
Author
There was a problem hiding this comment.
I think github automatically creates labels that don't exist. (based on small tests I've done)
| is_stale = updated_at < stale_limit | ||
| is_abandon_candidate = updated_at < abandon_limit | ||
|
|
||
| # Determine matching category |
Contributor
There was a problem hiding this comment.
Should we have a label removal logic too? If the PR is active again?
|
|
||
| # Determine matching category | ||
| is_stale_review = is_stale and (LABEL_UNDER_REVIEW in labels) | ||
| is_blocked_abandon = is_abandon_candidate and (LABEL_BLOCKED in labels) |
Contributor
There was a problem hiding this comment.
Is abandon just for blocked PRs?
|
|
||
| if missing_labels: | ||
| print(f'[ACTION] PR #{pr.number} "{pr.title}" is inactive. Adding missing labels: {missing_labels}') | ||
| # PyGithub add_to_labels accepts iterable of strings or label objects |
Contributor
There was a problem hiding this comment.
Since iterables are accepted, why not pass them instead of making multiple API calls?
Author
There was a problem hiding this comment.
reduces unnecessary 'add' calls that could cause a notification.
…ff-peak cron scheduling, and robust error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
!for breaking changes).Screenshots / Logs (if applicable)