Skip to content

Mac editor oop poc #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MindWrapper wants to merge 4 commits into
base: unity-main
Choose a base branch
from
Draft

Mac editor oop poc #2215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87d33e7
Build oop on mac
MindWrapper Feb 15, 2026
74c17a7
try to make other OOP functions cross-platoform
MindWrapper Feb 24, 2026
f2cb77c
Rollback some unnecessary changes
MindWrapper Mar 5, 2026
22724ac
Minimize amount of changes
MindWrapper Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mono/metadata/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ endif
common_sources = \
$(platform_sources) \
$(unity_sources) \
oop.c \
appdomain.c \
assembly-load-context.c \
domain.c \
Expand Down
8 changes: 4 additions & 4 deletions mono/metadata/oop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ gsize read_nt_string(char* buffer, gsize max_size, const void* address)
}

// Ensure there's a null-terminator
buffer[min(read, max_size-1)] = '\0';
buffer[MIN(read, max_size-1)] = '\0';

return read;
}
Expand Down Expand Up @@ -425,7 +425,7 @@ mono_unity_oop_get_stack_frame_details(
const MonoMethod* method = read_pointer(OFFSET_MEMBER(MonoJitInfo, ji, d.method));
const MonoClass* klass = read_pointer(OFFSET_MEMBER(MonoMethod, method, klass));
const MonoImage* image = read_pointer(OFFSET_MEMBER(MonoClass, klass, image));
size_t classNameLen = max(frameDetails->classNameLen, 256);
size_t classNameLen = MAX(frameDetails->classNameLen, 256);
char* className = (char*)malloc(classNameLen);
char* nsName = (char*)malloc(classNameLen);

Expand All @@ -446,14 +446,14 @@ mono_unity_oop_get_stack_frame_details(
read_pointer(OFFSET_MEMBER(MonoClass, klass, name)));

if (*nsName) {
frameDetails->classNameLen = sprintf_s(
frameDetails->classNameLen = g_snprintf(
frameDetails->className,
frameDetails->classNameLen,
"%s.%s",
nsName,
className);
} else {
frameDetails->classNameLen = sprintf_s(
frameDetails->classNameLen = g_snprintf(
frameDetails->className,
frameDetails->classNameLen,
"%s",
Expand Down