Fix conflicting exported Brotli APIs #2149
Open
+2,246
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnityAlex
force-pushed
the
6000.3-fix-uum-108000
branch
from
a2a532e to
daed7bc
Compare
Windows always uses system Brotli lib and needs to be handled differently.
UnityAlex
force-pushed
the
6000.3-fix-uum-108000
branch
from
daed7bc to
bf8fe71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono includes and builds the source for the Brotli compression algorithm in its platform specific native library. Since mono dlopens this library the APIs used are exported. However, no changes have been made to the function names allowing for conflicts to happen with other loaded versions of Brotli that might be present. MacOS, for example, provides its own Brotli library and collisions will occur resulting in crashes when Brotli is used there.
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed UUM-108000 @UnityAlex:
Mono: Fixed crash that would occur due to symbol collision between builtin Brotli compression and system installed versions.