Repository navigation
fix: Private nested types in NetworkVariables in CoreCLR #4239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6624e66
fix: Private nested types in NetworkVariables in CoreCLR
EmandM bb3347e
Update CHANGELOG and upgrade-guide
EmandM b1fa613
Merge branch 'develop-3.x.x' into fix/networkVariable-CoreCLR
NoelStephensUnity c4dcbb5
Merge branch 'develop-3.x.x' into fix/networkVariable-CoreCLR
EmandM 366fc35
Update com.unity.netcode.gameobjects/Documentation~/upgrade-guide.md
EmandM 4de1e34
Fix U-PR comments
EmandM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InitializeSerializationstill fails on CoreCLR whenNetworkVariable<Payload>uses a referenced base'sprotected internalnested enum without friend access. A derivedNetworkBehaviourcan legally declare that field using protected access.GetAllFieldsAndResolveGenericscollectsPayload, but this predicate does not checkIsNestedFamilyOrAssembly. The generatedNetworkVariableSerializationHelpercannot accessPayloadbecause the helper is outside the base's assembly and inheritance hierarchy. Pass the consuming assembly intoCollectTypesHiddenFromAssembly. RejectIsNestedFamilyOrAssemblytypes when that assembly lacks internal or friend access.🤖 Helpful? 👍/👎