Skip to content

fix: non-authority player instance spawns with no motion #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NoelStephensUnity
Copy link

Description

Fixes issue where a non-authority player instance could improperly initialize when two clients are connecting to the same session at the "relative" same time. Removing spam logging on collision messages.

Issue Number(s)

Based on NGO user issue #3412

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

Fixes issue where a non-authority player instance could improperly initialize when two clients are connecting to the same session at the "relative" same time.
Removing spam logging on collision messages.
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- we just have to target develop and add an addition to the changelog!

@RikuTheFuffs RikuTheFuffs changed the base branch from main to develop July 14, 2025 14:30
@RikuTheFuffs
Copy link
Contributor

I moved the target to develop as requested by @fernando-cortez . @NoelStephensUnity could you please resync the branch, and add a changelog line so we can merge this?

@NoelStephensUnity
Copy link
Author

I moved the target to develop as requested by @fernando-cortez . @NoelStephensUnity could you please resync the branch, and add a changelog line so we can merge this?

  • develop branch has been merged. 👍
  • added two change log entries. 👍

@RikuTheFuffs Let me know if there is anything else needed for this PR?
(I also validated the the fix after having merged the develop branch)

@NoelStephensUnity
Copy link
Author

@fernando-cortez
Not sure why the above tests are failing... as they are failing in other areas of the repository.

@fernando-cortez
Copy link
Collaborator

@fernando-cortez Not sure why the above tests are failing... as they are failing in other areas of the repository.

I'll take a look!

@fernando-cortez fernando-cortez merged commit 26d7d67 into develop Jul 29, 2025
32 checks passed
@fernando-cortez fernando-cortez deleted the fix/player-spawn-no-motion-non-authority-side branch July 29, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants