Exclude AssimpNet/win DLLs from WebGL builds #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the same project, we use URDF-Importer in Unitye Editor, but we also have scenes that are built for WebGL. As noted in Unity-Technologies#201 WebGL builds of a project that has URDF-Importer package always fail, even if URDF-Importer is not used during runtime. This commit marks the conflicting plugins to exclude WebGL. NOTE: URDF-Importer scripts will not be usable in WebGL builds: Runtime/Unity.Robotics.URDFImporter.asmdef still excludes WebGL. This change allows scenes that don't use URDF-Importer to build.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
In the same Unity project, we use URDF-Importer in Unity Editor, but we also have scenes that should be built for WebGL.
As noted in #201 WebGL builds of a project that has URDF-Importer package always fail, even if URDF-Importer is not used during runtime.
This commit marks the conflicting plugins to exclude WebGL.
NOTE: URDF-Importer scripts will not be usable in WebGL builds: Runtime/Unity.Robotics.URDFImporter.asmdef still excludes WebGL. This change allows scenes that don't use URDF-Importer to build.
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
#201
Types of change(s)
Testing and Verification
Build a scene that doesn't use URDF-Importer runtime components, while the Unity project has URDF-Importer package
Test Configuration:
Checklist
devbranchdevbranchOther comments