Internal/6000.0/staging

Packages/com.unity.render-pipelines.core/.buginfo

@@ -1,5 +1,5 @@
 rule1:
-  area: SRP Architecture & API
+  area: SRP Foundation
 
 rule2:
   when:

Packages/com.unity.render-pipelines.core/Documentation~/Look-Dev-Environment-Library.md

@@ -4,7 +4,7 @@ An Environment Library is an Asset that contains a list of environments that you
 
 <a name="Creation"></a>
 
-![](Images/LookDevEnvironmentLibrary1.png)
+![Environment Library asset.](Images/LookDevEnvironmentLibrary1.png)
 
 ## Creating an Environment Library
 
@@ -26,13 +26,13 @@ To add, remove, or duplicate environments, use the toolbar at the bottom of the
 
 | **Button**                                                   | **Function**  | **Description**                                              |
 | ------------------------------------------------------------ | ------------- | ------------------------------------------------------------ |
-| ![](Images/LookDevEnvironmentLibrary2.png) | **Add**       | Click this button to add a new environment to the bottom of the list. |
-| ![](Images/LookDevEnvironmentLibrary3.png) | **Remove**    | Click this button to remove the environment currently selected. Note that the environment that you have selected is the one with the blue frame. |
-| ![](Images/LookDevEnvironmentLibrary4.png)                   | **Duplicate** | Click this button to duplicate the currently selected environment and add it as a new environment to the bottom of the list. |
+| ![This button adds a new environment to the bottom of the list.](Images/LookDevEnvironmentLibrary2.png) | **Add**       | Click this button to add a new environment to the bottom of the list. |
+| ![This button removes the currently selected environment.](Images/LookDevEnvironmentLibrary3.png) | **Remove**    | Click this button to remove the environment currently selected. Note that the environment that you have selected is the one with the blue frame. |
+| ![This button duplicates the currently selected environment.](Images/LookDevEnvironmentLibrary4.png)                   | **Duplicate** | Click this button to duplicate the currently selected environment and add it as a new environment to the bottom of the list. |
 
 ## Properties
 
-![](Images/LookDevEnvironmentLibrary5.png)
+![Environment Library properties](Images/LookDevEnvironmentLibrary5.png)
 
 | **Property**        | **Description**                                              |
 | ------------------- | ------------------------------------------------------------ |

Packages/com.unity.render-pipelines.core/Documentation~/Look-Dev.md

@@ -46,15 +46,15 @@ Use the toolbar in the top-left of the window to change which viewing mode Look
 
 ### Single viewport
 
-![](Images/LookDev1.png)
+![Buttons for switching between viewports 1 and 2.](Images/LookDev1.png)
 
 By default, Look Dev displays a single viewport which contains the Prefab or GameObject you are working with. If you are in another viewing mode, you can click either the number **1** or number **2** button to go back to single view. Each button corresponds to a viewport in Look Dev. Select button **1** to use viewport 1, and button 2 to use viewport **2**.
 
 <a name="MultiView"></a>
 
 ### Multi-viewport
 
-![](Images/LookDev2.png)
+![Buttons for changing the multi-viewport mode.](Images/LookDev2.png)
 
 Use multiple viewports to compare different environments and settings for the same Asset. You can arrange viewports:
 
@@ -73,23 +73,21 @@ When using multiple viewports, it only makes sense to compare different Prefabs
 
 Vertical and horizontal side-by-side viewports show an identical view of your Asset.
 
-![](Images/LookDev3.png)
+![Vertical side-by-side viewport view.](Images/LookDev3.png)
 
 ##### Split-screen
 
 In a split-screen view, there is a red/blue manipulation Gizmo that separates the two viewports. For information on how to use this Gizmo, see [Using the manipulation Gizmo](#ManipulationGizmo).
 
-![](Images/LookDev4.png)
+![Split-screen viewport view.](Images/LookDev4.png)
 
 #### Multi-viewport Camera
 
 By default, Look Dev synchronizes the camera movement for both views. To decouple the Cameras from one another, and manipulate them independently, click the **Synchronized Cameras** button in-between the two numbered Camera buttons.
 
-![](Images/LookDev5.png)
-
 To align the cameras with each other, or reset them, click on the drop-down arrow next to the viewport **2** icon:
 
-![](Images/LookDev6.png)
+![Drop-down options of multi-viewport cameras.](Images/LookDev6.png)
 
 <a name="ManipulationGizmo"></a>
 
@@ -101,13 +99,11 @@ The manipulation Gizmo represents the separation plane between the two viewports
 
 To move the separator, click and drag the straight line of the Gizmo to the location you want.
 
-![](Images/LookDev7.png)
-
 #### Changing the orientation and length
 
 To change the orientation and length of the manipulator Gizmo, click and drag the circle at either end of the manipulator. Changing the length of the Gizmo lets you  set the orientation and [blending](#Blending) values more precisely.
 
-![](Images/LookDev8.png))
+![Click and drag the circle at either end of the gizmo to change its orientation and length.](Images/LookDev8.png)
 
 #### Changing the split in increments
 
@@ -121,7 +117,7 @@ The central white circle on the separator allows you to blend between the two vi
 
 The white circle automatically snaps back into the center when you drag it back. This helps you get back to the default blending value quickly.
 
-![](Images/LookDev9.png)
+![The white circle on the separator lets you change the blending behavior.](Images/LookDev9.png)
 
 ### HDRI environments in Look Dev
 

Packages/com.unity.render-pipelines.core/Documentation~/Rendering-Debugger.md

@@ -127,7 +127,7 @@ public class CustomDebugPanel : MonoBehaviour
 
 Add the script to a GameObject. You should see a new **My Custom Panel** panel in the **Rendering Debugger** window.
 
-![](Images/rendering-debugger.png)
+![Screenshot of the Rendering Debugger window showing a new custom panel.](Images/rendering-debugger.png)
 
 ### Add a control to an existing panel
 

Packages/com.unity.render-pipelines.core/Documentation~/View-Lighting-Tool.md

@@ -17,13 +17,13 @@ Use the **Orbit** and **Elevation** to control the orientation of the light, in
 
 You can use the **Anchor Position Override** to provide a GameObject’s [Transform](https://docs.unity3d.com/ScriptReference/Transform.html) as an anchor point for the Light. This is useful if you want the Light to follow a specific GameObject in the Scene.
 
-![](Images/LightAnchorAnimation.gif)
+<video title="A light uses the main camera as the reference GamObject that controls the rotation of the light. The light rotates synchronously with the camera." src="Images/videos/light-anchor-animation.mp4" width="100%" height="auto" autoplay="true" loop="true" controls></video>
 
 **Note**: The above example uses the Main Camera as the reference Camera that adjusts the light rotation. The Common presets might create a different result in the Scene View if your view isn't aligned with the Main Camera.
 
 You can set a **Position Offset** for this custom Anchor. This is useful if the Transform position of the custom Anchor isn't centered appropriately for the light to orbit correctly around the custom Anchor.
 
-![](Images/LightAnchor0.png)
+![Light Anchor component screenshot. Orbit and Elevation properties display example values that change the orientation of a light.](Images/LightAnchor0.png)
 
 
 The Light Anchor component also includes a list of **Presets** that you can use to set the Light's orientation relative to the main Camera.

Packages/com.unity.render-pipelines.core/Documentation~/add-custom-graphics-setting.md

@@ -37,7 +37,7 @@ public class MySettings : IRenderPipelineGraphicsSettings
   public Material myMaterial;
 }
 ```
-![](Images/customsettings-addsetting.png)<br/>
+![Screenshot of the Project Settings window. The Graphics section contains the new custom settings from the example script.](Images/customsettings-addsetting.png)<br/>
 The **Edit** > **Project Settings** > **Graphics** window with the new custom setting from the example script.
 
 ## Set the default asset for a reference property

Packages/com.unity.render-pipelines.core/Documentation~/add-custom-graphics-settings.md

@@ -37,7 +37,7 @@ public class MySettings : IRenderPipelineGraphicsSettings
 }
 ```
 
-![](Images/customsettings-settingsgroup.png)<br/>
+![Screenshot of the Project Settings window. The Graphics section contains the new custom settings group from the example script.](Images/customsettings-settingsgroup.png)<br/>
 The **Edit** > **Project Settings** > **Graphics** window with the new custom settings group from the example script.
 
 ## Change the display order of settings groups

Packages/com.unity.render-pipelines.core/Documentation~/adding-properties.md

@@ -30,4 +30,4 @@ For example:
 
 Unity shows the new properties in the **Core Render Pipeline** settings section:
 
-![](Images/core_render_pipeline_preference_provider.png)
+![Screenshot of the Preferences window showing the new properties in the Core Render Pipeline settings section.](Images/core_render_pipeline_preference_provider.png)

Packages/com.unity.render-pipelines.core/Editor/.buginfo

@@ -1,5 +1,5 @@
 rule1:
-  area: SRP Architecture & API
+  area: SRP Foundation
 
 rule2:
   when:
@@ -15,7 +15,7 @@ rule3:
       - ^.*CoreRenderPipelinePreferences.*$
       - ^.*InspectorCurveEditor.*$
       - ^.*RemoveAdditionalDataUtils.*$
-  area: SRP Workflow
+  area: SRP Settings
 
 rule4:
   when:

Packages/com.unity.render-pipelines.core/Editor/Camera/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Editor/Gizmo/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Editor/Icons/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.cs

@@ -748,16 +748,16 @@ static bool SetBakingContext(List<ProbeVolumePerSceneData> perSceneData)
             for (int i = 0; i < perSceneData.Count; ++i)
             {
                 var data = perSceneData[i];
-                var scene = data.gameObject.scene;
-                var sceneGUID = scene.GetGUID();
+                var sceneGUID = data.sceneGUID;
                 var bakingSet = ProbeVolumeBakingSet.GetBakingSetForScene(sceneGUID);
 
                 if (bakingSet == null)
                 {
                     if (isBakingSingleScene)
                         continue;
 
-                    Debug.LogError($"Scene '{scene.name}' does not belong to any Baking Set. Please add it to a Baking Set in the Adaptive Probe Volumes tab of the Lighting Window.");
+                    var sceneName = data.gameObject.scene.name;
+                    Debug.LogError($"Scene '{sceneName}' does not belong to any Baking Set. Please add it to a Baking Set in the Adaptive Probe Volumes tab of the Lighting Window.");
                     return false;
                 }
 

Packages/com.unity.render-pipelines.core/Editor/Material/.buginfo

@@ -1 +1 @@
-area: Material
+area: Materials

Packages/com.unity.render-pipelines.core/Editor/Settings/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Editor/ShaderGenerator/.buginfo

@@ -1 +1 @@
-area: Material
+area: Materials

Packages/com.unity.render-pipelines.core/Editor/Volume/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Runtime/Camera/.buginfo

@@ -1 +1 @@
-area: SRP Workflow
+area: SRP Settings

Packages/com.unity.render-pipelines.core/Runtime/CommandBuffers/BaseCommandBufer.cs

@@ -50,7 +50,7 @@ protected internal void ThrowIfGlobalStateNotAllowed()
         [Conditional("DEVELOPMENT_BUILD"), Conditional("UNITY_EDITOR")]
         protected internal void ThrowIfRasterNotAllowed()
         {
-            if (m_ExecutingPass != null && !m_ExecutingPass.HasRenderAttachments()) throw new InvalidOperationException($"{m_ExecutingPass.name}: Using raster commands from a pass with no active render targets is not allowed as it will use an undefined render target state. Please set-up the pass's render targets using SetRenderAttachments.");
+            if (m_ExecutingPass != null && !m_ExecutingPass.HasRenderAttachments()) throw new InvalidOperationException($"{m_ExecutingPass.name}: Using raster commands from a pass with no active render target is not allowed as it will use an undefined render target state. Please set up pass render targets using SetRenderAttachments.");
         }
 
         /// <summary>
@@ -71,13 +71,13 @@ protected internal void ValidateTextureHandle(TextureHandle h)
 
                 if (h.IsBuiltin()) return;
 
-                if (!m_ExecutingPass.IsRead(h.handle) && !m_ExecutingPass.IsWritten(h.handle))
+                if (!m_ExecutingPass.IsRead(h.handle) && !m_ExecutingPass.IsWritten(h.handle) && !m_ExecutingPass.IsTransient(h.handle))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is trying to use a texture on the command buffer that was never registered with the pass builder. Please indicate the texture use to the pass builder.");
+                    throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to bind a texture on the command buffer that is not registered by its builder. Please indicate to the pass builder how the texture is used (UseTexture/CreateTransientTexture).");
                 }
                 if (m_ExecutingPass.IsAttachment(h))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is using a texture as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth) but is also trying to bind it as regular texture. Please fix this pass. ");
+                        throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to bind a texture on the command buffer that is already set as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth). A texture cannot be used as both in one pass, please fix its usage in the pass builder.");
                 }
             }
         }
@@ -93,17 +93,17 @@ protected internal void ValidateTextureHandle(TextureHandle h)
         [Conditional("DEVELOPMENT_BUILD"), Conditional("UNITY_EDITOR")]
         protected internal void ValidateTextureHandleRead(TextureHandle h)
         {
-            if(RenderGraph.enableValidityChecks)
+            if (RenderGraph.enableValidityChecks)
             {
                 if (m_ExecutingPass == null) return;
 
-                if (!m_ExecutingPass.IsRead(h.handle))
+                if (!m_ExecutingPass.IsRead(h.handle) && !m_ExecutingPass.IsTransient(h.handle))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is trying to read a texture on the command buffer that was never registered with the pass builder. Please indicate the texture as read to the pass builder.");
+                    throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to read a texture on the command buffer that is not registered by its builder. Please indicate to the pass builder that the texture is read (UseTexture/CreateTransientTexture).");
                 }
                 if (m_ExecutingPass.IsAttachment(h))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is using a texture as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth) but is also trying to bind it as regular texture. Please fix this pass. ");
+                    throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to bind a texture on the command buffer that is already set as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth). A texture cannot be used as both in one pass, please fix its usage in the pass builder.");
                 }
             }
         }
@@ -129,13 +129,14 @@ protected internal void ValidateTextureHandleWrite(TextureHandle h)
                     throw new Exception("Pass '" + m_ExecutingPass.name + "' is trying to write to a built-in texture. This is not allowed built-in textures are small default resources like `white` or `black` that cannot be written to.");
                 }
 
-                if (!m_ExecutingPass.IsWritten(h.handle))
+                if (!m_ExecutingPass.IsWritten(h.handle) && !m_ExecutingPass.IsTransient(h.handle))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is trying to write a texture on the command buffer that was never registered with the pass builder. Please indicate the texture as written to the pass builder.");
+                    throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to write a texture on the command buffer that is not registered by its builder. Please indicate to the pass builder that the texture is written (UseTexture/CreateTransientTexture).");
                 }
                 if (m_ExecutingPass.IsAttachment(h))
                 {
-                    throw new Exception("Pass '" + m_ExecutingPass.name + "' is using a texture as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth) but is also trying to bind it as regular texture. Please fix this pass. ");
+                        throw new Exception($"Pass '{m_ExecutingPass.name}' is trying to bind a texture on the command buffer that is already set as a fragment attachment (SetRenderAttachment/SetRenderAttachmentDepth). A texture cannot be used as both in one pass, please fix its usage in the pass builder.");
+
                 }
             }
         }

Packages/com.unity.render-pipelines.core/Runtime/CommandBuffers/CommandBufferHelpers.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Runtime.CompilerServices;
 using UnityEngine.VFX;
 
 namespace UnityEngine.Rendering
@@ -17,6 +18,7 @@ public struct CommandBufferHelpers
         /// </summary>
         /// <param name="baseBuffer">The CommandBuffer the RasterCommandBuffer should record it's commands to.</param>
         /// <returns>A RasterCommandBuffer that will record its commands to the given buffer.</returns>
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static RasterCommandBuffer GetRasterCommandBuffer(CommandBuffer baseBuffer)
         {
             rasterCmd.m_WrappedCommandBuffer = baseBuffer;
@@ -28,6 +30,7 @@ public static RasterCommandBuffer GetRasterCommandBuffer(CommandBuffer baseBuffe
         /// </summary>
         /// <param name="baseBuffer">The CommandBuffer the RasterCommandBuffer should record it's commands to.</param>
         /// <returns>A ComputeCommandBuffer that will record its commands to the given buffer.</returns>
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static ComputeCommandBuffer GetComputeCommandBuffer(CommandBuffer baseBuffer)
         {
             computeCmd.m_WrappedCommandBuffer = baseBuffer;
@@ -39,6 +42,7 @@ public static ComputeCommandBuffer GetComputeCommandBuffer(CommandBuffer baseBuf
         /// </summary>
         /// <param name="baseBuffer">The CommandBuffer the UnsafeCommandBuffer should record its commands to.</param>
         /// <returns>A UnsafeCommandBuffer that will record its commands to the given buffer.</returns>
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static UnsafeCommandBuffer GetUnsafeCommandBuffer(CommandBuffer baseBuffer)
         {
             unsafeCmd.m_WrappedCommandBuffer = baseBuffer;
@@ -51,6 +55,7 @@ public static UnsafeCommandBuffer GetUnsafeCommandBuffer(CommandBuffer baseBuffe
         /// </summary>
         /// <param name="baseBuffer">The UnsafeCommandBuffer you want to get the engine commandbuffer from.</param>
         /// <returns>A CommandBuffer that will record its commands to the given buffer.</returns>
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static CommandBuffer GetNativeCommandBuffer(UnsafeCommandBuffer baseBuffer)
         {
             return baseBuffer.m_WrappedCommandBuffer;

Packages/com.unity.render-pipelines.core/Runtime/Common/.buginfo

@@ -1,10 +1,10 @@
 rule1:
-  area: SRP Architecture & API
+  area: SRP Foundation
 
 rule2:
   when:
     path:
       - ^.*CoreAttributes.*$
       - ^.*IAdditionalData.*$
       - ^.*Reload.*$
-  area: SRP Workflow
+  area: SRP Settings

Packages/com.unity.render-pipelines.core/Runtime/Common/CoreUnsafeUtils.cs

@@ -69,12 +69,18 @@ public bool TryPush(string v)
             }
 
             /// <summary>
-            /// Pop an element of the queue.
+            /// Try to pop an element of the queue.
             /// </summary>
             /// <param name="v">Output result string.</param>
-            /// <returns>True if an element was succesfuly poped.</returns>
+            /// <returns>True if an element was successfully popped.</returns>
             public bool TryPop(out string v)
             {
+                if (m_ReadCursor + sizeof(int) >= m_BufferEnd)
+                {
+                    v = null;
+                    return false;
+                }
+
                 var size = *(int*)m_ReadCursor;
                 if (size != 0)
                 {
@@ -84,7 +90,7 @@ public bool TryPop(out string v)
                     return true;
                 }
 
-                v = default;
+                v = null;
                 return false;
             }