Internal/2021.3/staging #8124
Merged
Internal/2021.3/staging #8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk not blending UUM-78038 There were issues where blending would occur further than the maximum distance for cascade shadows and could be broken depending on the camera view. The alpha value of EvalShadow_GetSplitIndex is intended for blending between cascades. This is also used where the last cascade and shadowmask are blended, which is why the blending is not working properly. Modified to blend cascade shadows and shadowmask in the same way as URP. The images below compare the modified HDRP and URP. * Blending of cascade shadows and shadowmask.  * To visualize the blending, cascade shadows are represented as 0 (black area) and shadowmask as 0.5 (gray area). Blending occurs at the maximum distance of cascade shadows.  Comparison of original HDRP and modified HDRP as the camera distance increases. You can see that the blending works properly regardless of the distance. * Original  * Modified 
Backport fixes from the following PRs: - https://github.cds.internal.unity3d.com/unity/unity/pull/57104 - https://github.cds.internal.unity3d.com/unity/unity/pull/57144 - https://github.cds.internal.unity3d.com/unity/unity/pull/57377 - https://github.cds.internal.unity3d.com/unity/unity/pull/57397 - https://github.cds.internal.unity3d.com/unity/unity/pull/57449 - https://github.cds.internal.unity3d.com/unity/unity/pull/57488 - https://github.cds.internal.unity3d.com/unity/unity/pull/57532 - https://github.cds.internal.unity3d.com/unity/unity/pull/57161 - https://github.cds.internal.unity3d.com/unity/unity/pull/57564
…U'S if … Issue : https://jira.unity3d.com/browse/UUM-82949 Camera view is not rendered on PowerVR Rogue GE8320 GPU'S if Shadows are enabled in URP Asset and Camera stack contains Overlay Camera's. This is caused by changes done to fix https://jira.unity3d.com/browse/UUM-59572 These changes are now being reverted. There is a PR in trunk which fixes original bug ([UUM-59572](https://jira.unity3d.com/browse/UUM-59572)) without needing the fix that is now being reverted.
…ith a clear coat value of 0 Jira : [UUM-84980](https://jira.unity3d.com/browse/UUM-84980) **Short Description:** When 'Clear Coat'(Surface Option) is activated in the Shader Graph, _MATERIAL_FEATURE_CLEAR_COAT is enabled regardless of the actual Clear Coat value. In this case, if the coatMask value is 0 in the EvaluateBSDF_ScreenSpaceReflection() of Lit.hlsl, there is an issue with specular calculation (no problems arise with small values such as 0.001 or 0.00001). Therefore, I resolve this issue by handling the Clear Coat calculation even when the value is 0. **Long Description:** - When 'Clear Coat'(Surface Option) is activated and the clearCoat value is 0 in the shader graph, the ssrLighting value in EvaluateBSDF_ScreenSpaceReflection() is not zero. - For HDRP/Lit with a 'clear coat' value of 0, the ssrLighting value is 0, 0, 0, 0. (Therefore, no issue occurs) - In the 'Render SSR' pass, during the 'ScreenSpaceReflectionsTracing' call, the rays are killed at the killRay step for HDRP/Lit, but they pass through in the shader graph. - This issue arises due to different normalData.perceptualRoughness values, which are computed in the ForwardDepthPrepass. - During the ForwardDepthPrepass when calculating normalData for each Object, the value changes depending on whether the _MATERIAL_FEATURE_CLEAR_COAT keyword is enabled. - For HDRP/Lit, in LitGUI.cs, the _MATERIAL_FEATURE_CLEAR_COAT is disabled when the clear coat value is 0, but in the shader graph, the keyword is enabled based on the 'Clear Coat'(Surface Option) regardless of the actual Clear Coat value. - Due to the nature of the shader graph, accessing the 'Clear Coat' value of the Fragment Node directly is difficult, and the variable name connected to the Clear Coat value can be set differently for each user, making it challenging to check if the Clear Coat value is 0 in ShaderGraphAPI.cs. (See the code below for reference) ``` float _Property_622a98e8ad5742088e5c548ea3797750_Out_0_Float = _Coat; surface.CoatMask = _Property_622a98e8ad5742088e5c548ea3797750_Out_0_Float; ``` - Therefore, I modified EvaluateBSDF_ScreenSpaceReflection() in Lit.hlsl.
**This is a partial backport based on https://github.cds.internal.unity3d.com/unity/unity/pull/58698 for branch 6000.0/staging** Minor fixes from graphics docs feedback tickets. Jira tickets: - https://jira.unity3d.com/browse/DOCG-6327 - fix link to DOTS instancing docs - https://jira.unity3d.com/browse/DOCG-6328 - remove link to missing sample - https://jira.unity3d.com/browse/DOCG-6294 - remove note from min and max - https://jira.unity3d.com/browse/DOCG-6289 - remove incorrect use of 'naming conventions' - https://jira.unity3d.com/browse/DOCG-5082 - add link to RenderingLayerMask API - https://jira.unity3d.com/browse/DOCG-5803 - add link to depth texture information
…ead-only materials in HDRP **This is a backport of https://github.cds.internal.unity3d.com/unity/unity/pull/59117** Add note about converting read-only materials in HDRP Jira ticket: https://jira.unity3d.com/browse/DOCG-5432
… when the original resolution is odd Fixed black border artifact when using DLSS at certain resolution. The issue is that DRS causes the camera to have odd resolutions which the downsampled SSAO algorithm didn't handled well.
… is disabled
This PR fixes HDRP sky rendering when Camera Relative Rendering is disabled.
`ComputePixelCoordToWorldSpaceViewDirectionMatrix()` in `HDCamera.cs` contains:
```
...
if (useGenericMatrix)
{
var viewSpaceRasterTransform = new Matrix4x4(
new Vector4(2.0f * resolution.z, 0.0f, 0.0f, -1.0f),
new Vector4(0.0f, -2.0f * resolution.w, 0.0f, 1.0f),
new Vector4(0.0f, 0.0f, 1.0f, 0.0f),
new Vector4(0.0f, 0.0f, 0.0f, 1.0f));
var transformT = viewConstants.invViewProjMatrix.transpose * Matrix4x4.Scale(new Vector3(-1.0f, -1.0f, -1.0f));
return viewSpaceRasterTransform * transformT;
}
...
```
Here the view matrix that was used to build `viewConstants.invViewProjMatrix` has translation component if Camera Relative Rendering is disabled when it shouldn't.
Scene View
Game View, bugged
Game View, fixed
Minor docs fixes for January 2025, from user feedback. Part 2. Jira tickets: - https://jira.unity3d.com/browse/DOCG-6479 - move experimental warnings to below h1s - https://jira.unity3d.com/browse/DOCG-6481 - add a link to RenderDoc from shader debugging landing page
… docs **This is a backport of https://github.cds.internal.unity3d.com/unity/unity/pull/59127** Add steps to the 2D sprite lit shader graph URP docs, to clarify connecting up transparency/alpha, and setting the normal map input. Response to user feedback. Jira tickets: - https://jira.unity3d.com/browse/DOCG-6464 - https://jira.unity3d.com/browse/DOCG-6465
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.