Internal/2021.3/staging #8044
Merged
Internal/2021.3/staging #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport for PR#40107 from trunk
Fixing build issues caused by ternary operator use in shaders.
**Primary goal was to update UTR, UTF and GTF (Graphics test framework)** - Backport https://github.cds.internal.unity3d.com/unity/unity/pull/43428. - Backport https://github.cds.internal.unity3d.com/unity/unity/pull/34689. - Bump UTR to 1.28.2 and UTF to 1.3.9, in order to catch up with latest fixes and features. SRP Test projects only. - Bump GTF to 8.3.2. This means updating the client side logic of all `com.unity.testing...` test setup packages as there are breaking changes for android and webgl when switching from GTF 7.x.x. **Then I got some failures in the project that use the performance packages. So I did some cleaning.** - Remove duplicate dependencies in `com.unity.testing.visualeffectgraph`. - Reset `com.unity.testing-graphics-performance` to `12.1.14` (from arbitrary `8.0.0`), as it is always used as a local (in-repo) package and doesn't correspond to any package fetched from artifactory. 12.1.14 allows matching the versionning scheme of the render-pipelines.core dependency, as was discussed [here](https://github.cds.internal.unity3d.com/unity/unity/pull/44608#pullrequestreview-716897). - Update the `com.unity.test-framework.performance` dependency from `2.0.8-preview` to latest, `3.0.3`. - Fix the asmdef references as the graphics perf package was missing a reference on the performance package. I switched from using GUIDs to full names because I believe we should prefer clarity over the only other benefit according [to the docs](https://docs.unity3d.com/Manual/class-AssemblyDefinitionImporter.html#general), which is to not have to update the references when their names change (which basically never happens for these packages - there is close to 0 code churn). **Finally I noticed the switch jobs were broken on 21.3 because we're using the ABV subset dependency** to build the switch support ([example](https://unity-ci.cds.internal.unity3d.com/job/34205305/results?r=34205342)). So this PR is switching with the regular dependency. The jobs are now working ([example](https://unity-ci.cds.internal.unity3d.com/job/34679764/results)). @pauld, added you for all the VFX Graph client side testing library changes.
Added Additional Resources to URP Lighting docs landing page
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.