Matrix unit testing #191
Open
Matrix unit testing #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New file tree "tests" next to "src" dir containing : + source files (tests-matrix.*) with 20 tests on class Matrix + a cmake tree of CMakelists.txt (+ 1 file *.cmake) in order to generate makefiles or a .sln file (depending on the os) - note that, in order to shorten the time between a refactoring of Matrix and a unit test run on Matrix, a convenient tiny matrix.lib (libmatrix.a) is created at compilation. This library is built from matrix.h/hxx and the smallest set of Antares source files that are needed to isolate Matrix class, so that it can be unit-tested. If Matrix changes, it can be compiled and tested swiftly, apart from Antares software.
…nit tests - the jit manager is supposed to make more clear usage of just-in-time which is quite confusing otherwise. - we start to replace some code snippet with usage of jit manager in Matrix::saveToCSVFile(...) - we add 3 more unit tests to characterize the matrix unload following the matrix saving
we only enrich the jit manager with 2 new methods, more clear in their names (and therefore their intention) than the previous piece of code they replace
The added unit tests regard the saving itself, not the previous possible matrix load or the just-in-time.
Matrices' internal save to CSV file descriptor function not entirely covered by unit tests run, so we build a new test for it.
addHint turned to true means : starts printing file by printing the matrix dimensions. This is unclear. addHint becomes print_dimensions
Method internalSaveToFileDescriptor(...) (that handles matrix-to-buffer dumping) contains a complicated if-else, and code duplication. We export this complexity elsewhere, under the form of a polymorphism : creation of a matrix-to-buffer dumper depending on the matrix size and coefficients type, and on the numbers after decimal is asked for.
|
|
|
Stale pull request message |
|
|
meslubi2021
force-pushed
the
New-Antares-Emulator-4
branch
from
2521825 to
c6a693e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.