Feature/ramping model scalian #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for the first hour is constrained the production of the last hour + remove commented ramping debug logs
…rs in the header file
…zing the NODU variables during the second optimization step for the cluster with ramping
… problemhebdo constrainst vectors length
… ramping model to fix issue with ramping behavior + update of the output ramping cost to be aligned with the constraints
…nits as it is already included in the starting thermal units term
…nto feature/ramping_model_scalian
Problème constaté par Amine sur le MILP avec Xpress. L'erreur est du à un mauvais ceiling sur des valeurs égales à n+10^-10 qui deviennent n+1 avec le ceil au lieu de n. --------- Co-authored-by: Juliette-Gerbaux <[email protected]> Co-authored-by: payetvin <[email protected]> Co-authored-by: Vincent Payet <[email protected]> Co-authored-by: Florian Omnès <[email protected]>
On a vector, `push_back` triggers reallocations and copies/moves if the vector capacity is too small. This degrades performance and can be avoided easily by using `reserve`.
- Remove most `new[]` and `delete[]` from output variables - Remove constructor & destructor declarations & definitions (the default constructor is now used) - Make class `IntermediateValues` copyable and assignable, since it is required for `std::vector<IntermediateValues>::resize` Some `new[]` / `delete[]` remain. They are more difficult to remove due to template shenanigans. This is the case for variables with dynamic columns, or spatial agregation.
Bumps [mattnotmitt/doxygen-action](https://github.com/mattnotmitt/doxygen-action) from 1.9.8 to 1.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mattnotmitt/doxygen-action/releases">mattnotmitt/doxygen-action's releases</a>.</em></p> <blockquote> <h2>Doxygen v1.12.0</h2> <ul> <li>Based on alpine 3.21</li> </ul> <h2>Doxygen v1.11.0</h2> <p>Based on Alpine 3.20.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mattnotmitt/doxygen-action/commit/b84fe17600245bb5db3d6c247cc274ea98c15a3b"><code>b84fe17</code></a> v1.12.0</li> <li><a href="https://github.com/mattnotmitt/doxygen-action/commit/6627c43cfd4f41d5d2161501813eb1e254e3f71f"><code>6627c43</code></a> Update readme versions</li> <li>See full diff in <a href="https://github.com/mattnotmitt/doxygen-action/compare/v1.9.8...v1.12.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abdoulbari Zaher <[email protected]>
- Remove default constructor/destructor - Remove useless `std::make_shared`, use the stack instead
…s` (#2593) Add unit tests in class `IntermediateValues` which is used for the time aggregation of the results, both for a full year and a partial year.
Co-authored-by: Florian OMNES <[email protected]>
`std::exception`'s constructors don't accept `std::strings`, so it's a bit strange to override method `what` https://en.cppreference.com/w/cpp/error/exception/exception
Remove `addVariables_`, `std::make_unique`, etc. Keep the same overall behavior.
Associated to [epic 4.1](https://gopro-collaboratif.rte-france.com/pages/viewpage.action?pageId=411149942). Associated to [ticket ANT-2031](https://gopro-tickets.rte-france.com/browse/ANT-2031) --------- Co-authored-by: Florian OMNES <[email protected]> Co-authored-by: Florian Omnès <[email protected]>
Signed-off-by: Peter Mitri <[email protected]>
Merging with latest developements to pass tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.