Skip to content

[feature/multi2delaf] Add a configuration file parser#124

Open
selgueti wants to merge 4 commits into
UnitexGramLab:masterfrom
selgueti:master
Open

[feature/multi2delaf] Add a configuration file parser#124
selgueti wants to merge 4 commits into
UnitexGramLab:masterfrom
selgueti:master

Conversation

@selgueti
Copy link
Copy Markdown
Contributor

@selgueti selgueti commented Jul 5, 2022

Description

Add a parser for the configuration file that specifies how to transcode the multidelaf string into a delaf-format tag.

Motivation and Context

[issue #51] Generate dictionaries based on morphological dictionary-graphs

Specification of configuration file:

Example of configuration file:

Type of files

  • bin: Binary files
  • ci: Continuous integration files
  • doc: Documentation files
  • Plain-text source code files

Level of change

  • break: Breaking change
  • exp: Experimental change
  • tmp: Temporal change
  • major: Major change
  • minor: Minor change
  • revert: Revert a commit change
  • sec: Vulnerability-related change
  • None of the above (normal change)

Type of change

  • deprecat: Deprecation of a once-stable feature
  • enhance: Enhancement in existing functionality
  • fix: Bug fix
  • feature: New feature
  • hotfix: Hotfix for bugs
  • refactor: Improve coding style, comments
  • remove: Remove a feature

Checklist:

  • My code compiles
  • My code does not generate new warnings
  • My code only implements a single fix or feature
  • My code follows the code style of this project
  • My code includes javadoc/doxygen where appropriate
  • My code is well factored, so that there is not repetitive code in the wild
  • My code does not refactor the surrounding code unless necessary
  • My code does not require a change in the documentation, if so I already opened an issue to list the changes
  • I have read the CONTRIBUTING document
  • I have read the Pull Request/Commit Message Guidelines
  • I have given a clear and concise title to my pull request following the above guidelines
  • I understand that all commits on my pull request will be squashed to a single good one
  • All above points were checked and are marked

@pullapprove pullapprove Bot requested a review from gvollant July 5, 2022 16:08
Copy link
Copy Markdown
Member

@martinec martinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it turns out, the Unitex code is not compatible with the standard libraries, for example std::unique_ptr, using them would limit the ability to compile the code under architectures, platforms or other C/C++ compilers that are not distributed with implementations of the standard libraries.

Instead of Vector you should use List_* structures or other available structures. This, in the same way that instead of std::string you should use unichar, uString, or UnitexString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants