security: Add zero address validation in ERC6909 transfers (#1028)#1032
Open
zhaog100 wants to merge 1 commit intoUniswap:mainfrom
Open
security: Add zero address validation in ERC6909 transfers (#1028)#1032zhaog100 wants to merge 1 commit intoUniswap:mainfrom
zhaog100 wants to merge 1 commit intoUniswap:mainfrom
Conversation
) ## Security Analysis Reported in Uniswap#1028 - ERC6909 security audit. ## Valid Findings ✅ **Missing Input Validation** - transfer/transferFrom functions did not validate zero address. ## Invalid Findings (Solidity 0.8.0+ built-in protections) ❌ **Reentrancy** - No external calls, Solidity 0.8.0+ has reentrancy protection. ❌ **Arithmetic Overflow** - Solidity 0.8.0+ has built-in overflow checks. ❌ **Authorization** - approve/transfer are authorization mechanisms themselves. ## Fix Added zero address validation: - transfer(): require(receiver != address(0)) - transferFrom(): require(receiver != address(0)) ## Note Other reported issues are not applicable to Solidity 0.8.0+ or are design choices. Closes Uniswap#1028
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Analysis
Reported in #1028 - ERC6909 security audit.
Valid Findings
✅ Missing Input Validation - transfer/transferFrom functions did not validate zero address.
Invalid Findings (Solidity 0.8.0+ built-in protections)
❌ Reentrancy - No external calls, Solidity 0.8.0+ has reentrancy protection.
❌ Arithmetic Overflow - Solidity 0.8.0+ has built-in overflow checks (no SafeMath needed).
❌ Authorization - approve/transfer are authorization mechanisms themselves.
Fix
Added zero address validation:
Note
Other reported issues are not applicable to Solidity 0.8.0+ or are design choices.
Closes #1028