test: add fee growth direction assertions (closes #606)#1017
Open
PrazwalR wants to merge 1 commit intoUniswap:mainfrom
Open
test: add fee growth direction assertions (closes #606)#1017PrazwalR wants to merge 1 commit intoUniswap:mainfrom
PrazwalR wants to merge 1 commit intoUniswap:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606
Problem
Flipping
zeroForOnein the fee growth global storage assignment (Pool.sol:445-449) does not cause any existing test to fail.This means incorrect fee accounting direction could go undetected.
Solution
Added
FeeGrowthDirection.t.solwith tests asserting that after a single-direction swap,feeGrowthGlobalincreases only for the input token's tracker, while the other remains zero.Test Coverage
zeroForOne_exactInputoneForZero_exactInputzeroForOne_exactOutputoneForZero_exactOutputbidirectional_independentwithTickCrossing_zeroForOnewithTickCrossing_oneForZerofuzz_feeGrowthDirectionnative_zeroForOnenative_oneForZeroVerification
Flipping
!zeroForOne→zeroForOneatPool.sol:445causes all 10 tests to fail immediately, confirming the tests detect incorrect fee growth direction.