Using category list to make sure only unique categories are included #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Yaqiang! I've added the file that triggered the initial issue to our extended unit tests. Now that this file can be read (thanks to your fix), it uncovered another unrelated bug. I have a fix for that, so nothing for you to worry about with respect to your PR. But thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The commit: c54869c#diff-87d57326a1634222cff4aaa832d13fd2b0c8578b6965291a81e514c100d6e11b try to read all messages when the bufr data file contains multiple message categories. But the bug exists when the messages were not arranged in file category by category. So I use category list to make sure only unique categories are included in the
protoMessageslist to solve the bug.PR Checklist
Link to this issue: 5.7.0 Upgrade - ucar.nc2.NetcdfFiles.openInMemory Errors for BUFR Files #1418
until ready for review