Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved gaussian2d estimator #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Geegee
Copy link
Contributor

@Geegee Geegee commented Nov 21, 2022

Trying to improve the estimator for the 2 D gaussian fit function

Description

Transform the recorded counts into a probability distribution.
Estimate mean and variance from that.

Motivation and Context

Can help when the photon source moved quiet a bit from the previous
position.

How Has This Been Tested?

On the dummy. Ideally this would get some testing in action.
Although the method to estimate was already used in the old qudi.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.md.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant